[PR] [main] Create `DefaultLayout` independent of `PatternLayout` (#3118) [logging-log4j2]

2025-04-01 Thread via GitHub
ppkarwasz opened a new pull request, #3584: URL: https://github.com/apache/logging-log4j2/pull/3584 Currently, `PatternLayout` and all its patterns are a required element of Log4j Core, since `DefaultConfiguration` uses it. The default configuration is used in all Log4j Core installation as

Re: [PR] Update CI Ubuntu versions [logging-log4cxx]

2025-04-01 Thread via GitHub
ppkarwasz commented on PR #492: URL: https://github.com/apache/logging-log4cxx/pull/492#issuecomment-2768803760 Is there a way to make the `abi.dump` in this repository more easily comparable using `diff`? Sorting the entries by `MnglName` should help, right? -- This is an automated messa

Re: [PR] fix ShutdownDisabledTest and LoggerContext_shutdownDisable changelog [logging-log4j2]

2025-04-01 Thread via GitHub
ppkarwasz merged PR #3581: URL: https://github.com/apache/logging-log4j2/pull/3581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Compressing rolled files (logging-log4net)

2025-04-01 Thread via GitHub
FreeAndNil commented on issue #234: URL: https://github.com/apache/logging-log4net/issues/234#issuecomment-2770360113 @lraulea can you check whether this also occurs with the changes from #232 ? There is an important fix for RollingFileAppender. -- This is an automated message from the

Re: [I] Compressing rolled files (logging-log4net)

2025-04-01 Thread via GitHub
lraulea commented on issue #234: URL: https://github.com/apache/logging-log4net/issues/234#issuecomment-2770382692 > can you check whether this also occurs with the changes from https://github.com/apache/logging-log4net/pull/232 ? Sure! Is there a preview nuget version I can c

Re: [PR] Enforce RTC style on `logging-log4j2` [logging-log4j2]

2025-04-01 Thread via GitHub
jvz commented on PR #3582: URL: https://github.com/apache/logging-log4j2/pull/3582#issuecomment-2770615166 I'm ok with this change for now. I will be quite loud about it, however, if it ends up being an issue in the future, but I hope that won't be the case! -- This is an automated messag

Re: [PR] Update CI Ubuntu versions [logging-log4cxx]

2025-04-01 Thread via GitHub
swebb2066 merged PR #492: URL: https://github.com/apache/logging-log4cxx/pull/492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] Bump joda-time:joda-time from 2.12.7 to 2.14.0 [logging-log4j-samples]

2025-04-01 Thread via GitHub
github-actions[bot] merged PR #303: URL: https://github.com/apache/logging-log4j-samples/pull/303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

Re: [I] Compressing rolled files (logging-log4net)

2025-04-01 Thread via GitHub
lraulea commented on issue #234: URL: https://github.com/apache/logging-log4net/issues/234#issuecomment-2770007469 @FreeAndNil may i share with you a test result? overriding the `OpenFile()` looks promising, but I'm not there yet. ``` protected override void OpenFile

Re: [I] Compressing rolled files (logging-log4net)

2025-04-01 Thread via GitHub
FreeAndNil commented on issue #234: URL: https://github.com/apache/logging-log4net/issues/234#issuecomment-2770427243 @lraulea I've published https://github.com/apache/logging-log4net/releases/tag/rc%2F3.0.5-preview.2 with the relevant changes. -- This is an automated message from the A

Re: [PR] fix ShutdownDisabledTest and LoggerContext_shutdownDisable changelog [logging-log4j2]

2025-04-01 Thread via GitHub
ppkarwasz commented on code in PR #3581: URL: https://github.com/apache/logging-log4j2/pull/3581#discussion_r2022345715 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/ShutdownDisabledTest.java: ## @@ -35,6 +35,6 @@ void testShutdownFlag(final Configuration config

[PR] [main] Correct example property syntax for PatternMatch under ScriptP… [logging-log4j2]

2025-04-01 Thread via GitHub
ppkarwasz opened a new pull request, #3583: URL: https://github.com/apache/logging-log4j2/pull/3583 …atternSelector. (#3092) Fixes #3078 (cherry picked from commit 062b945bc2cb852966b001c232051eb15456b9a4) -- This is an automated message from the Apache Git Service. To re

Re: [PR] Enforce RTC style on `logging-log4j2` [logging-log4j2]

2025-04-01 Thread via GitHub
ppkarwasz commented on PR #3582: URL: https://github.com/apache/logging-log4j2/pull/3582#issuecomment-2771446776 If you make small PRs and add two reviewers (e.g., @vy and me), it shouldn't be a problem. For bigger changes you can use a feature branch and make smaller PRs into it. For

Re: [PR] fix ShutdownDisabledTest and LoggerContext_shutdownDisable changelog [logging-log4j2]

2025-04-01 Thread via GitHub
github-actions[bot] commented on PR #3581: URL: https://github.com/apache/logging-log4j2/pull/3581#issuecomment-2768478610 Job Requested goals Build Tool Version Build Outcome Build Scan® build-

Re: [PR] fix ShutdownDisabledTest and LoggerContext_shutdownDisable changelog [logging-log4j2]

2025-04-01 Thread via GitHub
Pluto-syd commented on code in PR #3581: URL: https://github.com/apache/logging-log4j2/pull/3581#discussion_r2022497237 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/ShutdownDisabledTest.java: ## @@ -35,6 +35,6 @@ void testShutdownFlag(final Configuration config

[PR] Enforce RTC style on `logging-log4j2` [logging-log4j2]

2025-04-01 Thread via GitHub
ppkarwasz opened a new pull request, #3582: URL: https://github.com/apache/logging-log4j2/pull/3582 Following the [PMC discussion in September 2024](https://lists.apache.org/thread/6gbos0rn3k4y3wjb1hcgnnols4ogqckl), this PR changes the branch protection rules for the `logging-log4j2` reposi

Re: [PR] Update CI Ubuntu versions [logging-log4cxx]

2025-04-01 Thread via GitHub
swebb2066 commented on PR #492: URL: https://github.com/apache/logging-log4cxx/pull/492#issuecomment-2768953316 > Is there a way to make the abi.dump in this repository more easily comparable using diff? Sorting the entries by MnglName should help, right? No, it is full of magic numbe