ppkarwasz commented on code in PR #3581:
URL: https://github.com/apache/logging-log4j2/pull/3581#discussion_r2022345715
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/ShutdownDisabledTest.java:
##########
@@ -35,6 +35,6 @@ void testShutdownFlag(final Configuration config, final
LoggerContext ctx) throw
Field shutdownCallback =
LoggerContext.class.getDeclaredField("shutdownCallback");
Object fieldValue = ReflectionUtil.getFieldValue(shutdownCallback,
ctx);
assertFalse(config.isShutdownHookEnabled(), "Shutdown hook is
enabled");
- assertNull(fieldValue, "Shutdown callback is null");
+ assertNull(fieldValue, "Shutdown callback is not null");
Review Comment:
```suggestion
assertNull(fieldValue, "Shutdown callback");
```
IMHO both the old and new message are redundant. With the proposed change
the failure message will be:
```
Shutdown callback ==> expected: <null> but was: <something>
```
which is pretty clear about what we expect. Adding "is null" or "is not
null" is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
