Re: [PR] Implements an event service and demonstrates its use for sending/receiving SSL key/trust store changes (logging-log4j2)

2025-02-11 Thread via GitHub
ppkarwasz commented on PR #3378: URL: https://github.com/apache/logging-log4j2/pull/3378#issuecomment-2651290356 The PR looks nice, but I need some time to analyze the existing code to see if we can reuse something. [`WatchManager`](https://logging.apache.org/log4j/2.x/javadoc/log4j-core/or

Re: [I] AbstractConfiguration#initialize - making two passes generates invalid configuration - no check if initialization has already been performed (logging-log4j2)

2025-02-11 Thread via GitHub
ppkarwasz commented on issue #3449: URL: https://github.com/apache/logging-log4j2/issues/3449#issuecomment-2651265326 @JWT007, Thanks for the report. I would couple it #1653: probably all lifecycle methods are not idempotent. -- This is an automated message from the Apache Git Ser

Re: [I] NullReferenceException in OpenFile: locking model not instantiated (logging-log4net)

2025-02-11 Thread via GitHub
tmct commented on issue #223: URL: https://github.com/apache/logging-log4net/issues/223#issuecomment-2650582232 Hi @FreeAndNil - I would love to attempt a log4net 3.x migration but unfortunately it is a relatively low priority for me at work at the moment, sorry. Will let you know when we

Re: [I] ConfigurationStrSubstitutor - incorrect class-level Javadoc (logging-log4j2)

2025-02-11 Thread via GitHub
ppkarwasz commented on issue #3170: URL: https://github.com/apache/logging-log4j2/issues/3170#issuecomment-2651440477 Thanks for noticing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [I] ConfigurationStrSubstitutor - incorrect class-level Javadoc (logging-log4j2)

2025-02-11 Thread via GitHub
ppkarwasz closed issue #3170: ConfigurationStrSubstitutor - incorrect class-level Javadoc URL: https://github.com/apache/logging-log4j2/issues/3170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] ConfigurationStrSubstitutor - incorrect class-level Javadoc (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 commented on issue #3170: URL: https://github.com/apache/logging-log4j2/issues/3170#issuecomment-2651423281 Hi @ppkarwasz the PR from @jaykataria was merged - should this be closed? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[PR] Bump org.apache.logging:logging-parent from 11.3.0 to 12.0.0 [logging-log4j-audit-sample]

2025-02-11 Thread via GitHub
dependabot[bot] opened a new pull request, #68: URL: https://github.com/apache/logging-log4j-audit-sample/pull/68 Bumps [org.apache.logging:logging-parent](https://github.com/apache/logging-parent) from 11.3.0 to 12.0.0. Release notes Sourced from https://github.com/apache/logging

Re: [I] NullReferenceException in OpenFile: locking model not instantiated (logging-log4net)

2025-02-11 Thread via GitHub
tmct commented on issue #223: URL: https://github.com/apache/logging-log4net/issues/223#issuecomment-2650583387 (And indeed, I didn't get the chance to try on that isolated app, would have to dig that up again, sorry) -- This is an automated message from the Apache Git Service. To respon

[PR] Fixed TypeConverters#LevelConverter javadoc (#3359) (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 opened a new pull request, #3455: URL: https://github.com/apache/logging-log4j2/pull/3455 [#3359] Only updated javadoc per ticket and added changelog entry for 2.25.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Javadoc: TypeConverters convert for "Level" incorrectly documents behaviour for invalid value (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 commented on issue #3359: URL: https://github.com/apache/logging-log4j2/issues/3359#issuecomment-2652186798 Hi @ppkarwasz - another PR - this one should be an easy one :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Fixed AbstractFilterable#isFiltered javadoc (#3300) (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 opened a new pull request, #3456: URL: https://github.com/apache/logging-log4j2/pull/3456 [#3300] Fixed javadoc for AbstractFilterable#isFilterable per ticket + added changelog -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] NullReferenceException in OpenFile: locking model not instantiated (logging-log4net)

2025-02-11 Thread via GitHub
FreeAndNil commented on issue #223: URL: https://github.com/apache/logging-log4net/issues/223#issuecomment-2650599143 @tmct no problem, please re-open when you find the time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] NullReferenceException in OpenFile: locking model not instantiated (logging-log4net)

2025-02-11 Thread via GitHub
FreeAndNil closed issue #223: NullReferenceException in OpenFile: locking model not instantiated URL: https://github.com/apache/logging-log4net/issues/223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Make copy of appender list when removing all, for increased thread-safety (logging-log4net)

2025-02-11 Thread via GitHub
FreeAndNil commented on PR #222: URL: https://github.com/apache/logging-log4net/pull/222#issuecomment-2650601837 @tmct Will you find the time to complete within this week? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] Bugfix/log4 j 3441 (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 commented on PR #3451: URL: https://github.com/apache/logging-log4j2/pull/3451#issuecomment-2651626060 @ppkarwasz - build failed - but I don't think I can fix it? `Error: This request has been automatically failed because it uses a deprecated version of `actions/cache: 0c45773

[PR] Only set default configuration name if none has been previously set (… (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 opened a new pull request, #3454: URL: https://github.com/apache/logging-log4j2/pull/3454 [#3431] AbstractConfiguration#setToDefault() - only sets default configuration name if none has been previously set, + added test for this change + added changelog entry -- Th

Re: [I] CompositeConfiguration merges into the root node of the first configuration instead of using its own root-node (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 commented on issue #3458: URL: https://github.com/apache/logging-log4j2/issues/3458#issuecomment-2652350102 @ppkarwasz / @rgoers - I am ready to create a PR for this, but I noticed something else - if you agree I will adjust the description and include the change in the PR. -

Re: [I] make SocketAppender support server list (logging-log4j2)

2025-02-11 Thread via GitHub
lu-xiaoshuang commented on issue #3442: URL: https://github.com/apache/logging-log4j2/issues/3442#issuecomment-2652418157 > [@lu-xiaoshuang](https://github.com/lu-xiaoshuang), > > > At present, a SocketAppender only supports one address-port. Seems that remote server represented by t

Re: [I] make SocketAppender support server list (logging-log4j2)

2025-02-11 Thread via GitHub
ppkarwasz commented on issue #3442: URL: https://github.com/apache/logging-log4j2/issues/3442#issuecomment-2652808212 > KafkaAppender is not capable of sending logs generated by org.apache.kafka:kafka-clients:jar, is it? Right, that usually causes problems with recursive logging.

Re: [I] Javadoc - AbstractFilterable#isFiltered incorrect (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 commented on issue #3300: URL: https://github.com/apache/logging-log4j2/issues/3300#issuecomment-2652221527 @ppkarwasz - created PR for this - another simple one @jaykataria - sorry to steal this one from you :( - its been a month and I am trying to close out some of the t

[PR] Fixed handling of null 'replacement' parameter in RegexReplacement#createRegexReplacement (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 opened a new pull request, #3457: URL: https://github.com/apache/logging-log4j2/pull/3457 [#3215] Returns *null* if the 'replacement' parameter is *null*. * per other builder methods in Log4j a invalid input parameter should result in a fast-fail returning null + adde

Re: [I] RegexReplacement static factory method doesn't handle null 'replacement' attribute correctly (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 commented on issue #3215: URL: https://github.com/apache/logging-log4j2/issues/3215#issuecomment-2652279477 @ppkarwasz - another small PR - simple fix @jaykataria - sorry to steal this one from you :( - its been a month and I am trying to close out some of the tickets I cr

Re: [PR] Improve validation for AsyncWaitStrategyFactoryConfig for null/empty 'factoryClassName'. #3159 (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 commented on PR #3160: URL: https://github.com/apache/logging-log4j2/pull/3160#issuecomment-2652506373 Closing this PR - will cleanup and resubmit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Improve validation for AsyncWaitStrategyFactoryConfig for null/empty 'factoryClassName'. #3159 (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 closed pull request #3160: Improve validation for AsyncWaitStrategyFactoryConfig for null/empty 'factoryClassName'. #3159 URL: https://github.com/apache/logging-log4j2/pull/3160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] AbstractConfiguration clears Configuration name if some conditions are met (i.e. no defined loggers) (logging-log4j2)

2025-02-11 Thread via GitHub
ppkarwasz commented on issue #3431: URL: https://github.com/apache/logging-log4j2/issues/3431#issuecomment-2651680020 Thanks a lot! I will have some time next week to look at the open PRs. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] LoggerConfig.RootLogger.Builder#withtFilter (typo in method name / only partially fixed) (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 commented on issue #3369: URL: https://github.com/apache/logging-log4j2/issues/3369#issuecomment-2651803537 @ppkarwasz - it took me a while but I added tthe change log entry for 2.25.0 I also fixed spotless problem and updated package versions for baseline -- This is an auto

[I] CompositeConfiguration merges into the root node of the first configuration instead of using its own root-node (logging-log4j2)

2025-02-11 Thread via GitHub
JWT007 opened a new issue, #3458: URL: https://github.com/apache/logging-log4j2/issues/3458 Log4j 2.24..3 The composite configuration uses the root-node of the first configuration in the provided list as the basis for the merge of all configurations. ``` rootNode

Re: [I] make SocketAppender support server list (logging-log4j2)

2025-02-11 Thread via GitHub
lu-xiaoshuang commented on issue #3442: URL: https://github.com/apache/logging-log4j2/issues/3442#issuecomment-2652407866 > [@lu-xiaoshuang](https://github.com/lu-xiaoshuang), curious: what is the log sink you use where you encounter this problem? logstash -- This is an automated