[I] CompositeConfiguration merges into the root node of the first configuration instead of using its own root-node (logging-log4j2)

[via GitHub]

JWT007 opened a new issue, #3458:
URL: https://github.com/apache/logging-log4j2/issues/3458

   Log4j 2.24..3
   ----
   The composite configuration uses the root-node of the first configuration in 
the provided list as the basis for the merge of all configurations.
   
   ```
           rootNode = configurations.get(0).getRootNode();
          ...
           for (final AbstractConfiguration config : configurations) {
               mergeStrategy.mergeRootProperties(rootNode, config);
           }
   ```
   
   As @ppkarwasz mentioned in the comments of (#3173) this is an error because 
it changes the original source configuration instead of populating the 
composite.
   
   The fix would be to use the composite configuration's rootNode (protected 
access via 'AbstractConfiguration').  The rootNode is created empty by the 
super-constructor.
   
   ```
           for (final AbstractConfiguration config : configurations) {
               mergeStrategy.mergeRootProperties(rootNode, config);
           }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org