Re: [PR] add ability to set hostname in TelnetAppender [logging-log4cxx]

2025-05-12 Thread via GitHub
swebb2066 merged PR #498: URL: https://github.com/apache/logging-log4cxx/pull/498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] add ability to set hostname in TelnetAppender [logging-log4cxx]

2025-05-09 Thread via GitHub
swebb2066 commented on code in PR #498: URL: https://github.com/apache/logging-log4cxx/pull/498#discussion_r2082841817 ## src/test/cpp/net/telnetappendertestcase.cpp: ## @@ -106,6 +106,7 @@ class TelnetAppenderTestCase : public AppenderSkeletonTestCase a

Re: [PR] add ability to set hostname in TelnetAppender [logging-log4cxx]

2025-05-09 Thread via GitHub
swebb2066 commented on code in PR #498: URL: https://github.com/apache/logging-log4cxx/pull/498#discussion_r2082841817 ## src/test/cpp/net/telnetappendertestcase.cpp: ## @@ -106,6 +106,7 @@ class TelnetAppenderTestCase : public AppenderSkeletonTestCase a

Re: [PR] add ability to set hostname in TelnetAppender [logging-log4cxx]

2025-05-09 Thread via GitHub
michieldwitte commented on PR #498: URL: https://github.com/apache/logging-log4cxx/pull/498#issuecomment-2865402648 > Could you confirm you have been able to test this PR on a machine with multiple network interfaces? By default it accepts on any network interface, I've validated it u

Re: [PR] add ability to set hostname in TelnetAppender [logging-log4cxx]

2025-05-09 Thread via GitHub
michieldwitte commented on code in PR #498: URL: https://github.com/apache/logging-log4cxx/pull/498#discussion_r2081069212 ## src/main/include/log4cxx/net/telnetappender.h: ## @@ -116,6 +116,16 @@ class LOG4CXX_EXPORT TelnetAppender : public AppenderSkeleton */

Re: [PR] add ability to set hostname in TelnetAppender [logging-log4cxx]

2025-05-08 Thread via GitHub
swebb2066 commented on code in PR #498: URL: https://github.com/apache/logging-log4cxx/pull/498#discussion_r2080830132 ## src/main/include/log4cxx/net/telnetappender.h: ## @@ -116,6 +116,16 @@ class LOG4CXX_EXPORT TelnetAppender : public AppenderSkeleton */

[PR] add ability to set hostname in TelnetAppender [logging-log4cxx]

2025-05-08 Thread via GitHub
michieldwitte opened a new pull request, #498: URL: https://github.com/apache/logging-log4cxx/pull/498 Add ability to set hostname in TelnetAppender -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t