swebb2066 commented on code in PR #498:
URL: https://github.com/apache/logging-log4cxx/pull/498#discussion_r2080830132
##########
src/main/include/log4cxx/net/telnetappender.h:
##########
@@ -116,6 +116,16 @@ class LOG4CXX_EXPORT TelnetAppender : public
AppenderSkeleton
*/
void setPort(int newValue);
+ /**
+ The <b>Hostname</b> on which to accept connections.
+ */
+ LogString getHostname() const;
Review Comment:
Would 'NodeName' be bettter than 'HostName' given it identifies the local
machine interface to be used?
I believe that would correspond better with [the underlying
terminology](https://man7.org/linux/man-pages/man3/getaddrinfo.3.html) and
distinguish it from a url used to identify a remote server.
##########
src/main/include/log4cxx/net/telnetappender.h:
##########
@@ -116,6 +116,16 @@ class LOG4CXX_EXPORT TelnetAppender : public
AppenderSkeleton
*/
void setPort(int newValue);
+ /**
+ The <b>Hostname</b> on which to accept connections.
+ */
+ LogString getHostname() const;
+
+ /**
+ Use \c newValue as the Hostname on which to accept connections.
Review Comment:
I suggest 'Accept connections on the the \c newValue local interface. By
default connections are accepted on any network interface device.'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
