vy commented on PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#issuecomment-2742608425
@Pluto-syd, could you please
1. update your branch: `git pull upstream 2.x` (assuming `upstream` points
to `g...@github.com:apache/logging-log4j2.git`)
1. add a `src/changelog/
Pluto-syd commented on PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#issuecomment-2743755535
@vy Thanks for the reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
ppkarwasz merged PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
Pluto-syd commented on PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#issuecomment-2725356812
> This PR need to be merged with `2.x` for the CI builds to work properly.
I looked at why CI didn't pass, and made some changes to the way the
log4j-spring-boot module rel
ppkarwasz commented on PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#issuecomment-2724628326
This PR need to be merged with `2.x` for the CI builds to work properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vy commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995110621
##
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java:
##
Review Comment:
@rgoers @ppkarwasz These changes look legit to me, but would you
vy commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995155623
##
log4j-core-test/src/test/resources/log4j-test3.xml:
##
@@ -15,7 +15,7 @@
~ See the License for the specific language governing permissions and
~ limitations
vy commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995159610
##
log4j-core-test/src/test/resources/log4j-test3.xml:
##
@@ -15,7 +15,7 @@
~ See the License for the specific language governing permissions and
~ limitations
vy commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995158481
##
log4j-core-test/src/test/resources/log4j-test3.xml:
##
@@ -15,7 +15,7 @@
~ See the License for the specific language governing permissions and
~ limitations
ppkarwasz commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995118826
##
log4j-core-test/src/test/java/org/apache/logging/log4j/core/ShutdownDisabledTest.java:
##
@@ -17,16 +17,24 @@
package org.apache.logging.log4j.core;
imp
rgoers commented on code in PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#discussion_r1995121389
##
log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java:
##
Review Comment:
Seems correct to me as well.
--
This is an automated mes
github-actions[bot] commented on PR #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508#issuecomment-2692925519
Job
Requested goals
Build Tool Version
Build Outcome
Build Scan®
build-
Pluto-syd opened a new pull request, #3508:
URL: https://github.com/apache/logging-log4j2/pull/3508
Fix shutdownDisable not taking effect(#2614)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
13 matches
Mail list logo
