Re: [PR] Enabled GH discussions [logging-log4j2]

2025-03-19 Thread via GitHub
ppkarwasz commented on code in PR #3552: URL: https://github.com/apache/logging-log4j2/pull/3552#discussion_r2003869362 ## .asf.yaml: ## @@ -37,6 +37,7 @@ github: homepage: https://logging.apache.org/log4j/2.x features: issues: true +discussions: true Review Comm

Re: [PR] Enabled GH discussions [logging-log4j2]

2025-03-19 Thread via GitHub
swebb2066 commented on PR #3552: URL: https://github.com/apache/logging-log4j2/pull/3552#issuecomment-2739023255 You will also need to add an e-mail in to 'notifications' section like: ``` notifications: jira_options: link label discussions: d...@logging.apache.org ``` o

Re: [PR] Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre [logging-log4j-samples]

2025-03-19 Thread via GitHub
github-actions[bot] merged PR #296: URL: https://github.com/apache/logging-log4j-samples/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[PR] docsImprove String concatenation best practice [logging-log4j2]

2025-03-19 Thread via GitHub
ppkarwasz opened a new pull request, #3553: URL: https://github.com/apache/logging-log4j2/pull/3553 This change splits the "don't use String concatenation" best practice into two parts: - A recommendation concerning performance: string concatenation is not efficient if the logger is

[PR] Enabled GH discussions [logging-log4j2]

2025-03-19 Thread via GitHub
grobmeier opened a new pull request, #3552: URL: https://github.com/apache/logging-log4j2/pull/3552 A recent change made it necessary to enable GH discussions on .asf.yml: https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#repository-features If we want to continue

Re: [PR] Enabled GH discussions [logging-log4j2]

2025-03-19 Thread via GitHub
grobmeier commented on code in PR #3552: URL: https://github.com/apache/logging-log4j2/pull/3552#discussion_r2003871677 ## .asf.yaml: ## @@ -37,6 +37,7 @@ github: homepage: https://logging.apache.org/log4j/2.x features: issues: true +discussions: true Review Comm

Re: [I] Possible bug in LoggerContext.updateLoggers throwing ConcurrentModificationException [logging-log4j2]

2025-03-19 Thread via GitHub
ppkarwasz closed issue #3551: Possible bug in LoggerContext.updateLoggers throwing ConcurrentModificationException URL: https://github.com/apache/logging-log4j2/issues/3551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Possible bug in LoggerContext.updateLoggers throwing ConcurrentModificationException [logging-log4j2]

2025-03-19 Thread via GitHub
ppkarwasz commented on issue #3551: URL: https://github.com/apache/logging-log4j2/issues/3551#issuecomment-2736807265 Hi @pmk75, This is a duplicate of #3234 and was fixed in release `2.24.3` (see [release notes](https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2

Re: [PR] Add example to test transitive compile-time dependencies in Gradle [logging-log4j-samples]

2025-03-19 Thread via GitHub
jjohannes commented on code in PR #279: URL: https://github.com/apache/logging-log4j-samples/pull/279#discussion_r2003199821 ## log4j-samples-gradle-metadata/gradlew: ## @@ -0,0 +1,251 @@ +#!/bin/sh Review Comment: Yes, that would be the drawback. Not sure how important tha

Re: [PR] Upgrade Jekyll docker file [logging-site]

2025-03-19 Thread via GitHub
grobmeier merged PR #8: URL: https://github.com/apache/logging-site/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@log

[I] Possible bug in LoggerContext.updateLoggers throwing ConcurrentModificationException [logging-log4j2]

2025-03-19 Thread via GitHub
pmk75 opened a new issue, #3551: URL: https://github.com/apache/logging-log4j2/issues/3551 ## Description LoggerContext.updateLoggers throws a ConcurrentModificationException randomly when called by javamelody filter initialisation during tomcat startup. Result is that tomcat is inco

Re: [PR] Bump ch.qos.logback:logback-classic from 1.5.17 to 1.5.18 [logging-log4j2]

2025-03-19 Thread via GitHub
github-actions[bot] merged PR #3550: URL: https://github.com/apache/logging-log4j2/pull/3550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[PR] Apply Antora styling to main page [logging-site]

2025-03-19 Thread via GitHub
ppkarwasz opened a new pull request, #9: URL: https://github.com/apache/logging-site/pull/9 This change applies parts of the [Default Antora stylesheet](https://gitlab.com/antora/antora-ui-default/-/tree/master/src/css?ref_type=heads) and the [Log4j style customizations](https://github.com

Re: [PR] Bump com.palantir.javaformat:palantir-java-format from 2.58.0 to 2.59.0 [logging-parent]

2025-03-19 Thread via GitHub
github-actions[bot] merged PR #352: URL: https://github.com/apache/logging-parent/pull/352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[PR] Upgrade Jekyll docker file [logging-site]

2025-03-19 Thread via GitHub
ppkarwasz opened a new pull request, #8: URL: https://github.com/apache/logging-site/pull/8 This change upgrades Jekyll's docker file, since the old images are no longer available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git