Re: [PR] Allow for use of either Qt5 or Qt6 [logging-log4cxx]

2025-03-15 Thread via GitHub
rm5248 commented on PR #488: URL: https://github.com/apache/logging-log4cxx/pull/488#issuecomment-2727154598 Note: if removing the `emit` function prototype breaks the ABI(I don't think it should since it's `private static` and is only inside of the `LogLog` class), we can always wrap it in

[PR] Allow for use of either Qt5 or Qt6 [logging-log4cxx]

2025-03-15 Thread via GitHub
rm5248 opened a new pull request, #488: URL: https://github.com/apache/logging-log4cxx/pull/488 Since Qt `#defines emit`, the `LogLog` class fails to compile properly as the function prototype no longer exists. Oddly this works fine in Qt5, but it breaks with Qt6. We can work around

Re: [PR] Add missing dependencies [logging-log4j-tools]

2025-03-15 Thread via GitHub
alan0428a commented on code in PR #175: URL: https://github.com/apache/logging-log4j-tools/pull/175#discussion_r1997458133 ## log4j-tools-parent/pom.xml: ## @@ -140,6 +146,43 @@ ${xmlunit.version} + + +org.osgi +org.osgi.annotation

Re: [PR] Add missing dependencies [logging-log4j-tools]

2025-03-15 Thread via GitHub
alan0428a commented on PR #175: URL: https://github.com/apache/logging-log4j-tools/pull/175#issuecomment-2727115008 @ppkarwasz I can see it failed to build `log4j-docgen`, because there is a warning in `DescriptorGenerator`. And the compile settting is `failOnWarning=true` for that pac

Re: [PR] Removed @PluginAttribute 'patternFlags' argument from @PluginFactory for RegexFilter. (#3086) [logging-log4j2]

2025-03-15 Thread via GitHub
vy commented on code in PR #3512: URL: https://github.com/apache/logging-log4j2/pull/3512#discussion_r1995087013 ## log4j-core/src/main/java/org/apache/logging/log4j/core/filter/RegexFilter.java: ## @@ -100,59 +242,191 @@ private String targetMessageTest(final Message message) {

Re: [PR] Proofread CVE fix versions [logging-site]

2025-03-15 Thread via GitHub
raboof commented on code in PR #6: URL: https://github.com/apache/logging-site/pull/6#discussion_r1995312754 ## _vulnerabilities.adoc: ## @@ -106,8 +107,8 @@ Independently discovered by Hideki Okamoto of Akamai Technologies, Guy Lederfein |Summary |Thread Context Lookup is vul

Re: [PR] Add CodeQL run for GitHub Actions [logging-parent]

2025-03-15 Thread via GitHub
github-advanced-security[bot] commented on PR #343: URL: https://github.com/apache/logging-parent/pull/343#issuecomment-2709840218 This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull

Re: [PR] Remove Google Analytics from Logging PHP Website (2nd attempt) [logging-log4php-site]

2025-03-15 Thread via GitHub
grobmeier merged PR #3: URL: https://github.com/apache/logging-log4php-site/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]

2025-03-15 Thread via GitHub
vy commented on code in PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r1995039662 ## log4j-core-test/src/test/java/org/apache/logging/log4j/core/LoggerTest.java: ## @@ -544,6 +544,30 @@ void testReconfiguration(final LoggerContext context) throws

Re: [I] Make `logger.error(ex);`, `logger.info(ex);`, etc. print stack trace by default [logging-log4j2]

2025-03-15 Thread via GitHub
ppkarwasz commented on issue #3433: URL: https://github.com/apache/logging-log4j2/issues/3433#issuecomment-2723930666 Some thoughts: - This is a recurring question. I can't find the reference now, but multiple times users asked for `log(Object)` to treat exceptions in a different way

Re: [PR] Add transitive compileOnlyApi (requires static) dependencies [logging-log4j2]

2025-03-15 Thread via GitHub
ppkarwasz commented on code in PR #3450: URL: https://github.com/apache/logging-log4j2/pull/3450#discussion_r1995255964 ## log4j-parent/pom.xml: ## @@ -154,6 +154,15 @@ 4.4.16 5.16.0 + +$[bnd-module-name];access=0;modules=" + biz.aQute.bnd.annotation, +

Re: [PR] Bump co.elastic.clients:elasticsearch-java from 8.17.2 to 8.17.3 in /log4j-layout-template-json-test [logging-log4j2]

2025-03-15 Thread via GitHub
vy commented on PR #3521: URL: https://github.com/apache/logging-log4j2/pull/3521#issuecomment-2724013750 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Proofread CVE fix versions [logging-site]

2025-03-15 Thread via GitHub
ppkarwasz commented on PR #6: URL: https://github.com/apache/logging-site/pull/6#issuecomment-2724317413 > First, I think you should link to https://musigma.blog/2023/11/10/log4shell-history.html. While Matt's page says Log4Shell was fixed in 2.16.0 my recollection was that 2.17.0 was the o

Re: [I] Make `logger.error(ex);`, `logger.info(ex);`, etc. print stack trace by default [logging-log4j2]

2025-03-15 Thread via GitHub
ppkarwasz commented on issue #3433: URL: https://github.com/apache/logging-log4j2/issues/3433#issuecomment-2726435795 > ``` > try > { > doThing(); > } > catch (ThingFailedException ex) > { > logger.error(ex); > throw new WhateverException(ex); // Maybe als

Re: [PR] Add missing dependencies [logging-log4j-tools]

2025-03-15 Thread via GitHub
ppkarwasz commented on code in PR #175: URL: https://github.com/apache/logging-log4j-tools/pull/175#discussion_r1996628015 ## log4j-tools-parent/pom.xml: ## @@ -140,6 +146,43 @@ ${xmlunit.version} + + +org.osgi +org.osgi.annotation