Re: [PR] Fix possible invalid cast [logging-log4cxx]

2025-01-31 Thread via GitHub
swebb2066 commented on code in PR #470: URL: https://github.com/apache/logging-log4cxx/pull/470#discussion_r1938186348 ## src/main/cpp/optionconverter.cpp: ## @@ -343,8 +343,13 @@ LevelPtr OptionConverter::toLevel(const LogString& value, try { - L

[PR] Fix possible invalid cast [logging-log4cxx]

2025-01-31 Thread via GitHub
rm5248 opened a new pull request, #470: URL: https://github.com/apache/logging-log4cxx/pull/470 If a user attempts to load a config file with an improper level set such that a non-level class is attempted to be used, throw an exception instead of accessing invalid memory. -- This is an a

Re: [PR] Update to latest SonarQube scanner version [logging-log4cxx]

2025-01-31 Thread via GitHub
swebb2066 merged PR #469: URL: https://github.com/apache/logging-log4cxx/pull/469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] build fuzzers with utf-8 and wchar_t [logging-log4cxx]

2025-01-31 Thread via GitHub
swebb2066 merged PR #465: URL: https://github.com/apache/logging-log4cxx/pull/465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] Configurator.setRootLevel does not work if multi-release jar is not set (logging-log4j2)

2025-01-31 Thread via GitHub
ppkarwasz commented on issue #3428: URL: https://github.com/apache/logging-log4j2/issues/3428#issuecomment-2628573401 @hongwingl, I don't recommend distributing applications as fat JARs. Using **altered versions** of a library (repackaged) will cause multiple problems that the autho

Re: [I] Configurator.setRootLevel does not work if multi-release jar is not set (logging-log4j2)

2025-01-31 Thread via GitHub
ppkarwasz closed issue #3428: Configurator.setRootLevel does not work if multi-release jar is not set URL: https://github.com/apache/logging-log4j2/issues/3428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Suspect deadlock in InternalLoggerRegistry (intermittent) (logging-log4j2)

2025-01-31 Thread via GitHub
ppkarwasz commented on issue #3399: URL: https://github.com/apache/logging-log4j2/issues/3399#issuecomment-2628552483 @vy, Feel free to merge #3418, since I will be back only next Tuesday. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [I] Suspect deadlock in InternalLoggerRegistry (intermittent) (logging-log4j2)

2025-01-31 Thread via GitHub
vy commented on issue #3399: URL: https://github.com/apache/logging-log4j2/issues/3399#issuecomment-2627843351 @tristantarrant, thanks so much for your understanding. I will merge #3418 (waiting for @ppkarwasz, since he is first original author) and mark this issue as closed. I created #34

[I] Expunge stale entries in `InternalLoggerRegistry` (logging-log4j2)

2025-01-31 Thread via GitHub
vy opened a new issue, #3430: URL: https://github.com/apache/logging-log4j2/issues/3430 `InternalLoggerRegistry` is essentially a `Map>>`. [As reported](/apache/logging-log4j2/issues/3399#issuecomment-2626946587) by @tristantarrant, stale entries are not expunged in its current form. That i

Re: [PR] 3399/create logger no lock (logging-log4j2)

2025-01-31 Thread via GitHub
vy commented on code in PR #3427: URL: https://github.com/apache/logging-log4j2/pull/3427#discussion_r1937623818 ## log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/WeakValuesHashMap.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] 3399/create logger no lock (logging-log4j2)

2025-01-31 Thread via GitHub
vy commented on code in PR #3427: URL: https://github.com/apache/logging-log4j2/pull/3427#discussion_r1937623818 ## log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/WeakValuesHashMap.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Minimize lock usage in `InternalLoggerRegistry` (logging-log4j2)

2025-01-31 Thread via GitHub
vy commented on code in PR #3418: URL: https://github.com/apache/logging-log4j2/pull/3418#discussion_r1937582885 ## log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/InternalLoggerRegistry.java: ## @@ -147,43 +147,51 @@ public Logger computeIfAbsent(

Re: [I] Suspect deadlock in InternalLoggerRegistry (intermittent) (logging-log4j2)

2025-01-31 Thread via GitHub
tristantarrant commented on issue #3399: URL: https://github.com/apache/logging-log4j2/issues/3399#issuecomment-2626946587 Not implementing reference reaping means that the inner map will contain useless entries. Also, if you notice, I only implemented the most basic parts of the map, so i

Re: [PR] Minimize lock usage in `InternalLoggerRegistry` (logging-log4j2)

2025-01-31 Thread via GitHub
tristantarrant commented on code in PR #3418: URL: https://github.com/apache/logging-log4j2/pull/3418#discussion_r1937002548 ## log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/InternalLoggerRegistry.java: ## @@ -147,43 +147,51 @@ public Logger computeIfAbsen

Re: [I] NullReferenceException in OpenFile: locking model not instantiated (logging-log4net)

2025-01-31 Thread via GitHub
FreeAndNil commented on issue #223: URL: https://github.com/apache/logging-log4net/issues/223#issuecomment-2626870252 @tmct thanks. There are some breaking changes in 3.x, but most of the consumers don't have to change anything. -- This is an automated message from the Apache Git Serv

Re: [PR] Bump com.google.code.gson:gson from 2.11.0 to 2.12.1 (logging-log4j2)

2025-01-31 Thread via GitHub
github-actions[bot] merged PR #3429: URL: https://github.com/apache/logging-log4j2/pull/3429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] Suspect deadlock in InternalLoggerRegistry (intermittent) (logging-log4j2)

2025-01-31 Thread via GitHub
vy commented on issue #3399: URL: https://github.com/apache/logging-log4j2/issues/3399#issuecomment-2626843259 @tristantarrant, checking #3427 you recently submitted... Implementing our own `Map>` is a big undertaking. It needs to be tested comprehensively. Historically, this approach has

Re: [PR] Minimize lock usage in `InternalLoggerRegistry` (logging-log4j2)

2025-01-31 Thread via GitHub
vy commented on code in PR #3418: URL: https://github.com/apache/logging-log4j2/pull/3418#discussion_r1936993075 ## log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/InternalLoggerRegistry.java: ## @@ -147,44 +147,43 @@ public Logger computeIfAbsent(

Re: [PR] Minimize lock usage in `InternalLoggerRegistry` (logging-log4j2)

2025-01-31 Thread via GitHub
vy commented on code in PR #3418: URL: https://github.com/apache/logging-log4j2/pull/3418#discussion_r1936992451 ## log4j-core/src/main/java/org/apache/logging/log4j/core/util/internal/InternalLoggerRegistry.java: ## @@ -147,44 +147,43 @@ public Logger computeIfAbsent(

Re: [I] NullReferenceException in OpenFile: locking model not instantiated (logging-log4net)

2025-01-31 Thread via GitHub
tmct commented on issue #223: URL: https://github.com/apache/logging-log4net/issues/223#issuecomment-2626824301 Hi @FreeAndNil - the 3.x upgrade isn't something we've attempted yet as this would probably be a more serious undertaking for upgrading our large pile of legacy software that all

Re: [PR] 3399/create logger no lock (logging-log4j2)

2025-01-31 Thread via GitHub
tristantarrant commented on PR #3427: URL: https://github.com/apache/logging-log4j2/pull/3427#issuecomment-2626795439 Some additional info: here are the timings for running Infinispan's core testsuite on my laptop: * Log4j `2.23.1`: 5m50s * Log4j `2.24.4-SNAPSHOT` including this PR

[PR] 3399/create logger no lock (logging-log4j2)

2025-01-31 Thread via GitHub
tristantarrant opened a new pull request, #3427: URL: https://github.com/apache/logging-log4j2/pull/3427 This PR includes and supersedes https://github.com/apache/logging-log4j2/pull/3418 It fixes the issue of dangling `WeakReference`s, which are not being replaced causing excessive writ

Re: [I] NullReferenceException in OpenFile: locking model not instantiated (logging-log4net)

2025-01-31 Thread via GitHub
tmct commented on issue #223: URL: https://github.com/apache/logging-log4net/issues/223#issuecomment-2626606795 Oh, and - no log file of that name is ever produced... Neither during nor after the run of my application. -- This is an automated message from the Apache Git Service. To respo

Re: [I] NullReferenceException in OpenFile: locking model not instantiated (logging-log4net)

2025-01-31 Thread via GitHub
FreeAndNil commented on issue #223: URL: https://github.com/apache/logging-log4net/issues/223#issuecomment-2626663649 Hi @tmct, does this problem occur in log4net 3.0.3? We won't fix bugs in 2.x because of the trouble associated with building for the legacy frameworks. -- This