tristantarrant commented on issue #3399: URL: https://github.com/apache/logging-log4j2/issues/3399#issuecomment-2626946587
Not implementing reference reaping means that the inner map will contain useless entries. Also, if you notice, I only implemented the most basic parts of the map, so it's not really a general purpose class. As I see you've sensibly removed some lambda invocations, this can be simplified even further. But, ultimately, your confidence in the solution is what matters the most, since you're the one having to maintain it :) At any rate, I've tested your latest changes with our testsuite and it works fine. Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org