vy commented on PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#issuecomment-2478170353
@pjfanning, making loggers garbage-collectible is not only a concern for
environments with constrained memory resources. This will also greatly benefit
users creating loggers programmat
jaykataria commented on issue #3198:
URL:
https://github.com/apache/logging-log4j2/issues/3198#issuecomment-2478169053
@ppkarwasz for testing here, we just do something of this sorts along with
[allocation-instrumenter](https://github.com/google/allocation-instrumenter)
and see the eff
vy commented on code in PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#discussion_r1843325702
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java:
##
@@ -43,7 +41,7 @@
@NullMarked
public class LoggerRegistry {
-private final Map
FreeAndNil merged PR #204:
URL: https://github.com/apache/logging-log4net/pull/204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
FreeAndNil closed issue #106: Enable automatic test runs on commit
URL: https://github.com/apache/logging-log4net/issues/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vy commented on issue #3207:
URL:
https://github.com/apache/logging-log4j2/issues/3207#issuecomment-2478147579
@amosshi, @jaykataria, would you mind providing a [JSON Template Layout
event
template](https://logging.apache.org/log4j/2.x/manual/json-template-layout.html#event-templates)
fluffynuts commented on PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2478135374
> Here is a build error
https://github.com/gdziadkiewicz/logging-log4net/actions/runs/11842227538/job/33000348058?pr=1
and here is a failing test
https://github.com/gdziadkiewic
jaykataria commented on issue #3207:
URL:
https://github.com/apache/logging-log4j2/issues/3207#issuecomment-2478118732
Seems interesting,
I would be curious to know, how this is implemented, or looked into. I am
getting familiar with the repoo, this looks like an interesting fea
amosshi opened a new issue, #3207:
URL: https://github.com/apache/logging-log4j2/issues/3207
**Warning!**
It is highly recommended to discuss feature requests in [the mailing
lists](https://logging.apache.org/log4j/2.x/support.html) first.
[A clear and concise description of the fe
xzel23 commented on issue #3196:
URL:
https://github.com/apache/logging-log4j2/issues/3196#issuecomment-2477975759
@ppkarwasz Thank you for your reply. So I think it's really not as bad as it
seemed at first.
> Unfortunately this is not what Maven's conflict resolution does, that's
gdziadkiewicz commented on PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2477571475
Here is a build error
https://github.com/gdziadkiewicz/logging-log4net/actions/runs/11842227538/job/33000348058?pr=1
and here is a failing test
https://github.com/gdziadkiewi
pjfanning commented on PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#issuecomment-2477525719
Would it be possible to optionally support not having weak references? I
understand why weak references are useful for edge cases like users running
with dangerously low heap for
garydgregory commented on PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#issuecomment-2477470671
A complex PR without tests? Isn't it possible to test this issue to avoid
regressions in the future?
--
This is an automated message from the Apache Git Service.
To respond
ppkarwasz commented on code in PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#discussion_r1842914829
##
log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java:
##
@@ -43,7 +41,7 @@
@NullMarked
public class LoggerRegistry {
-private fi
ppkarwasz commented on issue #3196:
URL:
https://github.com/apache/logging-log4j2/issues/3196#issuecomment-2477425353
@pjfanning,
> @ppkarwasz returning null from an API that users have long expected to not
support null returns (LogManager.getLogger) - that is a really big jolt.
pjfanning commented on issue #3196:
URL:
https://github.com/apache/logging-log4j2/issues/3196#issuecomment-2477366858
@ppkarwasz returning null from an API that users have long expected to not
support null returns (LogManager.getLogger) - that is a really big jolt. Could
you consider addin
FreeAndNil commented on PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2477360792
@gdziadkiewicz LGTM.
Can you make a test fail so that we can see that the pipeline fails?
--
This is an automated message from the Apache Git Service.
To respond to the messa
ppkarwasz commented on issue #3206:
URL:
https://github.com/apache/logging-log4j2/issues/3206#issuecomment-2477102904
I keep this open, so we can fix the NPE in the rare case a user really does
not want any appenders attached to the root logger.
--
This is an automated message from the A
ppkarwasz commented on issue #3196:
URL:
https://github.com/apache/logging-log4j2/issues/3196#issuecomment-2477095522
> Now that's really bad. How are library authors and application developers
supposed to cope with this? Do I understand correctly that if I have a
dependency on lib A that
fluffynuts commented on PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2476817265
> @fluffynuts are you OK with skipping zarro in the pipeline for now?
Sure, if you want to. Zarro does a lot of things and a lot of them are not
required for log4net. I kno
ninetteadhikari commented on PR #3061:
URL: https://github.com/apache/logging-log4j2/pull/3061#issuecomment-2476629502
thanks so much for the response! we'll see if we can make it work:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
FreeAndNil commented on PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2476593813
@fluffynuts are you OK with skipping zarro in the pipeline for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
fluffynuts commented on PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2476499427
> Hi all, I amended the csproj to use quackers by default, and it looks
great (I'm a new fan!). As for Zarro, at the moment, the builds are taking
longer with it than without it
ayush11-96 closed issue #3206: NPE when using `rootLogger` shorthand properties
notation
URL: https://github.com/apache/logging-log4j2/issues/3206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ayush11-96 commented on issue #3206:
URL:
https://github.com/apache/logging-log4j2/issues/3206#issuecomment-2476437399
thanks @ppkarwasz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
[
https://issues.apache.org/jira/browse/LOG4J2-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17897999#comment-17897999
]
Claudia Pastor Ramirez edited comment on LOG4J2-1721 at 11/14/24 2:03 PM:
[
https://issues.apache.org/jira/browse/LOG4J2-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898291#comment-17898291
]
Claudia Pastor Ramirez commented on LOG4J2-1721:
Hello,
I am adding som
[
https://issues.apache.org/jira/browse/LOG4J2-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claudia Pastor Ramirez updated LOG4J2-1721:
---
Attachment: image-2024-11-14-14-58-00-645.png
> Composite configuration usin
[
https://issues.apache.org/jira/browse/LOG4J2-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claudia Pastor Ramirez updated LOG4J2-1721:
---
Attachment: TwoConfigurationFiles.png
> Composite configuration using log4jC
[
https://issues.apache.org/jira/browse/LOG4J2-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claudia Pastor Ramirez updated LOG4J2-1721:
---
Attachment: OneConfigurationFile.png
> Composite configuration using log4jCo
vy commented on PR #3061:
URL: https://github.com/apache/logging-log4j2/pull/3061#issuecomment-2476304742
> we created `JndiExtension` to replace the `JndiRule` however the build
fails with this error:
@ninetteadhikari, this is a breaking change to `log4j-core-test`. Though we
are n
gdziadkiewicz commented on PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2476286882
Hi all, I amended the csproj to use quackers by default, and it looks great
(I'm a new fan!). As for Zarro, at the moment, the builds are taking longer
with it than without i
vy commented on PR #3061:
URL: https://github.com/apache/logging-log4j2/pull/3061#issuecomment-2476297459
@ninetteadhikari, that is an API compatibility check failure – see [Fixing
API compatibility check failures
](https://github.com/apache/logging-log4j2/blob/2.x/BUILDING.adoc#fixing-a
FreeAndNil commented on PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2476295567
I would like to skip zarro at this point and add it later in case we need it.
It was the best approach when it was added, because the dotnet tool could
not support our use case
ppkarwasz commented on issue #3206:
URL:
https://github.com/apache/logging-log4j2/issues/3206#issuecomment-2476164857
> Thanks @ppkarwasz Can I expect any ETA for the new version with fix?
This bug only affects **very** unlikely configuration scenario, when a user
does not want **any
ninetteadhikari commented on PR #3061:
URL: https://github.com/apache/logging-log4j2/pull/3061#issuecomment-2476125035
hi @vy we had a quick question, we are trying to write new extensions to
replace some of the old ones and getting some errors. For example we created
`JndiExtension` to rep
ayush11-96 commented on issue #3206:
URL:
https://github.com/apache/logging-log4j2/issues/3206#issuecomment-2476022055
Thanks @ppkarwasz
Can I expect any ETA for the new version with fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
ppkarwasz commented on issue #3206:
URL:
https://github.com/apache/logging-log4j2/issues/3206#issuecomment-2475896559
@ayush11-96,
There is problem in your configuration: you both use the shorthand
`rootLogger = , , ` notation that was introduced in Log4j
Core 2.17.2 IIRC (see [Prop
ayush11-96 commented on issue #3206:
URL:
https://github.com/apache/logging-log4j2/issues/3206#issuecomment-2475872466
@ppkarwasz could u please elaborate the issue if u got that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
ayush11-96 opened a new issue, #3206:
URL: https://github.com/apache/logging-log4j2/issues/3206
Currently we are using log4j2 version 2.17.0 with spring boot but while
updating log4j2 to 2.17.2 we are getting below error and which is because of
the appender of root is initialise to null
ayush11-96 commented on issue #3206:
URL:
https://github.com/apache/logging-log4j2/issues/3206#issuecomment-2475816149
@ppkarwasz
I tried till 2.23.1 version and this is still happening
**Stack Trace:**
`Caused by: java.lang.NullPointerException: Cannot invoke
"java.util.List.iter
ppkarwasz commented on issue #3206:
URL:
https://github.com/apache/logging-log4j2/issues/3206#issuecomment-2475805075
@ayush11-96,
Does the problem also occur with version `2.24.1`?
Can you provide the full stack trace of the exception?
--
This is an automated message from the A
jaykataria commented on issue #2769:
URL:
https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2475702663
Thanks @ppkarwasz , awesome, let me write the rule and contribute it to
OpenRewrite project! Would be fun!
--
This is an automated message from the Apache Git Servi
vy commented on PR #3199:
URL: https://github.com/apache/logging-log4j2/pull/3199#issuecomment-247572
@ppkarwasz, in 8963f705886f2b6397c03e8787ed35dd920b2736, we removed 110 LoC
and added 240 LoC, voiding the entire point of `computeIfAbsent()`. What is the
rationale for this decision?
44 matches
Mail list logo
