Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-04 Thread via GitHub
jaykataria commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2456265631 > Note: If you never wrote an annotation processor, its API has a steep learning curve, but the feature only requires a small part of this API: This is true, I h

Re: [PR] Make pkg_config support opt-in when building with MSVC [logging-log4cxx]

2024-11-04 Thread via GitHub
swebb2066 merged PR #424: URL: https://github.com/apache/logging-log4cxx/pull/424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [I] Appender may caused deadlock on AsyncLoggerDisruptor (logging-log4j2)

2024-11-04 Thread via GitHub
github-actions[bot] closed issue #2893: Appender may caused deadlock on AsyncLoggerDisruptor URL: https://github.com/apache/logging-log4j2/issues/2893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] JdbcAppender using DataSourceConnectionSource could not append log event in embedded WAS (logging-log4j2)

2024-11-04 Thread via GitHub
minseo300 commented on issue #3128: URL: https://github.com/apache/logging-log4j2/issues/3128#issuecomment-2455998539 @ppkarwasz Thanks for replying. In #2807, it seems you guys conclude there are more cons than pros to provide DataSourceConnectionSource in embedded WAS. And

[I] DefaultMergeStrategy - problem merging filters (logging-log4j2)

2024-11-04 Thread via GitHub
JWT007 opened a new issue, #3173: URL: https://github.com/apache/logging-log4j2/issues/3173 DefaultMergeStrategy (Log4j 2.24.1) In `DefaultMergeStrategy#updateFilterNode` I *think* there is a problem when merging two configurations with filters and the target does not *yet* contain a

[I] DefaultMergeStrategy - not accounting for AsyncWaitStrategyFactory when merging configurations (logging-log4j2)

2024-11-04 Thread via GitHub
JWT007 opened a new issue, #3172: URL: https://github.com/apache/logging-log4j2/issues/3172 DefaultMergeStragegy (Log4j 2.24.1) I *think* I may have encountered a potential error if using a CompositeConfiguration. In the `DefaultMergeStrategy#mergeConfigurations`, it does a dou

[jira] [Resolved] (LOG4J2-2525) Add max message size limit to JSON Layout

2024-11-04 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Karwasz resolved LOG4J2-2525. --- Resolution: Won't Fix > Add max message size limit to JSON Layout >

Re: [PR] Improve implementations of `LogEvent.toImmutable()` and `ReusableMessage.memento()` (logging-log4j2)

2024-11-04 Thread via GitHub
ppkarwasz commented on code in PR #3171: URL: https://github.com/apache/logging-log4j2/pull/3171#discussion_r1828229420 ## log4j-core/src/main/java/org/apache/logging/log4j/core/async/AsyncLogger.java: ## @@ -355,13 +353,6 @@ private void initTranslator( );

Re: [I] ExceptionInitailizationError in log4j JUL (logging-log4j2)

2024-11-04 Thread via GitHub
anuragagarwal561994 commented on issue #3169: URL: https://github.com/apache/logging-log4j2/issues/3169#issuecomment-2455457640 Yes, I think there is a reprodcuer attached in the linked issue -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[I] ConfigurationStrSubstitutor - incorrect class-levell Javadoc (logging-log4j2)

2024-11-04 Thread via GitHub
JWT007 opened a new issue, #3170: URL: https://github.com/apache/logging-log4j2/issues/3170 ConfigurationStrSubstitutor (Log4j 2.24.1) Small Javadoc inconsistency - probably copy/paste error? In the `ConfigurationStrSubstitutor` javadoc, the `RuntimeStrStubstitutor`is incorrect

Re: [I] ExceptionInitailizationError in log4j JUL (logging-log4j2)

2024-11-04 Thread via GitHub
ppkarwasz commented on issue #3169: URL: https://github.com/apache/logging-log4j2/issues/3169#issuecomment-2455451878 > Actually this is ocurring very rarely, like in 3 days it occurred on only 1 pod out of 100-200 so, I am not sure if I will be able to test it properly in production.

Re: [I] ExceptionInitailizationError in log4j JUL (logging-log4j2)

2024-11-04 Thread via GitHub
anuragagarwal561994 commented on issue #3169: URL: https://github.com/apache/logging-log4j2/issues/3169#issuecomment-2455441439 Actually this is ocurring very rarely, like in 3 days it occurred on only 1 pod out of 100-200 so, I am not sure if I will be able to test it properly in producti

Re: [I] ExceptionInitailizationError in log4j JUL (logging-log4j2)

2024-11-04 Thread via GitHub
ppkarwasz commented on issue #3169: URL: https://github.com/apache/logging-log4j2/issues/3169#issuecomment-2455388368 @anuragagarwal561994, Thank you for the report. The `LoggerRegistry` implementation was changed in `2.25.0-SNAPSHOT`. Can you check if that fixes your issue?

Re: [I] Broken logger initialization in 2.24.1 (logging-log4j2)

2024-11-04 Thread via GitHub
ppkarwasz commented on issue #3143: URL: https://github.com/apache/logging-log4j2/issues/3143#issuecomment-2455387132 @kelunik, Thank you for the report. The `LoggerRegistry` implementation was changed in `2.25.0-SNAPSHOT`. Can you check if that fixes your issue? Our snapsh

Re: [I] ExceptionInitailizationError in log4j JUL (logging-log4j2)

2024-11-04 Thread via GitHub
anuragagarwal561994 commented on issue #3169: URL: https://github.com/apache/logging-log4j2/issues/3169#issuecomment-2454931464 Seems related to https://github.com/apache/logging-log4j2/issues/3143 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] AbstractConfiguration - Potential NPE on AsyncLoggerConfigDisruptor (logging-log4j2)

2024-11-04 Thread via GitHub
JWT007 commented on issue #3156: URL: https://github.com/apache/logging-log4j2/issues/3156#issuecomment-2454856232 NOTE: additionally I *think* the constructor will throw an exception if the LMX Jar is not on the classpath (at the very latest in start/stop) but I am not sure how exactly it

Re: [PR] refactor(1.2-api): migrate to junit5 (logging-log4j2)

2024-11-04 Thread via GitHub
hulkoba commented on PR #3067: URL: https://github.com/apache/logging-log4j2/pull/3067#issuecomment-2454685005 @ppkarwasz This is ready for review now :wave: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Turn on the CI build for PRs (logging-log4net)

2024-11-04 Thread via GitHub
FreeAndNil commented on PR #204: URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2454366773 > Here is the log from the `dotnet test` run https://github.com/gdziadkiewicz/logging-log4net/actions/runs/11660840781/job/32463975074 @gdziadkiewicz dotnet tests brings th

Re: [I] ExceptionInitailizationError in log4j JUL (logging-log4j2)

2024-11-04 Thread via GitHub
anuragagarwal561994 commented on issue #3169: URL: https://github.com/apache/logging-log4j2/issues/3169#issuecomment-2454634626 ``` 04 Nov 2024 04:00:25.467 ERROR [http-nio-7017-exec-275] io.grpc.internal.ManagedChannelImpl {span_id=22f88ea4d82a0591, trace_flags=00, trace_id=5947afec05d

Re: [I] StringMatchFilter would return NPE if configured programmatically with 'null' text. (logging-log4j2)

2024-11-04 Thread via GitHub
ppkarwasz commented on issue #3153: URL: https://github.com/apache/logging-log4j2/issues/3153#issuecomment-2454539430 It's optional: you can create a PR and we pretty much appreciate it, but we can also push it directly to `main`. In this case I think that the second option is faster (I

Re: [I] ExceptionInitailizationError in log4j JUL (logging-log4j2)

2024-11-04 Thread via GitHub
anuragagarwal561994 commented on issue #3169: URL: https://github.com/apache/logging-log4j2/issues/3169#issuecomment-2454502466 Is there a chance that the weakref in case of AsyncLogger is getting garbage collected? -- This is an automated message from the Apache Git Service. To respond

[I] ExceptionInitailizationError in log4j JUL (logging-log4j2)

2024-11-04 Thread via GitHub
anuragagarwal561994 opened a new issue, #3169: URL: https://github.com/apache/logging-log4j2/issues/3169 ## Description Getting ExceptionIntializationError in log4j JUL ## Configuration **Version:** 2.24.1 **Operating system:** Unix **JDK:** 21 ## Log

Re: [PR] Bump org.apache.maven.surefire:surefire-junit47 from 3.5.1 to 3.5.2 (logging-log4j2)

2024-11-04 Thread via GitHub
github-actions[bot] merged PR #3167: URL: https://github.com/apache/logging-log4j2/pull/3167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump net.javacrumbs.json-unit:json-unit from 3.4.1 to 3.5.0 (logging-log4j2)

2024-11-04 Thread via GitHub
github-actions[bot] merged PR #3168: URL: https://github.com/apache/logging-log4j2/pull/3168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.15.7 to 1.15.10 (logging-log4j2)

2024-11-04 Thread via GitHub
github-actions[bot] merged PR #3166: URL: https://github.com/apache/logging-log4j2/pull/3166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] StringMatchFilter would return NPE if configured programmatically with 'null' text. (logging-log4j2)

2024-11-04 Thread via GitHub
JWT007 commented on issue #3153: URL: https://github.com/apache/logging-log4j2/issues/3153#issuecomment-2454428017 @ppkarwasz - OK is that something I would need to do (i.e. PR against master) or something you do internally. -- This is an automated message from the Apache Git Service. T

Re: [PR] Bump org.hsqldb:hsqldb from 2.7.3 to 2.7.4 (logging-log4j2)

2024-11-04 Thread via GitHub
github-actions[bot] merged PR #3163: URL: https://github.com/apache/logging-log4j2/pull/3163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump org.apache.maven.surefire:surefire-junit47 from 3.5.1 to 3.5.2 (logging-log4j2)

2024-11-04 Thread via GitHub
github-actions[bot] merged PR #3162: URL: https://github.com/apache/logging-log4j2/pull/3162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [I] Feature: Implement ArchivingRollingFileAppender - an appender that archives rolled files exceeding maxSizeRollBackups instead of deleting them (logging-log4net)

2024-11-04 Thread via GitHub
FreeAndNil commented on issue #207: URL: https://github.com/apache/logging-log4net/issues/207#issuecomment-2454378968 Thanks. We will keep it in mind in case other users want the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Feature: Implement ArchivingRollingFileAppender - an appender that archives rolled files exceeding maxSizeRollBackups instead of deleting them (logging-log4net)

2024-11-04 Thread via GitHub
FreeAndNil closed issue #207: Feature: Implement ArchivingRollingFileAppender - an appender that archives rolled files exceeding maxSizeRollBackups instead of deleting them URL: https://github.com/apache/logging-log4net/issues/207 -- This is an automated message from the Apache Git Service.

Re: [PR] Turn on the CI build for PRs (logging-log4net)

2024-11-04 Thread via GitHub
FreeAndNil commented on code in PR #204: URL: https://github.com/apache/logging-log4net/pull/204#discussion_r1827527797 ## .github/workflows/build-dotnet-solo.yaml: ## @@ -0,0 +1,59 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor licens

Re: [PR] Turn on the CI build for PRs (logging-log4net)

2024-11-04 Thread via GitHub
FreeAndNil commented on PR #204: URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2454343819 @fluffynuts we already use Quackers test logger in log4net.Tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[I] Feature: Implement ArchivingRollingFileAppender - an appender that archives rolled files exceeding maxSizeRollBackups instead of deleting them (logging-log4net)

2024-11-04 Thread via GitHub
FerdinandStapenhorst opened a new issue, #207: URL: https://github.com/apache/logging-log4net/issues/207 I implemented a ArchivingRollingFileAppender class that creates zip archives for all those files that would be deleted once maxSizeRollBackups is reached instead of deleting them.

Re: [PR] Improve validation for AsyncWaitStrategyFactoryConfig for null/empty 'factoryClassName'. #3159 (logging-log4j2)

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #3160: URL: https://github.com/apache/logging-log4j2/pull/3160#issuecomment-2454291848 Job Requested goals Build Tool Version Build Outcome Build ScanĀ® build-

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-04 Thread via GitHub
ppkarwasz commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2454234309 To test the annotation processor, we have some examples in `logging-log4j-tools` like [`DescriptorGeneratorTest`](https://github.com/apache/logging-log4j-tools/blob/main/lo

Re: [PR] Turn on the CI build for PRs (logging-log4net)

2024-11-04 Thread via GitHub
fluffynuts commented on code in PR #204: URL: https://github.com/apache/logging-log4net/pull/204#discussion_r1827436633 ## .github/workflows/build.yaml: ## @@ -47,11 +55,20 @@ jobs: with: node-version: 20 - - name: Build and test -env: -

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-04 Thread via GitHub
ppkarwasz commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2454228124 Hi @jaykataria, > not sure if I could find any other way of finding setters looking at the reflection API The usage of the Reflection API suggests to me th

Re: [PR] Turn on the CI build for PRs (logging-log4net)

2024-11-04 Thread via GitHub
fluffynuts commented on PR #204: URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2454221036 > > @gdziadkiewicz can you test how just using "dotnet test" as a single step would look like? @fluffynuts do you have an idea why the windows output is much longer? (the macos a

Re: [I] StringMatchFilter would return NPE if configured programmatically with 'null' text. (logging-log4j2)

2024-11-04 Thread via GitHub
ppkarwasz commented on issue #3153: URL: https://github.com/apache/logging-log4j2/issues/3153#issuecomment-2454138661 > @ppkarwasz - one more question :) how do relevant fixes find their way into 3.x? That is an excellent question. We try to port them immediately, but there is usual

Re: [PR] Turn on the CI build for PRs (logging-log4net)

2024-11-04 Thread via GitHub
gdziadkiewicz commented on PR #204: URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2454132460 Here is the log from the `dotnet test` run https://github.com/gdziadkiewicz/logging-log4net/actions/runs/11660840781/job/32463975074 -- This is an automated message from the

[I] Synchronization with `main` backlog (logging-log4j2)

2024-11-04 Thread via GitHub
ppkarwasz opened a new issue, #3161: URL: https://github.com/apache/logging-log4j2/issues/3161 This meta-issue lists the PRs or modifications that didn't make it to `main` yet. Feel free to modify it after each merged PR that you don't have time or can not port immediately: - [ ] #2

Re: [PR] Turn on the CI build for PRs (logging-log4net)

2024-11-04 Thread via GitHub
gdziadkiewicz commented on PR #204: URL: https://github.com/apache/logging-log4net/pull/204#issuecomment-2454101125 @FreeAndNil Will do > @gdziadkiewicz can you test how just using "dotnet test" as a single step would look like? @fluffynuts do you have an idea why the windows output i

Re: [PR] Turn on the CI build for PRs (logging-log4net)

2024-11-04 Thread via GitHub
gdziadkiewicz commented on code in PR #204: URL: https://github.com/apache/logging-log4net/pull/204#discussion_r1827368065 ## .github/workflows/build.yaml: ## @@ -19,6 +19,10 @@ name: build on: workflow_dispatch: + push: +branches: + - main Review Comment: Co

Re: [I] Replace field injection with setter injection in `3.x` (logging-log4j2)

2024-11-04 Thread via GitHub
jaykataria commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2454079028 Hi @ppkarwasz , re: to modify the annotation processor in 2.x to fail if a plugin builder attribute does not have a public setter (or at least a wither).