fluffynuts commented on code in PR #204:
URL: https://github.com/apache/logging-log4net/pull/204#discussion_r1827436633
##########
.github/workflows/build.yaml:
##########
@@ -47,11 +55,20 @@ jobs:
with:
node-version: 20
- - name: Build and test
- env:
- DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
- DOTNET_CLIE_TELEMETRY_OPTOUT: 1
+ - name: Setup non-windows build
+ if: matrix.os != 'windows-latest'
+ run: |
+ echo "DOTNET_CORE=1" >> $GITHUB_ENV
+
+ - name: Install build dependencies
run: |
npm update -g npm --no-progress
npm install --no-progress
- npm test
+
+ - name: Build
Review Comment:
minor: build step is not required - `npm test` will build as a pre-requisite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
