FreeAndNil merged PR #206:
URL: https://github.com/apache/logging-log4net/pull/206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
FreeAndNil closed issue #205: Ability to compress rolled files
URL: https://github.com/apache/logging-log4net/issues/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
JWT007 commented on issue #3153:
URL:
https://github.com/apache/logging-log4j2/issues/3153#issuecomment-2453953343
@ppkarwasz - one more question :) how do relevant fixes find their way into
3.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
FerdinandStapenhorst commented on issue #205:
URL:
https://github.com/apache/logging-log4net/issues/205#issuecomment-2453934865
Thank you so much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
JWT007 opened a new pull request, #3160:
URL: https://github.com/apache/logging-log4j2/pull/3160
This should fix a potential NPE in AsyncWaitStrategyFactoryConfig if the
builder 'class' field is not set or set to null/empty string.
https://github.com/apache/logging-log4j2/issues/3159
JWT007 opened a new issue, #3159:
URL: https://github.com/apache/logging-log4j2/issues/3159
AsyncWaitStrategyFactoryConfig (Log4j 2.24.1)
This @Plugin doesn't behave like most others where if the configuration is
invalid, it will return a `null` from the Builder.
The `@PluginBu
github-actions[bot] merged PR #219:
URL: https://github.com/apache/logging-log4j-samples/pull/219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifi
swebb2066 opened a new pull request, #424:
URL: https://github.com/apache/logging-log4cxx/pull/424
Installing pkg_config files [breaks vcpkg
](https://github.com/microsoft/vcpkg/pull/41927)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
swebb2066 commented on issue #423:
URL:
https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2453623684
I have already [created a PR to update to
1.3.0](https://github.com/microsoft/vcpkg/pull/41927), but installing
pkg_config files breaks vcpkg.
I think we will need to
ppkarwasz commented on code in PR #3065:
URL: https://github.com/apache/logging-log4j2/pull/3065#discussion_r1827069822
##
log4j-1.2-api/pom.xml:
##
@@ -43,11 +43,12 @@
com.sun.jdmk.comm;resolution:=optional,
javax.jms;version="[1.1,3)";resolution:=optional
ppkarwasz merged PR #3065:
URL: https://github.com/apache/logging-log4j2/pull/3065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
ppkarwasz merged PR #3133:
URL: https://github.com/apache/logging-log4j2/pull/3133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
ppkarwasz merged PR #3158:
URL: https://github.com/apache/logging-log4j2/pull/3158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
FreeAndNil opened a new pull request, #206:
URL: https://github.com/apache/logging-log4net/pull/206
fixes #205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
ppkarwasz commented on PR #3158:
URL: https://github.com/apache/logging-log4j2/pull/3158#issuecomment-2453547189
> Hi @ppkarwasz I looked to see if I could extend an existing test for
StringMatchFilter but there were no existing unit-tests.
Yes, it happens. :wink: Can you create a `St
JWT007 commented on PR #3158:
URL: https://github.com/apache/logging-log4j2/pull/3158#issuecomment-2453542127
Hi @ppkarwasz I looked to see if I could extend an existing test for
StringMatchFilter but there were no existing unit-tests.
--
This is an automated message from the Apache Git S
ppkarwasz commented on PR #3158:
URL: https://github.com/apache/logging-log4j2/pull/3158#issuecomment-2453533053
@JWT007,
Thank you for your contribution. Can you add some unit tests to the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
github-actions[bot] commented on PR #3158:
URL: https://github.com/apache/logging-log4j2/pull/3158#issuecomment-2453476802
Job
Requested goals
Build Tool Version
Build Outcome
Build Scan®
build-
JWT007 commented on issue #3153:
URL:
https://github.com/apache/logging-log4j2/issues/3153#issuecomment-2453459020
@ppkarwasz - I take it back ... I was curious if I could manage the PR since
I don't do Github much.
I created a PR but first time so please double-check that everything
JWT007 opened a new pull request, #3158:
URL: https://github.com/apache/logging-log4j2/pull/3158
This should fix a potential NPE in StringMatchFilter if the 'text' field is
not set or set to null/empty string. #3153
* Added '@Required' to @PluginAttribute
* removed default value of ""
FerdinandStapenhorst opened a new issue, #205:
URL: https://github.com/apache/logging-log4net/issues/205
## This is a Feature Request
### Compressing Rolled files in RollingFileAppender
I would like to be able to compress rolled files once thy are created. I
don't see any way to ge
JoeyJoeJoeJrShabadoo commented on issue #423:
URL:
https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2453435020
Sounds reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
JWT007 opened a new issue, #3157:
URL: https://github.com/apache/logging-log4j2/issues/3157
LoggerConfig (Log4j 2.24.1)
I am not sure if this would be considered a bug or works-as-designed.
I am currently implementing a custom `Configuration` which does *not*
inherit from `Abst
rm5248 commented on issue #423:
URL:
https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2453429545
should we also update the vcpkg version to 1.3.0? Although perhaps that
should be a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to t
JoeyJoeJoeJrShabadoo commented on issue #423:
URL:
https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2453428302
Wow, that was pretty quick, thank you very much, Stephen. As a additional
benefit I can see now what I was missing when trying myself 👍
I'll wait till the PR i
JWT007 opened a new issue, #3156:
URL: https://github.com/apache/logging-log4j2/issues/3156
AbstractConfiguration (Log4j 2.24.1)
In `AbstractConfiguration` the field `asyncLoggerConfigDisruptor`is lazily
initialized.
```
private AsyncLoggerConfigDisruptor asyncLoggerConfigDi
JWT007 commented on issue #3153:
URL:
https://github.com/apache/logging-log4j2/issues/3153#issuecomment-2453394061
Hi @ppkarwasz thanks for your feedback.
Unfortunately I am a bit too buried in my day job to be actively
contributing - but since I am pouring over the Log4j code, I a
ppkarwasz commented on issue #3127:
URL:
https://github.com/apache/logging-log4j2/issues/3127#issuecomment-2453329404
@minseo300,
Thank you for the in-depth analysis. You are right, the call to
`StringReader.close()` on line 1043 seems problematic and I don't believe it is
required
ppkarwasz commented on issue #3153:
URL:
https://github.com/apache/logging-log4j2/issues/3153#issuecomment-2453323116
@JWT007,
Thank you for catching this problem. I believe that the missing validation
affects both types of configuration.
When configuring through a configurati
29 matches
Mail list logo
