ppkarwasz commented on code in PR #3065:
URL: https://github.com/apache/logging-log4j2/pull/3065#discussion_r1827069822
##########
log4j-1.2-api/pom.xml:
##########
@@ -43,11 +43,12 @@
com.sun.jdmk.comm;resolution:=optional,
<!-- JMS is optional -->
javax.jms;version="[1.1,3)";resolution:=optional,
- <!-- Log4j Core is optional -->
- org.apache.logging.log4j.core.*;resolution:=optional
</bnd-extra-package-options>
+ <bnd-extra-module-options>
Review Comment:
No, setting the `javax.jms` module to `resolution:=optional` is enough for
BND to mark the JPMS module as optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
