Re: [I] log4j-api 2.20.0 causing : java.lang.NoClassDefFoundError: Could not initialize class org.apache.logging.log4j.util.PropertiesUtil (logging-log4j2)

2024-03-28 Thread via GitHub
jolly28 commented on issue #2414: URL: https://github.com/apache/logging-log4j2/issues/2414#issuecomment-2026715262 sure, @vy I am attaching the error stack trace I am getting while using the version 2.23.1. `SEVERE [main] org.apache.catalina.core.StandardContext.filterStart Excepti

Re: [I] log4j-api 2.20.0 causing : java.lang.NoClassDefFoundError: Could not initialize class org.apache.logging.log4j.util.PropertiesUtil (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on issue #2414: URL: https://github.com/apache/logging-log4j2/issues/2414#issuecomment-2026143609 @jolly28, in [the SO question @ppkarwasz referenced](https://stackoverflow.com/q/78223383/11748454), you(?) state that issue persists with `2.23.1` too. If so, could you share the

Re: [PR] Deprecate `o.a.l.l.c.a.r.a.Duration` class for removal (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2425: URL: https://github.com/apache/logging-log4j2/pull/2425#discussion_r1543730541 ## log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/convert/TypeConverters.java: ## @@ -224,11 +224,26 @@ public Double convert(final String s) {

Re: [I] log4j-api 2.20.0 causing : java.lang.NoClassDefFoundError: Could not initialize class org.apache.logging.log4j.util.PropertiesUtil (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz commented on issue #2414: URL: https://github.com/apache/logging-log4j2/issues/2414#issuecomment-2026137807 For context, this isssue is related to [this SO question](https://stackoverflow.com/q/78223383/11748454). -- This is an automated message from the Apache Git Service. To

Re: [PR] Remove `o.a.l.l.c.a.r.a.Duration` class (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2426: URL: https://github.com/apache/logging-log4j2/pull/2426#discussion_r1543719114 ## log4j-core/src/main/java/org/apache/logging/log4j/core/appender/rolling/action/IfLastModified.java: ## @@ -97,17 +91,24 @@ public String toString() { retu

Re: [PR] Add logging to `PropertiesUtil` and fix `Duration` parser (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2424: URL: https://github.com/apache/logging-log4j2/pull/2424#discussion_r1543694204 ## log4j-api/src/main/java/org/apache/logging/log4j/util/SystemPropertiesPropertySource.java: ## @@ -32,19 +34,32 @@ @ServiceProvider(value = PropertySource.class, r

Re: [PR] Add logging to `PropertiesUtil` and fix `Duration` parser (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2424: URL: https://github.com/apache/logging-log4j2/pull/2424#discussion_r1543618080 ## log4j-api/src/main/java/org/apache/logging/log4j/util/PropertiesUtil.java: ## @@ -649,45 +674,57 @@ public static Map partitionOnCommonPrefixes( * @return t

Re: [I] log4j-api 2.20.0 causing : java.lang.NoClassDefFoundError: Could not initialize class org.apache.logging.log4j.util.PropertiesUtil (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on issue #2414: URL: https://github.com/apache/logging-log4j2/issues/2414#issuecomment-2026031128 @jolly28, could you try with the latest version of `log4j-api` (i.e., `2.23.1`), please? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Remove obsolete properties, methods, and classes for 3.0 (logging-log4net)

2024-03-28 Thread via GitHub
erikmav commented on PR #138: URL: https://github.com/apache/logging-log4net/pull/138#issuecomment-2025976880 For #125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] Remove obsolete properties, methods, and classes for 3.0 (logging-log4net)

2024-03-28 Thread via GitHub
erikmav opened a new pull request, #138: URL: https://github.com/apache/logging-log4net/pull/138 Add BinaryFormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (#124). Commented out obsolete tag for FixFlags.Mdc

Re: [PR] #124 LoggingEvent.Level not nullable (logging-log4net)

2024-03-28 Thread via GitHub
erikmav commented on PR #137: URL: https://github.com/apache/logging-log4net/pull/137#issuecomment-2025957339 In the 2.x codebase a null level was handled as an allowed option, and some formatters use default behaviors on a null value (search for `level is null` across the codebase). IOW th

[PR] Merge `feature/log4j-sdk` into `main` (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz opened a new pull request, #2428: URL: https://github.com/apache/logging-log4j2/pull/2428 This PR merges into the `main` development branch the enhancements from the following PRs: - [x] #2291 - [x] #2329 - [x] #2366 - [x] #2307 - [x] #2396 - [x] #2400 - [x

[PR] #124 LoggingEvent.Level not nullable (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil opened a new pull request, #137: URL: https://github.com/apache/logging-log4net/pull/137 #124 LoggingEvent.Level not nullable @erikmav what do you think about this approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Nullable: Eliminate nullable in one place, and clarify the meaning of null levels in doc comments (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil merged PR #136: URL: https://github.com/apache/logging-log4net/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Nullable and modernization part 6 (logging-log4net)

2024-03-28 Thread via GitHub
erikmav commented on PR #132: URL: https://github.com/apache/logging-log4net/pull/132#issuecomment-2025667615 @FreeAndNil I just tried setting LoggingEvent.Level to non-nullable and set to Level.All. Problem is that null is converted into different policies by different appenders (Debug, In

Re: [PR] Nullable and modernization part 6 (logging-log4net)

2024-03-28 Thread via GitHub
erikmav commented on PR #132: URL: https://github.com/apache/logging-log4net/pull/132#issuecomment-2025622481 @FreeAndNil the ugliest adaptations I had to make with the new binary: * `Level?` on LoggingEvent and its internal data structure required adding a bunch of null checks, especial

[PR] Migrate `2.x` website to Antora (logging-log4j2)

2024-03-28 Thread via GitHub
vy opened a new pull request, #2427: URL: https://github.com/apache/logging-log4j2/pull/2427 This PR migrates the `asciidoctor-maven-plugin`-based current website in `2.x` to Antora *with several other improvements*. ### Rationale Developers love AsciiDoc, but `asciidoctor-mave

[PR] Remove `o.a.l.l.c.a.r.a.Duration` class (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz opened a new pull request, #2426: URL: https://github.com/apache/logging-log4j2/pull/2426 This is the 3.x counterpart of the `o.a.l.l.c.a.r.a.Duration` deprecation in #2425. It also makes the `Clock` argument for the `IfLastModified` plugin compulsory. The argument is usual

Re: [PR] Remove Log4j API 3.x (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz commented on PR #2411: URL: https://github.com/apache/logging-log4j2/pull/2411#issuecomment-2025494481 My Github stats will never recover from the -50k lines hit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Scoped context (logging-log4j2)

2024-03-28 Thread via GitHub
rgoers commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2025463001 @ppkarwasz > The fact that there is only one logger per logger name is not set in stone (unlike in Logback). [LoggerRegistry](https://logging.apache.org/log4j/2.x/javadoc/lo

Re: [PR] Rebase Log4j Core 3.x on Log4j API 2.x (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz merged PR #2410: URL: https://github.com/apache/logging-log4j2/pull/2410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Remove Log4j API 3.x (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz merged PR #2411: URL: https://github.com/apache/logging-log4j2/pull/2411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil closed issue #134: Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() URL: https://github.com/apache/logging-log4net/issues/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil commented on issue #134: URL: https://github.com/apache/logging-log4net/issues/134#issuecomment-2025400384 @NicoCV I understand. The official release for this issue will be 3.0.0 expected in 2 months. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() (logging-log4net)

2024-03-28 Thread via GitHub
NicoCV commented on issue #134: URL: https://github.com/apache/logging-log4net/issues/134#issuecomment-2025367178 @FreeAndNil : First of all thanks for the really quick reaction and action! Unfortunatly it won't be possible for us to really test this. We've only seen this on production,

Re: [PR] Fix IndexOutOfRangeException in LogLog.LogReceived (#134) (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil merged PR #135: URL: https://github.com/apache/logging-log4net/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [I] Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil commented on issue #134: URL: https://github.com/apache/logging-log4net/issues/134#issuecomment-2025270759 @NicoCV can you test the code change from #135? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] Deprecate `o.a.l.l.c.a.r.a.Duration` class for removal (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz opened a new pull request, #2425: URL: https://github.com/apache/logging-log4j2/pull/2425 We deprecate the [`o.a.l.l.c.a.r.a.Duration`](https://logging.apache.org/log4j/2.x/javadoc/log4j-core/org/apache/logging/log4j/core/appender/rolling/action/Duration) and replace it with `java

[PR] Fix IndexOutOfRangeException in LogLog.LogReceived (#134) (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil opened a new pull request, #135: URL: https://github.com/apache/logging-log4net/pull/135 fixes #134 IndexOutOfRangeException in LogLog.LogReceived -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[I] `log4j-docgen` cannot convert method references with multiple arguments in Javadoc to AsciiDoc [logging-log4j-tools]

2024-03-28 Thread via GitHub
vy opened a new issue, #110: URL: https://github.com/apache/logging-log4j-tools/issues/110 The following Javadoc (copied from `org.apache.logging.log4j.core.filter.AbstractFilter`) gets converted to an invalid AsciiDoc due to whitespace in between method arguments: ``` Garbage-free no

Re: [PR] Scoped context (logging-log4j2)

2024-03-28 Thread via GitHub
rocketraman commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2025107929 @rgoers > If you have other requirements for how the data should be formatted I am sure JsonTemplateLayout could be enhanced to support it, if it can't do it already.

Re: [PR] Bump spring-boot.version from 3.2.3 to 3.2.4 (logging-log4j2)

2024-03-28 Thread via GitHub
github-actions[bot] merged PR #2398: URL: https://github.com/apache/logging-log4j2/pull/2398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Correct version number in release notes (logging-log4net)

2024-03-28 Thread via GitHub
DanAtkinson commented on PR #133: URL: https://github.com/apache/logging-log4net/pull/133#issuecomment-2025031228 Thanks for the quick turnaround! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.5-11 to 1.5.6-1 (logging-log4j2)

2024-03-28 Thread via GitHub
github-actions[bot] merged PR #2423: URL: https://github.com/apache/logging-log4j2/pull/2423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Correct version number in release notes (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil commented on PR #133: URL: https://github.com/apache/logging-log4net/pull/133#issuecomment-2025006634 @DanAtkinson the new version is live: https://logging.apache.org/log4net/release/release-notes.html -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Bump org.springframework.cloud:spring-cloud-context from 4.1.1 to 4.1.2 (logging-log4j2)

2024-03-28 Thread via GitHub
github-actions[bot] merged PR #2421: URL: https://github.com/apache/logging-log4j2/pull/2421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.5-11 to 1.5.6-1 (logging-log4j2)

2024-03-28 Thread via GitHub
github-actions[bot] merged PR #2422: URL: https://github.com/apache/logging-log4j2/pull/2422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

Re: [PR] Correct version number in release notes (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil merged PR #133: URL: https://github.com/apache/logging-log4net/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Nullable and modernization part 6 (logging-log4net)

2024-03-28 Thread via GitHub
FreeAndNil merged PR #132: URL: https://github.com/apache/logging-log4net/pull/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[I] Possible System.IndexOutOfRangeException in AppenderSkeleton.Finalize() (logging-log4net)

2024-03-28 Thread via GitHub
NicoCV opened a new issue, #134: URL: https://github.com/apache/logging-log4net/issues/134 We're using Log4Net (2.0.15.0-.NET 4.5) in WCF services hosted in IIS. On our production environments from time to times we're experiencing crash of the application pool with following error:

[PR] Correct version number in release notes (logging-log4net)

2024-03-28 Thread via GitHub
DanAtkinson opened a new pull request, #133: URL: https://github.com/apache/logging-log4net/pull/133 Hello I noticed an issue on the Release Notes page which had the wrong version. I have corrected this. Apologies if it's in the wrong place - I could find no other reference to

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz merged PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Move `Recycler` to `log4j-kit` (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz merged PR #2400: URL: https://github.com/apache/logging-log4j2/pull/2400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1542583829 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to t

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1542572496 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licens

Re: [PR] Replace `PropertiesUtil` with `PropertyEnvironment` (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on code in PR #2396: URL: https://github.com/apache/logging-log4j2/pull/2396#discussion_r1542564612 ## log4j-layout-template-json/src/main/java/org/apache/logging/log4j/layout/template/json/JsonTemplateLayoutProperties.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to t

Re: [I] Issue with Duration Parsing (logging-log4j2)

2024-03-28 Thread via GitHub
vy commented on issue #1963: URL: https://github.com/apache/logging-log4j2/issues/1963#issuecomment-2024670784 @ppkarwasz, if there are no other system properties that need a `TypeConverter`, but the Kubernetes module, which is planned to be removed, remove this `TypeConverter` along with

Re: [PR] Scoped context (logging-log4j2)

2024-03-28 Thread via GitHub
ppkarwasz commented on PR #2419: URL: https://github.com/apache/logging-log4j2/pull/2419#issuecomment-2024651863 @rgoers, > @rocketraman I did look into that and what you are asking for just can't be implemented in a reasonable way without significant mods to the API and will likely