craterone commented on pull request #72:
URL: https://github.com/apache/logging-log4cxx/pull/72#issuecomment-922405875
> Looks good to me, but I agree with Thorsten that at least some
documentation is needed(currently, the documentation for the conversion
characters is in the documentation
rm5248 commented on pull request #72:
URL: https://github.com/apache/logging-log4cxx/pull/72#issuecomment-922340153
Looks good to me, but I agree with Thorsten that at least some documentation
is needed(currently, the documentation for the conversion characters is in the
documentation for
ams-tschoening commented on pull request #72:
URL: https://github.com/apache/logging-log4cxx/pull/72#issuecomment-922244507
It would be great to not only put a bunch of code here, but as well describe
your use-case, the chosen implementation, limitations, how things are used in
the end etc
