[GitHub] [logging-log4j2] carterkozak commented on pull request #485: LOG4J2-3068 - JCToolsBlockingQueueFactory can use MpscBlockingConsumerArrayQueue

2021-04-09 Thread GitBox
carterkozak commented on pull request #485: URL: https://github.com/apache/logging-log4j2/pull/485#issuecomment-816747383 > It's a shame we're exposing a blocking q API there, or we could've used JCTools/JCTools#340 to batch consume from the queue. We could support a lighter weight A

[GitHub] [logging-log4j2] carterkozak commented on pull request #485: LOG4J2-3068 - JCToolsBlockingQueueFactory can use MpscBlockingConsumerArrayQueue

2021-04-09 Thread GitBox
carterkozak commented on pull request #485: URL: https://github.com/apache/logging-log4j2/pull/485#issuecomment-816743154 Thanks for the contribution @franz1981, your PRs are appreciated as always! I normally handle the `changes.xml` pieces when I merge PRs since it can be non-obviou

[jira] [Updated] (LOG4J2-3068) JCToolsBlockingQueueFactory can use MpscBlockingConsumerArrayQueue

2021-04-09 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici updated LOG4J2-3068: -- Fix Version/s: 2.15.0 > JCToolsBlockingQueueFactory can use MpscBlockingConsumerArrayQueue > -

[GitHub] [logging-log4j2] vy commented on pull request #485: LOG4J2-3068 - JCToolsBlockingQueueFactory can use MpscBlockingConsumerArrayQueue

2021-04-09 Thread GitBox
vy commented on pull request #485: URL: https://github.com/apache/logging-log4j2/pull/485#issuecomment-816735380 @franz1981, thanks so much for the contribution. Would you mind updating `changes.xml` too, please? -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (LOG4J2-3056) NameUtil.md5(String) could leak plaintext credentials

2021-04-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317917#comment-17317917 ] ASF subversion and git services commented on LOG4J2-3056: - Commi

[jira] [Closed] (LOG4J2-3056) NameUtil.md5(String) could leak plaintext credentials

2021-04-09 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici closed LOG4J2-3056. - > NameUtil.md5(String) could leak plaintext credentials > --

[jira] [Resolved] (LOG4J2-3056) NameUtil.md5(String) could leak plaintext credentials

2021-04-09 Thread Volkan Yazici (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Volkan Yazici resolved LOG4J2-3056. --- Resolution: Fixed > NameUtil.md5(String) could leak plaintext credentials >

[GitHub] [logging-log4j2] vy commented on pull request #484: LOG4J2-3056 Refactor MD5 usage for sharing sensitive information

2021-04-09 Thread GitBox
vy commented on pull request #484: URL: https://github.com/apache/logging-log4j2/pull/484#issuecomment-816549706 @Marcono1234, I am really thankful for all your reviews, not just this particular one. Would you mind sharing your real name, please, so that I can use it rather than `Marcono12

[jira] [Commented] (LOG4J2-3056) NameUtil.md5(String) could leak plaintext credentials

2021-04-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317751#comment-17317751 ] ASF subversion and git services commented on LOG4J2-3056: - Commi

[GitHub] [logging-log4j2] vy merged pull request #484: LOG4J2-3056 Refactor MD5 usage for sharing sensitive information

2021-04-09 Thread GitBox
vy merged pull request #484: URL: https://github.com/apache/logging-log4j2/pull/484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [logging-log4j2] vy commented on a change in pull request #484: LOG4J2-3056 Refactor MD5 usage for sharing sensitive information

2021-04-09 Thread GitBox
vy commented on a change in pull request #484: URL: https://github.com/apache/logging-log4j2/pull/484#discussion_r610422311 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/NameUtil.java ## @@ -16,44 +16,55 @@ */ package org.apache.logging.log4j.cor

[GitHub] [logging-log4j2] vy commented on a change in pull request #484: LOG4J2-3056 Refactor MD5 usage for sharing sensitive information

2021-04-09 Thread GitBox
vy commented on a change in pull request #484: URL: https://github.com/apache/logging-log4j2/pull/484#discussion_r610421671 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/NameUtil.java ## @@ -16,44 +16,55 @@ */ package org.apache.logging.log4j.cor

[GitHub] [logging-log4j2] vy commented on a change in pull request #484: LOG4J2-3056 Refactor MD5 usage for sharing sensitive information

2021-04-09 Thread GitBox
vy commented on a change in pull request #484: URL: https://github.com/apache/logging-log4j2/pull/484#discussion_r610421581 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/NameUtil.java ## @@ -16,44 +16,55 @@ */ package org.apache.logging.log4j.cor

[GitHub] [logging-log4j2] vy commented on a change in pull request #484: LOG4J2-3056 Refactor MD5 usage for sharing sensitive information

2021-04-09 Thread GitBox
vy commented on a change in pull request #484: URL: https://github.com/apache/logging-log4j2/pull/484#discussion_r610421400 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/NameUtil.java ## @@ -16,44 +16,55 @@ */ package org.apache.logging.log4j.cor

[jira] [Commented] (LOG4J2-3056) NameUtil.md5(String) could leak plaintext credentials

2021-04-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317746#comment-17317746 ] ASF subversion and git services commented on LOG4J2-3056: - Commi

[jira] [Commented] (LOG4J2-3056) NameUtil.md5(String) could leak plaintext credentials

2021-04-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-3056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317735#comment-17317735 ] ASF subversion and git services commented on LOG4J2-3056: - Commi