[GitHub] [logging-log4j2] remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580077235 If you wonder why the `MpmcArrayQueue` benchmark numbers are higher than simple allocation, I am not sure either. My first gues

[GitHub] [logging-log4j2] remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-580075777 Showing only the average in ns/operation: ``` NoOpsample 27754662 492.377 ± 6.634 ns/op Thr

[jira] [Work logged] (LOG4J2-2768) LogBuilder multi-parameter overloads

2020-01-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2768?focusedWorklogId=378966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-378966 ] ASF GitHub Bot logged work on LOG4J2-2768: -- Author: ASF GitHub Bot

[GitHub] [logging-log4j2] MariusVolkhart opened a new pull request #336: LOG4J2-2768 Add log(String, ...) overloads to LogBuilder

2020-01-29 Thread GitBox
MariusVolkhart opened a new pull request #336: LOG4J2-2768 Add log(String, ...) overloads to LogBuilder URL: https://github.com/apache/logging-log4j2/pull/336 The overloaded methods behave similarly to log(String, Object[]), but reduce the need for an Object[] allocation in certain code pa

[GitHub] [logging-log4j2] vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579866133 > To add a test jar as a dependency, add `test-jar` to the `` definition. See for example [log4j-core-its/pom.xml](https://github.com/apa

[GitHub] [logging-log4j2] jvz edited a comment on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
jvz edited a comment on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579864331 To add a test jar as a dependency, add `test-jar` to the `` definition. See for example [log4j-core-its/pom.xml](https://github.

[GitHub] [logging-log4j2] jvz commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
jvz commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579864331 To add a test jar as a dependency, add `test-jar` to the `` definition.

[jira] [Commented] (LOG4J2-2768) LogBuilder multi-parameter overloads

2020-01-29 Thread Ralph Goers (Jira)
[ https://issues.apache.org/jira/browse/LOG4J2-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026023#comment-17026023 ] Ralph Goers commented on LOG4J2-2768: - Thanks for pointing this out. Not adding the

[GitHub] [logging-log4j2] remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
remkop commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579841760 I’ll take a look but it will take me some time. This is an automated

[GitHub] [logging-log4j2] vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579835151 @remkop, please note the revamp in ed1dda4. The results on my machine are as follows: ``` $ uname -a Linux tahta 4.15.0-70-ge

[GitHub] [logging-log4j2] vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
vy commented on issue #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#issuecomment-579728012 > > I chose `JsonTemplateLayout` as the new module name, which clearly communicates the intent. I am not totally convinced with the packag

[GitHub] [logging-log4j2] vy commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
vy commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372344182 ## File path: log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/l

[GitHub] [logging-log4j2] vy commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
vy commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372341908 ## File path: log4j-core/src/main/java/org/apache/logging/log4j/core/util/Throwables.java ## @@ -40,1

[GitHub] [logging-log4j2] vy commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
vy commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372341591 ## File path: log4j-layout-jackson-json-template/src/main/java/org/apache/logging/log4j/jackson/json/template/l

[GitHub] [logging-log4j2] vy commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout

2020-01-29 Thread GitBox
vy commented on a change in pull request #335: Import of LogstashLayout as JsonTemplateLayout URL: https://github.com/apache/logging-log4j2/pull/335#discussion_r372341467 ## File path: log4j-layout-jackson-json-template/src/main/resources/JsonLayout.json ## @@ -0,0 +1,27