eric-milles merged PR #1904:
URL: https://github.com/apache/groovy/pull/1904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
codecov-commenter commented on PR #1904:
URL: https://github.com/apache/groovy/pull/1904#issuecomment-3078864553
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/1904?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
perNyfelt opened a new pull request, #2259:
URL: https://github.com/apache/groovy/pull/2259
The ManagedConcurrentMap and its base class AbstractConcurrentMapBase were
removed in Groovy 4.x as part of internal cleanup.
This patch removes the corresponding ManagedConcurrentMapStressTest
paulk-asert opened a new pull request, #2267:
URL: https://github.com/apache/groovy/pull/2267
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
jdaugherty commented on PR #2267:
URL: https://github.com/apache/groovy/pull/2267#issuecomment-3084381682
Thank you @paulk-asert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
codecov-commenter commented on PR #2267:
URL: https://github.com/apache/groovy/pull/2267#issuecomment-3084216370
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2267?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
matrei commented on PR #2268:
URL: https://github.com/apache/groovy/pull/2268#issuecomment-3092501587
> Don't the name-value pairs come in source order? I would not want them
sorted to another order besides that.
It does not seem so as the order appears to differ from one build to an
matrei commented on code in PR #2267:
URL: https://github.com/apache/groovy/pull/2267#discussion_r2217020381
##
src/main/java/org/codehaus/groovy/classgen/AsmClassGenerator.java:
##
@@ -2221,10 +,11 @@ private AnnotationVisitor getAnnotationVisitor(final
AnnotatedNode targe
dependabot[bot] closed pull request #2265: Bump com.gradle.develocity from
4.0.2 to 4.1
URL: https://github.com/apache/groovy/pull/2265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
paulk-asert commented on PR #2265:
URL: https://github.com/apache/groovy/pull/2265#issuecomment-3091219026
@dependabot close
Not compatible with the currently installed ge at apache:
https://docs.gradle.com/enterprise/compatibility/#develocity_compatibility
--
This is an automate
paulk-asert commented on code in PR #2267:
URL: https://github.com/apache/groovy/pull/2267#discussion_r2217024543
##
src/main/java/org/codehaus/groovy/classgen/AsmClassGenerator.java:
##
@@ -2221,10 +,11 @@ private AnnotationVisitor getAnnotationVisitor(final
AnnotatedNode
daniellansun commented on PR #2268:
URL: https://github.com/apache/groovy/pull/2268#issuecomment-3092212821
AST transformation can add annotations, so I do not think parser is an ideal
place to fix the issue.
--
This is an automated message from the Apache Git Service.
To respond to the m
matrei opened a new pull request, #2268:
URL: https://github.com/apache/groovy/pull/2268
Sort element value pairs by key before collecting them into a
`LinkedHashMap` to ensure consistent iteration order across builds.
This change addresses GROOVY-11715 without requiring `TreeMap` usa
codecov-commenter commented on PR #2268:
URL: https://github.com/apache/groovy/pull/2268#issuecomment-3092217471
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2268?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
matrei commented on PR #2268:
URL: https://github.com/apache/groovy/pull/2268#issuecomment-3092237938
> AST transformation can add annotations, so I do not think parser is an
ideal place to fix the issue.
Aha, good point.
Is there also a reproducibility issue with annotations added
eric-milles commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3092561266
When I first ran groovysh, it created `/.groovy/aliases.json` as an
empty file. Then it went to slurp this in and failed with an exception that it
cannot parse empty string as JSON.
paulk-asert commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3092607872
Looks like I accidentally left some debugging code in play. I'll redo the
release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
matrei commented on PR #2268:
URL: https://github.com/apache/groovy/pull/2268#issuecomment-3093797760
Not the right solution, sorry for the noise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
matrei closed pull request #2268: Sort element value pairs in `AstBuilder` for
reproducibility
URL: https://github.com/apache/groovy/pull/2268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
eric-milles commented on PR #2268:
URL: https://github.com/apache/groovy/pull/2268#issuecomment-3092475283
Don't the name-value pairs come in source order? I would not want them
sorted to another order besides that.
--
This is an automated message from the Apache Git Service.
To respond
eric-milles commented on PR #2250:
URL: https://github.com/apache/groovy/pull/2250#issuecomment-3049747033
Is there a test case that can check the message format?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
eric-milles opened a new pull request, #2261:
URL: https://github.com/apache/groovy/pull/2261
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
codecov-commenter commented on PR #2261:
URL: https://github.com/apache/groovy/pull/2261#issuecomment-3049516438
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2261?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2260:
URL: https://github.com/apache/groovy/pull/2260#issuecomment-3049267038
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2260?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles opened a new pull request, #2260:
URL: https://github.com/apache/groovy/pull/2260
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
daniellansun commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3065085437
https://github.com/user-attachments/assets/31c17f82-a125-4826-86a6-99841f92f85b";
/>
Looks better now ;-)
--
This is an automated message from the Apache Git Service.
To resp
daniellansun merged PR #2262:
URL: https://github.com/apache/groovy/pull/2262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2262:
URL: https://github.com/apache/groovy/pull/2262#issuecomment-3062874272
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun commented on PR #2261:
URL: https://github.com/apache/groovy/pull/2261#issuecomment-3058307967
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2261:
URL: https://github.com/apache/groovy/pull/2261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
eric-milles opened a new pull request, #2262:
URL: https://github.com/apache/groovy/pull/2262
`ExecutorService` declares `submit(Callable)` and `submit(Runnable)` so add
`submit(Closure)` to prevent routing of closures to the `Runnable` variant,
which drops the return value.
Add chec
daniellansun commented on PR #2260:
URL: https://github.com/apache/groovy/pull/2260#issuecomment-3055396736
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2260:
URL: https://github.com/apache/groovy/pull/2260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
codecov-commenter commented on PR #2262:
URL: https://github.com/apache/groovy/pull/2262#issuecomment-3058431321
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2262?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on code in PR #2263:
URL: https://github.com/apache/groovy/pull/2263#discussion_r2202310797
##
subprojects/groovy-groovysh/src/main/resources/nanorc/groovy.nanorc:
##
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
Copilot commented on code in PR #2263:
URL: https://github.com/apache/groovy/pull/2263#discussion_r2202289500
##
subprojects/groovy-groovysh/src/test/groovy/org/apache/groovy/groovysh/commands/SystemTestSupport.groovy:
##
@@ -18,35 +18,27 @@
*/
package org.apache.groovy.groov
paulk-asert opened a new pull request, #2263:
URL: https://github.com/apache/groovy/pull/2263
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
paulk-asert commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064674007
> GQ {
> add: }> from n in [1, 2, 3]
> add: }> innerjoin m in [2, 3, 4] on m = n
> add: }> select m, n
> add: }> }
You currently have to do:
println GQ {
paulk-asert commented on code in PR #2263:
URL: https://github.com/apache/groovy/pull/2263#discussion_r2202316790
##
subprojects/groovy-groovysh/src/main/resources/nanorc/groovy.nanorc:
##
@@ -0,0 +1,45 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
daniellansun commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064675791
I prefer the original style of output, as it is compact and more readable
**current PR:** (a bit verbose, IMHO)
https://github.com/user-attachments/assets/610a0235-5e1f-4670-9
daniellansun commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064624433
I like the improvement very much!
It would be great if the result of GINQ in groovySh could be shown as ascii
table as usual.
BTW, `on` is a keyword of GINQ too.
`
daniellansun commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064680893
> > GQ {
> > add: }> from n in [1, 2, 3]
> > add: }> innerjoin m in [2, 3, 4] on m = n
> > add: }> select m, n
> > add: }> }
>
> You currently have to do:
>
paulk-asert commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-306468
> I prefer the original style of output, as it is compact and more readable
>
> **current PR:** (a bit verbose, IMHO) https://private-user-images.githubusercontent.com/9151616/465
daniellansun commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064684229
> > I prefer the original style of output, as it is compact and more readable
> > **current PR:** (a bit verbose, IMHO) https://private-user-images.githubusercontent.com/9151616/4655
codecov-commenter commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064556710
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2263?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2258:
URL: https://github.com/apache/groovy/pull/2258#issuecomment-3005054799
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2258?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2255:
URL: https://github.com/apache/groovy/pull/2255#issuecomment-3038836778
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2255?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun merged PR #2259:
URL: https://github.com/apache/groovy/pull/2259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2259:
URL: https://github.com/apache/groovy/pull/2259#issuecomment-3036619563
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
codecov-commenter commented on PR #2259:
URL: https://github.com/apache/groovy/pull/2259#issuecomment-3019587240
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2259?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2264:
URL: https://github.com/apache/groovy/pull/2264#issuecomment-3074656685
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2264?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles merged PR #2174:
URL: https://github.com/apache/groovy/pull/2174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #2263:
URL: https://github.com/apache/groovy/pull/2263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
dependabot[bot] opened a new pull request, #2266:
URL: https://github.com/apache/groovy/pull/2266
Bumps org.apache.maven:maven-core from 3.9.10 to 3.9.11.
[ {
* Object#getClas
eric-milles commented on PR #2265:
URL: https://github.com/apache/groovy/pull/2265#issuecomment-3089844510
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
eric-milles merged PR #2264:
URL: https://github.com/apache/groovy/pull/2264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
dependabot[bot] opened a new pull request, #2269:
URL: https://github.com/apache/groovy/pull/2269
[