Re: [PR] Jline3 [groovy]

[via GitHub]

daniellansun commented on PR #2263:
URL: https://github.com/apache/groovy/pull/2263#issuecomment-3064684229

   > > I prefer the original style of output, as it is compact and more readable
   > > **current PR:** (a bit verbose, IMHO) <img alt="image" width="466" 
height="417" 
src="https://private-user-images.githubusercontent.com/9151616/465545876-610a0235-5e1f-4670-9dcb-8b103731d5dd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTIyOTYyMzAsIm5iZiI6MTc1MjI5NTkzMCwicGF0aCI6Ii85MTUxNjE2LzQ2NTU0NTg3Ni02MTBhMDIzNS01ZTFmLTQ2NzAtOWRjYi04YjEwMzczMWQ1ZGQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDcxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTA3MTJUMDQ1MjEwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDY1MjczM2VmMDk2OTg1ZWFiYzBiNDEzZGJlMjBjOTNjMDNjM2NmMGNiZDczN2I1NWU1MmRiYmRkMTE1OTI5NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.e6WVx6w-T3aKekIkGImUU6kuKkjuVeDf2pgE5if65V4";>
   > > **5.0.0-beta-1:** (compact and readable) <img alt="image" width="649" 
height="234" 
src="https://private-user-images.githubusercontent.com/9151616/465545956-4243a511-aac6-4c26-a977-62a07c241029.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTIyOTYyMzAsIm5iZiI6MTc1MjI5NTkzMCwicGF0aCI6Ii85MTUxNjE2LzQ2NTU0NTk1Ni00MjQzYTUxMS1hYWM2LTRjMjYtYTk3Ny02MmEwN2MyNDEwMjkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDcxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTA3MTJUMDQ1MjEwWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmI0MWNhNTJjYmZjYTYxZDIzZTc5Y2I5MWUzZmJlZDIxNGM0MGY3NDA4NmIwNGI5OGVkZDU1OWQ3YmRjNmUwOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.fivr9okoF5ImH5eZC0TN3XltzrnweUBWfn72S8L6jl0";>
   > 
   > I agree with you. Just haven't found time to turn that off yet.
   
   It seem that we need to invoke `toString()` of the result.
   As for "===>", it looks redundant, we could remove it in this PR by the way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org