daniellansun commented on PR #2245:
URL: https://github.com/apache/groovy/pull/2245#issuecomment-2927193484
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
daniellansun commented on PR #2243:
URL: https://github.com/apache/groovy/pull/2243#issuecomment-2926284173
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun commented on PR #2241:
URL: https://github.com/apache/groovy/pull/2241#issuecomment-2924013850
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
daniellansun merged PR #2243:
URL: https://github.com/apache/groovy/pull/2243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
eric-milles commented on PR #2245:
URL: https://github.com/apache/groovy/pull/2245#issuecomment-2930740881
You only really need to sort if size > 1. But otherwise looks fine.
Is there a way to test this?
--
This is an automated message from the Apache Git Service.
To respond to the
daniellansun merged PR #2233:
URL: https://github.com/apache/groovy/pull/2233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
Copilot commented on code in PR #2243:
URL: https://github.com/apache/groovy/pull/2243#discussion_r2118224734
##
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java:
##
@@ -2397,7 +2397,7 @@ public void visitReturnStatement(final ReturnStatement
state
daniellansun commented on PR #2243:
URL: https://github.com/apache/groovy/pull/2243#issuecomment-2925714533
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
daniellansun commented on PR #2241:
URL: https://github.com/apache/groovy/pull/2241#issuecomment-2925165164
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2241:
URL: https://github.com/apache/groovy/pull/2241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
paulk-asert commented on PR #2243:
URL: https://github.com/apache/groovy/pull/2243#issuecomment-2925883728
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
paulk-asert commented on code in PR #2245:
URL: https://github.com/apache/groovy/pull/2245#discussion_r2120162906
##
src/main/java/org/codehaus/groovy/transform/DelegateASTTransformation.java:
##
@@ -165,7 +167,10 @@ public void visit(final ASTNode[] nodes, final SourceUnit
sou
paulk-asert commented on code in PR #2245:
URL: https://github.com/apache/groovy/pull/2245#discussion_r2120162906
##
src/main/java/org/codehaus/groovy/transform/DelegateASTTransformation.java:
##
@@ -165,7 +167,10 @@ public void visit(final ASTNode[] nodes, final SourceUnit
sou
paulk-asert merged PR #2244:
URL: https://github.com/apache/groovy/pull/2244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #2156:
URL: https://github.com/apache/groovy/pull/2156#issuecomment-2924509727
I'll create a thread on the mailing lists. If we were going to make such a
change, Groovy 5 would be an ideal time.
--
This is an automated message from the Apache Git Service.
To re
eric-milles opened a new pull request, #2243:
URL: https://github.com/apache/groovy/pull/2243
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
jdaugherty opened a new pull request, #2245:
URL: https://github.com/apache/groovy/pull/2245
Follow-up to https://github.com/apache/groovy/pull/2231 - fix `@Delegate`
generating inconsistent ordering of added methods.
--
This is an automated message from the Apache Git Service.
To respond
daniellansun commented on PR #2245:
URL: https://github.com/apache/groovy/pull/2245#issuecomment-2927127457
@paulk-asert has fixed the ordering issue at the commit:
https://github.com/apache/groovy/commit/e42a2a7dc3973a9c4007c4247e58360e95d02e5c
Thanks for your contribution all the
jdaugherty commented on PR #2245:
URL: https://github.com/apache/groovy/pull/2245#issuecomment-2927129503
@daniellansun Hi Daniel, this is a separate issue that's fixing the
@Delegate in the same way as that one.
--
This is an automated message from the Apache Git Service.
To respond to
eric-milles commented on code in PR #2245:
URL: https://github.com/apache/groovy/pull/2245#discussion_r2119460094
##
src/main/java/org/codehaus/groovy/transform/DelegateASTTransformation.java:
##
@@ -215,7 +220,10 @@ public void visit(final ASTNode[] nodes, final SourceUnit
sou
eric-milles commented on PR #2244:
URL: https://github.com/apache/groovy/pull/2244#issuecomment-2927723778
I agree it is better to have the error located on the specific named
argument instead of the start of the argument list.
--
This is an automated message from the Apache Git Service.
jdaugherty commented on code in PR #2245:
URL: https://github.com/apache/groovy/pull/2245#discussion_r2119566916
##
src/main/java/org/codehaus/groovy/transform/DelegateASTTransformation.java:
##
@@ -215,7 +220,10 @@ public void visit(final ASTNode[] nodes, final SourceUnit
sour
dongwq closed pull request #2215: GROOVY-11655: Create extension method to make
StringBuilder like a stack
URL: https://github.com/apache/groovy/pull/2215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
codecov-commenter commented on PR #2243:
URL: https://github.com/apache/groovy/pull/2243#issuecomment-2925489543
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2243?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert commented on PR #2242:
URL: https://github.com/apache/groovy/pull/2242#issuecomment-2924450970
I like your suggestions but I think it could be further improved. I'll merge
and tweak if I can think of better wording.
--
This is an automated message from the Apache Git Service.
paulk-asert merged PR #2242:
URL: https://github.com/apache/groovy/pull/2242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert opened a new pull request, #2244:
URL: https://github.com/apache/groovy/pull/2244
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
codecov-commenter commented on PR #2244:
URL: https://github.com/apache/groovy/pull/2244#issuecomment-2926467927
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2244?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on code in PR #2254:
URL: https://github.com/apache/groovy/pull/2254#discussion_r2153612481
##
src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java:
##
@@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher
matcher) {
r
paulk-asert commented on code in PR #2254:
URL: https://github.com/apache/groovy/pull/2254#discussion_r2153724057
##
src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java:
##
@@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher
matcher) {
re
paulk-asert commented on code in PR #2254:
URL: https://github.com/apache/groovy/pull/2254#discussion_r2153724057
##
src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java:
##
@@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher
matcher) {
re
paulk-asert opened a new pull request, #2254:
URL: https://github.com/apache/groovy/pull/2254
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
codecov-commenter commented on PR #2254:
URL: https://github.com/apache/groovy/pull/2254#issuecomment-2975592770
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2254?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
codecov-commenter commented on PR #2256:
URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986083595
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2256?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun commented on code in PR #2254:
URL: https://github.com/apache/groovy/pull/2254#discussion_r2155691786
##
src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java:
##
@@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher
matcher) {
r
daniellansun merged PR #2254:
URL: https://github.com/apache/groovy/pull/2254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2254:
URL: https://github.com/apache/groovy/pull/2254#issuecomment-2985985015
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Choosechee opened a new pull request, #2256:
URL: https://github.com/apache/groovy/pull/2256
I have made some changes to `Tuple` that are related to its backing array.
One of them fixes a pretty major bug I found:
- Made `Tuple` implement `RandomAccess`.
- Currently, `Tuple`'s 'toA
eric-milles opened a new pull request, #2255:
URL: https://github.com/apache/groovy/pull/2255
For an expression like `list.stream().collect(Collectors.toSet())` the
return type is dependent on the return type of `toSet`, which can be partially
resolved from the receiver type (for example `S
paulk-asert commented on PR #2256:
URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986051227
You might want to squash your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
paulk-asert commented on PR #2256:
URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986047943
I created this issue to track this change:
https://issues.apache.org/jira/browse/GROOVY-11702
--
This is an automated message from the Apache Git Service.
To respond to the message
Choosechee commented on PR #2256:
URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986410255
> You might want to squash your PR.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
paulk-asert closed pull request #2256: Tuple changes related to its backing
array
URL: https://github.com/apache/groovy/pull/2256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
paulk-asert commented on PR #2256:
URL: https://github.com/apache/groovy/pull/2256#issuecomment-2986633960
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
Copilot commented on code in PR #2257:
URL: https://github.com/apache/groovy/pull/2257#discussion_r2160276495
##
subprojects/groovy-ginq/src/main/groovy/org/apache/groovy/ginq/provider/collection/GinqAstWalker.groovy:
##
@@ -1496,19 +1498,19 @@ class GinqAstWalker implements
Gi
daniellansun opened a new pull request, #2257:
URL: https://github.com/apache/groovy/pull/2257
https://issues.apache.org/jira/browse/GROOVY-11703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
codecov-commenter commented on PR #2257:
URL: https://github.com/apache/groovy/pull/2257#issuecomment-2994082156
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2257?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
daniellansun merged PR #2255:
URL: https://github.com/apache/groovy/pull/2255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2255:
URL: https://github.com/apache/groovy/pull/2255#issuecomment-2993349835
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
eric-milles opened a new pull request, #2258:
URL: https://github.com/apache/groovy/pull/2258
`IntRange` is `List`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
Copilot commented on code in PR #2253:
URL: https://github.com/apache/groovy/pull/2253#discussion_r2146303223
##
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java:
##
@@ -2685,7 +2685,8 @@ && isStringType(getType(nameExpr))) {
daniellansun commented on PR #2253:
URL: https://github.com/apache/groovy/pull/2253#issuecomment-2972012384
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #2253:
URL: https://github.com/apache/groovy/pull/2253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
paulk-asert merged PR #2247:
URL: https://github.com/apache/groovy/pull/2247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
Copilot commented on code in PR #2254:
URL: https://github.com/apache/groovy/pull/2254#discussion_r2153222725
##
src/main/java/org/codehaus/groovy/runtime/StringGroovyMethods.java:
##
@@ -1547,6 +1548,146 @@ private static List getGroups(final Matcher
matcher) {
return
daniellansun commented on PR #2254:
URL: https://github.com/apache/groovy/pull/2254#issuecomment-2981925028
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
paulk-asert commented on PR #2247:
URL: https://github.com/apache/groovy/pull/2247#issuecomment-2979857110
I tweaked the javadoc to better describe the intent of the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
daniellansun merged PR #2252:
URL: https://github.com/apache/groovy/pull/2252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
dependabot[bot] opened a new pull request, #2249:
URL: https://github.com/apache/groovy/pull/2249
Bumps org.apache.maven:maven-core from 3.9.9 to 3.9.10.
[ {
eric-milles commented on PR #2257:
URL: https://github.com/apache/groovy/pull/2257#issuecomment-2997225886
It would be nice to have a small test case in core for this, but otherwise
looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
daniellansun merged PR #2257:
URL: https://github.com/apache/groovy/pull/2257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun merged PR #2156:
URL: https://github.com/apache/groovy/pull/2156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2156:
URL: https://github.com/apache/groovy/pull/2156#issuecomment-2993623522
As most users like the improvement, I'll merge the PR soon.
https://lists.apache.org/thread/pm35433ghyglk03dmlvn3z4o72qd7ynf
--
This is an automated message from the A
Copilot commented on code in PR #2156:
URL: https://github.com/apache/groovy/pull/2156#discussion_r2160059938
##
src/main/java/org/codehaus/groovy/control/ResolveVisitor.java:
##
@@ -95,9 +95,9 @@
*/
public class ResolveVisitor extends ClassCodeExpressionTransformer {
//
daniellansun commented on PR #2257:
URL: https://github.com/apache/groovy/pull/2257#issuecomment-2997328977
I tried to create a simple script to reproduce the issue, but failed either.
Let's tweak the test case in future.
--
This is an automated message from the Apache Git Service.
To res
paulk-asert merged PR #2245:
URL: https://github.com/apache/groovy/pull/2245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #2246:
URL: https://github.com/apache/groovy/pull/2246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert opened a new pull request, #2247:
URL: https://github.com/apache/groovy/pull/2247
… Stream#count
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
codecov-commenter commented on PR #2247:
URL: https://github.com/apache/groovy/pull/2247#issuecomment-2940538288
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2247?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert commented on PR #2244:
URL: https://github.com/apache/groovy/pull/2244#issuecomment-2929949913
I rejigged to carry a little more info in the `entries` data structure which
meant less work to get to the correct ASTNode.
--
This is an automated message from the Apache Git Servic
paulk-asert opened a new pull request, #2246:
URL: https://github.com/apache/groovy/pull/2246
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
jdaugherty commented on code in PR #2245:
URL: https://github.com/apache/groovy/pull/2245#discussion_r2121054942
##
src/main/java/org/codehaus/groovy/transform/DelegateASTTransformation.java:
##
@@ -165,7 +167,10 @@ public void visit(final ASTNode[] nodes, final SourceUnit
sour
jdaugherty commented on PR #2245:
URL: https://github.com/apache/groovy/pull/2245#issuecomment-2931453412
I've made the requested change to only sort if there's > 1 entry in the list.
I also compiled with 4.0.27 and then with this change for the
grails-scaffolding project. Here's one
codecov-commenter commented on PR #2241:
URL: https://github.com/apache/groovy/pull/2241#issuecomment-2921871204
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2241?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert opened a new pull request, #2241:
URL: https://github.com/apache/groovy/pull/2241
…table copyWith method should include NamedParam information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
jonnybot0 opened a new pull request, #2242:
URL: https://github.com/apache/groovy/pull/2242
Was reading through [the guide on Type Checking
Extensions](https://docs.groovy-lang.org/docs/latest/html/documentation/#_type_checking_extensions)
today and my picky brain tripped over what seemed l
Copilot commented on code in PR #2242:
URL: https://github.com/apache/groovy/pull/2242#discussion_r2116148341
##
src/spec/doc/_type-checking-extensions.adoc:
##
@@ -1062,14 +1062,14 @@ type of the dynamic call is a `Robot`, subsequent calls
will be done statically!
Some woul
codecov-commenter commented on PR #2242:
URL: https://github.com/apache/groovy/pull/2242#issuecomment-2922785953
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2242?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert merged PR #2235:
URL: https://github.com/apache/groovy/pull/2235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun commented on code in PR #2247:
URL: https://github.com/apache/groovy/pull/2247#discussion_r2129556784
##
src/main/java/org/codehaus/groovy/runtime/StreamGroovyMethods.java:
##
@@ -568,6 +568,24 @@ public static DoubleStream doubleStream(final double[]
self) {
codecov-commenter commented on PR #2251:
URL: https://github.com/apache/groovy/pull/2251#issuecomment-2949805508
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2251?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles opened a new pull request, #2251:
URL: https://github.com/apache/groovy/pull/2251
`StaticMethodCallExpressionTransformer` creates
"Type.staticMethod(arguments)" and later `StaticInvocationWriter` gets type of
receiver expression as `Class`. Use `Type` for access checks.
--
T
daniellansun merged PR #2249:
URL: https://github.com/apache/groovy/pull/2249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun merged PR #2248:
URL: https://github.com/apache/groovy/pull/2248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun opened a new pull request, #2252:
URL: https://github.com/apache/groovy/pull/2252
https://issues.apache.org/jira/browse/GROOVY-11695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Copilot commented on code in PR #2252:
URL: https://github.com/apache/groovy/pull/2252#discussion_r2133787572
##
subprojects/groovy-ginq/src/main/groovy/org/apache/groovy/ginq/provider/collection/GinqAstWalker.groovy:
##
@@ -1212,6 +1218,11 @@ class GinqAstWalker implements
Gin
codecov-commenter commented on PR #2252:
URL: https://github.com/apache/groovy/pull/2252#issuecomment-2952430056
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2252?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
paulk-asert commented on PR #2247:
URL: https://github.com/apache/groovy/pull/2247#issuecomment-2953207162
> I agree with Christopher Smith from the mailing list that the semantic of
count is different from size.
https://lists.apache.org/thread/8yknyvcxbksoojh6rz5shwv6jdjy1dnx
For th
daniellansun commented on PR #2247:
URL: https://github.com/apache/groovy/pull/2247#issuecomment-2953410994
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
Copilot commented on code in PR #2251:
URL: https://github.com/apache/groovy/pull/2251#discussion_r2134427507
##
src/main/java/org/codehaus/groovy/classgen/asm/sc/StaticInvocationWriter.java:
##
@@ -304,6 +299,9 @@ protected boolean writeDirectMethodCall(final MethodNode
target
daniellansun merged PR #2251:
URL: https://github.com/apache/groovy/pull/2251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #2251:
URL: https://github.com/apache/groovy/pull/2251#issuecomment-2953588691
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
codecov-commenter commented on PR #2250:
URL: https://github.com/apache/groovy/pull/2250#issuecomment-2953608275
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2250?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
eric-milles commented on PR #2174:
URL: https://github.com/apache/groovy/pull/2174#issuecomment-2959866869
sorry, I keep misinterpreting the icon in the branches list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
eric-milles closed pull request #2174: GROOVY-11601: remove support for
expression list in `for`-each statement
URL: https://github.com/apache/groovy/pull/2174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
eric-milles opened a new pull request, #2253:
URL: https://github.com/apache/groovy/pull/2253
```groovy
@TypeChecked test() {
def optional = Optional.empty().map(Iterable::asCollection)
// Optional>
}
```
see also GROOVY-10984
--
This is an automated
codecov-commenter commented on PR #2253:
URL: https://github.com/apache/groovy/pull/2253#issuecomment-2959958684
##
[Codecov](https://app.codecov.io/gh/apache/groovy/pull/2253?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut
1301 - 1400 of 1478 matches
Mail list logo
