[jira] [Commented] (GROOVY-9742) GroovyClassLoader.parseClass() StampedCommonCache.getAndPut() hang

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943884#comment-17943884 ] ASF GitHub Bot commented on GROOVY-9742: codecov-commenter commented on PR #2188

Re: [PR] GROOVY-9742: GroovyClassLoader.parseClass() StampedCommonCache.getAnd… [groovy]

2025-04-12 Thread via GitHub
codecov-commenter commented on PR #2188: URL: https://github.com/apache/groovy/pull/2188#issuecomment-2799752158 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2188?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

Re: [PR] GROOVY-9742: GroovyClassLoader.parseClass() StampedCommonCache.getAnd… [groovy]

2025-04-12 Thread via GitHub
daniellansun commented on PR #2188: URL: https://github.com/apache/groovy/pull/2188#issuecomment-2799732499 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[jira] [Commented] (GROOVY-9742) GroovyClassLoader.parseClass() StampedCommonCache.getAndPut() hang

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943883#comment-17943883 ] ASF GitHub Bot commented on GROOVY-9742: daniellansun commented on PR #2188: URL

[jira] [Commented] (GROOVY-11609) Avoid finding same variable/class member repeatedly

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943876#comment-17943876 ] ASF GitHub Bot commented on GROOVY-11609: - daniellansun commented on PR #2186:

Re: [PR] GROOVY-11609: Avoid finding same variable/class member repeatedly [groovy]

2025-04-12 Thread via GitHub
daniellansun commented on PR #2186: URL: https://github.com/apache/groovy/pull/2186#issuecomment-2799588675 > @daniellansun there are already 3 maps/caches in VariableScope. Why are those no good? Finding logic will still be triggered for each same variables/class members in the Vari

Re: [PR] GROOVY-11609: Avoid finding same variable/class member repeatedly [groovy]

2025-04-12 Thread via GitHub
blackdrag commented on PR #2186: URL: https://github.com/apache/groovy/pull/2186#issuecomment-2799567259 @daniellansun there are already 3 maps/caches in VariableScope. Why are those no good? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (GROOVY-11609) Avoid finding same variable/class member repeatedly

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943872#comment-17943872 ] ASF GitHub Bot commented on GROOVY-11609: - blackdrag commented on PR #2186: URL

[jira] [Commented] (GROOVY-9742) GroovyClassLoader.parseClass() StampedCommonCache.getAndPut() hang

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943871#comment-17943871 ] ASF GitHub Bot commented on GROOVY-9742: paulk-asert opened a new pull request,

[PR] GROOVY-9742: GroovyClassLoader.parseClass() StampedCommonCache.getAnd… [groovy]

2025-04-12 Thread via GitHub
paulk-asert opened a new pull request, #2188: URL: https://github.com/apache/groovy/pull/2188 …Put() hang (provide constructor to enable alternative sourceCaches to be set) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (GROOVY-11606) Lazy findAll, collect, collectMany

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943864#comment-17943864 ] ASF GitHub Bot commented on GROOVY-11606: - paulk-asert commented on PR #2182: U

Re: [PR] GROOVY-11606: Lazy findAll, collect, collectMany [groovy]

2025-04-12 Thread via GitHub
paulk-asert commented on PR #2182: URL: https://github.com/apache/groovy/pull/2182#issuecomment-2799053479 The Smalltalk semantics for "collect" is transform. Think: I have an aggregate of People and I'll produce an aggregate of Names by "collect"ing each person's name. The "into a collecti

[jira] [Commented] (GROOVY-11607) Nested in Ant task is not handled nicely

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943834#comment-17943834 ] ASF GitHub Bot commented on GROOVY-11607: - codecov-commenter commented on PR #2

Re: [PR] GROOVY-11607: `groovyc`: `fileset` lists files [groovy]

2025-04-12 Thread via GitHub
codecov-commenter commented on PR #2187: URL: https://github.com/apache/groovy/pull/2187#issuecomment-2798897074 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2187?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[jira] [Updated] (GROOVY-11609) Avoid finding same variable/class member repeatedly

2025-04-12 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-11609: - Language: groovy > Avoid finding same variable/class member repeatedly > --

[jira] [Updated] (GROOVY-4941) Static methods cannot be called during AST transformation via AstBuilder.buildFromSpec()

2025-04-12 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-4941: Language: groovy > Static methods cannot be called during AST transformation via > AstBuilder.bui

[jira] [Assigned] (GROOVY-11607) Nested in Ant task is not handled nicely

2025-04-12 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-11607: Assignee: Eric Milles > Nested in Ant task is not handled nicely > ---

[jira] [Updated] (GROOVY-11607) Nested in Ant task is not handled nicely

2025-04-12 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-11607: - Language: groovy > Nested in Ant task is not handled nicely > ---

[jira] [Updated] (GROOVY-11607) Nested in Ant task is not handled nicely

2025-04-12 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-11607: - Component/s: Ant integration > Nested in Ant task is not handled nicely > ---

[jira] [Commented] (GROOVY-4941) Static methods cannot be called during AST transformation via AstBuilder.buildFromSpec()

2025-04-12 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943824#comment-17943824 ] Eric Milles commented on GROOVY-4941: - There are no tests, so we don't really know w

[jira] [Commented] (GROOVY-11606) Lazy findAll, collect, collectMany

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943822#comment-17943822 ] ASF GitHub Bot commented on GROOVY-11606: - eric-milles commented on PR #2182: U

[jira] [Commented] (GROOVY-11609) Avoid finding same variable/class member repeatedly

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943819#comment-17943819 ] ASF GitHub Bot commented on GROOVY-11609: - eric-milles commented on PR #2186: U

Re: [PR] GROOVY-11609: Avoid finding same variable/class member repeatedly [groovy]

2025-04-12 Thread via GitHub
eric-milles commented on PR #2186: URL: https://github.com/apache/groovy/pull/2186#issuecomment-2798851375 Do you have something to measure the performance difference? We have nothing to weigh the complexity of the changes against. Even if complex, it is compile-time behavior. I wou

[jira] [Commented] (GROOVY-11609) Avoid finding same variable/class member repeatedly

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943802#comment-17943802 ] ASF GitHub Bot commented on GROOVY-11609: - Copilot commented on code in PR #218

Re: [PR] GROOVY-11609: Avoid finding same variable/class member repeatedly [groovy]

2025-04-12 Thread via GitHub
Copilot commented on code in PR #2186: URL: https://github.com/apache/groovy/pull/2186#discussion_r2040641694 ## src/main/java/org/codehaus/groovy/classgen/VariableScopeVisitor.java: ## @@ -192,113 +195,130 @@ private void declare(final Variable variable, final ASTNode context)

[jira] [Commented] (GROOVY-11609) Avoid finding same variable/class member repeatedly

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943796#comment-17943796 ] ASF GitHub Bot commented on GROOVY-11609: - codecov-commenter commented on PR #2

Re: [PR] GROOVY-11609: Avoid finding same variable/class member repeatedly [groovy]

2025-04-12 Thread via GitHub
codecov-commenter commented on PR #2186: URL: https://github.com/apache/groovy/pull/2186#issuecomment-2798789566 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2186?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[jira] [Commented] (GROOVY-11609) Avoid finding same variable/class member repeatedly

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943795#comment-17943795 ] ASF GitHub Bot commented on GROOVY-11609: - Copilot commented on code in PR #218

Re: [PR] GROOVY-11609: Avoid finding same variable/class member repeatedly [groovy]

2025-04-12 Thread via GitHub
Copilot commented on code in PR #2186: URL: https://github.com/apache/groovy/pull/2186#discussion_r2040634434 ## src/main/java/org/codehaus/groovy/classgen/VariableScopeVisitor.java: ## @@ -760,4 +780,66 @@ public void visitVariableExpression(final VariableExpression expression

[jira] [Commented] (GROOVY-11609) Avoid finding same variable/class member repeatedly

2025-04-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943794#comment-17943794 ] ASF GitHub Bot commented on GROOVY-11609: - daniellansun opened a new pull reque

[jira] [Updated] (GROOVY-11609) Avoid finding same variable/class member repeatedly

2025-04-12 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-11609: Description: When I debugged GROOVY-4721, I found {{VariableScopeVisitor}} will try to find same

[jira] [Created] (GROOVY-11609) Avoid finding same variable/class member repeatedly

2025-04-12 Thread Daniel Sun (Jira)
Daniel Sun created GROOVY-11609: --- Summary: Avoid finding same variable/class member repeatedly Key: GROOVY-11609 URL: https://issues.apache.org/jira/browse/GROOVY-11609 Project: Groovy Issue Ty