[
https://issues.apache.org/jira/browse/GROOVY-11607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943834#comment-17943834
] ASF GitHub Bot commented on GROOVY-11607: ----------------------------------------- codecov-commenter commented on PR #2187: URL: https://github.com/apache/groovy/pull/2187#issuecomment-2798897074 ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2187?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review. > Project coverage is 68.9164%. Comparing base [(`14e9f88`)](https://app.codecov.io/gh/apache/groovy/commit/14e9f88b6aab7f80978249747e60245e0f6eea3a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c4051ca`)](https://app.codecov.io/gh/apache/groovy/commit/c4051ca47f95f8d6a16cc695aed0028abf834261?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2187?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...src/main/java/org/codehaus/groovy/ant/Groovyc.java](https://app.codecov.io/gh/apache/groovy/pull/2187?src=pr&el=tree&filepath=subprojects%2Fgroovy-ant%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fant%2FGroovyc.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWFudC9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvYW50L0dyb292eWMuamF2YQ==) | 90.0000% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/groovy/pull/2187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> [](https://app.codecov.io/gh/apache/groovy/pull/2187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## master #2187 +/- ## ================================================== - Coverage 68.9220% 68.9164% -0.0056% + Complexity 29596 29594 -2 ================================================== Files 1423 1423 Lines 113894 113896 +2 Branches 19750 19751 +1 ================================================== - Hits 78498 78493 -5 - Misses 28779 28784 +5 - Partials 6617 6619 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2187?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...src/main/java/org/codehaus/groovy/ant/Groovyc.java](https://app.codecov.io/gh/apache/groovy/pull/2187?src=pr&el=tree&filepath=subprojects%2Fgroovy-ant%2Fsrc%2Fmain%2Fjava%2Forg%2Fcodehaus%2Fgroovy%2Fant%2FGroovyc.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWFudC9zcmMvbWFpbi9qYXZhL29yZy9jb2RlaGF1cy9ncm9vdnkvYW50L0dyb292eWMuamF2YQ==) | `48.7013% <90.0000%> (+0.2230%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2187/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) </details> <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> > Nested <src> in <groovyc> Ant task is not handled nicely > -------------------------------------------------------- > > Key: GROOVY-11607 > URL: https://issues.apache.org/jira/browse/GROOVY-11607 > Project: Groovy > Issue Type: Bug > Components: Ant integration > Affects Versions: 4.0.26 > Reporter: Björn Kautler > Assignee: Eric Milles > Priority: Major > > I tried to configure {{groovyc}} Ant task so that a specific Groovy file is > not compiled. > But it seems all nested `src` results are always treated as directories, not > as what they are. > I for example tried using > {code:xml} > <groovy:src> > <fileset dir="test"> > <exclude name="foo.groovy"/> > </fileset> > </groovy:src> > {code} > but that gave an error that {{otherfile.groovy}} is not a directory. > And the task also has no other means of including or excluding files as far > as I have seen. > If the {{src}} would have been treated correctly, that wouldn't have been a > problem though. -- This message was sent by Atlassian Jira (v8.20.10#820010)
