Re: [PR] `SecureASTCustomizer` can't see types set prior by a type-checking extension [groovy]

2024-01-03 Thread via GitHub
eric-milles commented on PR #1913: URL: https://github.com/apache/groovy/pull/1913#issuecomment-1876006042 The `SecureASTCustomizer` is run as part of the _canonicalization_ compilation phase (5). Static type checking is run as part of the _instruction selection_ phase (6). But to y

[jira] [Updated] (GROOVY-11259) STC loses generic information on method references

2024-01-03 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-11259: - Fix Version/s: 3.0.21 > STC loses generic information on method references > --

[jira] [Commented] (GROOVY-11263) Analyze dead code

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802304#comment-17802304 ] ASF GitHub Bot commented on GROOVY-11263: - daniellansun commented on PR #2023:

Re: [PR] GROOVY-11263: Analyze dead code [groovy]

2024-01-03 Thread via GitHub
daniellansun commented on PR #2023: URL: https://github.com/apache/groovy/pull/2023#issuecomment-1875821378 We can add a option to prevent or warn dead code or disable check totally. Here is the table to show how mainstream programming language to handle dead code. Most of them preven

[jira] [Updated] (GROOVY-11265) Runtime rehydrate error for closure in interface default method

2024-01-03 Thread Christopher Smith (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Smith updated GROOVY-11265: --- Component/s: Static compilation External issue URL: https://github.com/ch

[jira] [Updated] (GROOVY-9803) Static type checker forgets nested generic types

2024-01-03 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-9803: Description: When using a nested generic type (for example, from Vavr {{Try}}), Groovy forgets th

[jira] [Created] (GROOVY-11265) Runtime rehydrate error for closure in interface default method

2024-01-03 Thread Christopher Smith (Jira)
Christopher Smith created GROOVY-11265: -- Summary: Runtime rehydrate error for closure in interface default method Key: GROOVY-11265 URL: https://issues.apache.org/jira/browse/GROOVY-11265 Project

Re: [PR] make use of Runtime.version().feature() [groovy]

2024-01-03 Thread via GitHub
eric-milles commented on PR #2019: URL: https://github.com/apache/groovy/pull/2019#issuecomment-1875761956 The changes all look fine except the `IllegalArgumentException` bit. Can you change the name of the parameter to indicate fail on asm parsing or whatever you'd call the purpose of the

Re: [PR] Replacing custom hashmap MetaMethodIndex with standard maps [groovy]

2024-01-03 Thread via GitHub
eric-milles commented on PR #2020: URL: https://github.com/apache/groovy/pull/2020#issuecomment-1875754759 The changes in `MetaClassImpl` look fine. `MetaMethodIndex` does not even load it is so different. Why are the methods deprecated in `MetaMethod` and `ParameterTypes`? Are the

[jira] [Commented] (GROOVY-11263) Analyze dead code

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802269#comment-17802269 ] ASF GitHub Bot commented on GROOVY-11263: - eric-milles commented on PR #2023: U

Re: [PR] GROOVY-11263: Analyze dead code [groovy]

2024-01-03 Thread via GitHub
eric-milles commented on PR #2023: URL: https://github.com/apache/groovy/pull/2023#issuecomment-1875712756 > source code is meant for developers to read, and the less redundant code there is, the more developer-friendly it becomes. So now you have a benefit statement that you can put

Re: [PR] make use of Runtime.version().feature() [groovy]

2024-01-03 Thread via GitHub
blackdrag commented on PR #2019: URL: https://github.com/apache/groovy/pull/2019#issuecomment-1875685712 > > @blackdrag Did you want to update the PR with the error case when class loader resolving is turned off? If so, then +1 from me. > > Yes, I will update it, but it may take a wee

[jira] [Commented] (GROOVY-11261) Provide a custom type checker for format strings

2024-01-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802054#comment-17802054 ] ASF GitHub Bot commented on GROOVY-11261: - paulk-asert opened a new pull reques