Re: [MPTCP] [PATCH net 2/2] mptcp: better msk-level shutdown.

: refine MPTCP-level ack scheduling") Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 62 1 file changed, 17 insertions(+), 45 deletions(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel

Re: [MPTCP] [PATCH net 1/2] mptcp: more strict state checking for acks

fine MPTCP-level ack scheduling") Fixes: fd8976790a6c ("mptcp: be careful on MPTCP-level ack.") Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel

[PATCH net-next 03/11] mptcp: add port support for ADD_ADDR suboption writing

'port' in mptcp_out_options. When this field is set with a port number, we need to add up 4 octets for the ADD_ADDR suboption, and put the port number into the suboption. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- include/net/mptcp.h | 1 + net/mptcp/optio

[PATCH net-next 05/11] mptcp: add the outgoing ADD_ADDR port support

ck whether the announced address is added with port. If it is, we put this port number to mptcp_out_options's port field. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/options.c | 10 +++--- net/mptcp/pm.c | 5 +++-- net/mptcp/protocol.h | 12 ++

[PATCH net-next 06/11] mptcp: send out dedicated packet for ADD_ADDR using port

From: Geliang Tang The process is similar to that of the ADD_ADDR IPv6, this patch also sent out a pure ack for the ADD_ADDR using port. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/options.c| 3 ++- net/mptcp/pm.c | 3 ++- net/mptcp/pm_netlink.c | 14

[PATCH net-next 04/11] mptcp: use adding up size to get ADD_ADDR length

From: Geliang Tang This patch uses adding up size to get the ADD_ADDR suboption length rather than returning the ADD_ADDR size constants. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/protocol.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

[PATCH net-next 08/11] mptcp: print out port and ahmac when receiving ADD_ADDR

From: Geliang Tang This patch printed out more debugging information for the ADD_ADDR suboption parsing on the incoming path. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/options.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/mptcp

[PATCH net-next 07/11] mptcp: add port parameter for mptcp_pm_announce_addr

From: Geliang Tang This patch added a new parameter 'port' for mptcp_pm_announce_addr. If this parameter is true, we set the MPTCP_ADD_ADDR_PORT bit of the add_addr_signal. That means the announced address is added with a port number. Signed-off-by: Geliang Tang Signed-off-by: Mat

[PATCH net-next 09/11] mptcp: drop rm_addr_signal flag

From: Geliang Tang This patch reused add_addr_signal for the RM_ADDR announcing signal, by defining a new ADD_ADDR status named MPTCP_RM_ADDR_SIGNAL. Then the flag rm_addr_signal in PM could be dropped. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/pm.c | 18

[PATCH net-next 10/11] mptcp: rename add_addr_signal and mptcp_add_addr_status

liang Tang Signed-off-by: Mat Martineau --- net/mptcp/pm.c | 14 +++--- net/mptcp/pm_netlink.c | 4 ++-- net/mptcp/protocol.h | 14 +++--- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/net/mptcp/pm.c b/net/mptcp/pm.c index b5a0b8d231c6..da2ed576f289 1

[PATCH net-next 11/11] mptcp: use the variable sk instead of open-coding

From: Geliang Tang Since the local variable sk has been defined, use it instead of open-coding. Reviewed-by: Matthieu Baerts Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/pm_netlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/mptcp

[PATCH net-next 7/9] mptcp: parse and act on incoming FASTCLOSE option

: Mat Martineau --- net/mptcp/options.c | 17 + net/mptcp/protocol.c | 33 + net/mptcp/protocol.h | 4 3 files changed, 54 insertions(+) diff --git a/net/mptcp/options.c b/net/mptcp/options.c index 1ca60d9da3ef..5e7d7755d1a6 100644 --- a/net

[PATCH net-next 9/9] mptcp: let MPTCP create max size skbs

TCP_STREAM [...] 131072 16384 1638430.0528357.69 Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index cb8b7adf218a..b812aaae8044

[PATCH net-next 6/9] tcp: parse mptcp options contained in reset packets

TCP resets. In the latter case, its needed to parse mptcp options also for reset packets so that MPTCP can act accordingly. Next patch will add receive side fastclose support in MPTCP. Acked-by: Matthieu Baerts Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- include/net/tcp.h

[PATCH net-next 8/9] mptcp: pm: simplify select_local_address()

From: Paolo Abeni There is no need to unconditionally acquire the join list lock, we can simply splice the join list into the subflow list and traverse only the latter. Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/pm_netlink.c | 6 ++ 1 file changed, 2 insertions

[PATCH net-next 0/9] mptcp: Another set of miscellaneous MPTCP fixes

This is another collection of MPTCP fixes and enhancements that we have tested in the MPTCP tree: Patch 1 cleans up cgroup attachment for in-kernel subflow sockets. Patches 2 and 3 make sure that deletion of advertised addresses by an MPTCP path manager when flushing all addresses behaves similar

[PATCH net-next 1/9] mptcp: attach subflow socket to parent cgroup

e kworker. This is why we have to do low level memcg manipulation, if required. Suggested-by: Matthieu Baerts Suggested-by: Paolo Abeni Acked-by: Matthieu Baerts Signed-off-by: Nicolas Rybowski Signed-off-by: Mat Martineau --- net/mptcp/subflow.c | 27 +++ 1 file c

[PATCH net-next 2/9] mptcp: remove address when netlink flushes addrs

olo Abeni Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/pm_netlink.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c index 5151cfcd6962..9cc4eefaf080 100644 --- a/net/mptcp/pm_netlink.c ++

[PATCH net-next 5/9] mptcp: hold mptcp socket before calling tcp_done

From: Florian Westphal When processing options from tcp reset path its possible that tcp_done(ssk) drops the last reference on the mptcp socket which results in use-after-free. Reviewed-by: Matthieu Baerts Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/subflow.c

[PATCH net-next 4/9] mptcp: use MPTCPOPT_HMAC_LEN macro

From: Geliang Tang Use the macro MPTCPOPT_HMAC_LEN instead of a constant in struct mptcp_options_received. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/protocol.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/protocol.h b/net/mptcp

[PATCH net-next 3/9] selftests: mptcp: add the flush addrs testcase

Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- .../testing/selftests/net/mptcp/mptcp_join.sh | 50 +-- 1 file changed, 36 insertions(+), 14 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh

Re: [MPTCP][PATCH net-next] mptcp: clear use_ack and use_map when dropping other suboptions

it can be resubmitted as [PATCH net]. In any case, the content is good: Reviewed-by: Mat Martineau -- Mat Martineau Intel

Re: [PATCH net 1/4] mptcp: fix security context on server socket

oming connections") Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by: Mat Martineau -- Mat Martineau Intel

Re: [PATCH net 2/4] mptcp: properly annotate nested lock

("mptcp: refactor shutdown and close") Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel

Re: [PATCH net-next 1/6] mptcp: open code mptcp variant for lock_sock

| 2 +- net/mptcp/protocol.h | 13 + 3 files changed, 15 insertions(+), 1 deletion(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel

Re: [PATCH net-next 2/6] mptcp: implement wmem reservation

: Mat Martineau -- Mat Martineau Intel

Re: [PATCH net-next 3/6] mptcp: protect the rx path with the msk socket spinlock

net/mptcp/protocol.c | 149 +-- net/mptcp/protocol.h | 5 ++ 2 files changed, 107 insertions(+), 47 deletions(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel

Re: [PATCH net-next 4/6] mptcp: allocate TX skbs in msk context

make possible the later patches. Acked-by: Florian Westphal Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 248 --- net/mptcp/protocol.h | 4 +- 2 files changed, 210 insertions(+), 42 deletions(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel

Re: [PATCH net-next 6/6] mptcp: use mptcp release_cb for delayed tasks

+-- 4 files changed, 168 insertions(+), 117 deletions(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel

Re: [PATCH net-next 5/6] mptcp: avoid a few atomic ops in the rx path

/mptcp_diag.c | 2 +- net/mptcp/options.c| 33 + net/mptcp/protocol.c | 34 -- net/mptcp/protocol.h | 8 4 files changed, 34 insertions(+), 43 deletions(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel

Re: [MPTCP] [PATCH net-next 3/3] mptcp: emit tcp reset when a join request fails

ile changed, 36 insertions(+), 11 deletions(-) Thanks for the patch, Florian. Hopefully the first two in the series are ok with those maintainers, and for this one I can add: Reviewed-by: Mat Martineau -- Mat Martineau Intel

Re: [PATCH net-next] mptcp: avoid potential infinite loop in mptcp_recvmsg()

Signed-off-by: Eric Dumazet Cc: Paolo Abeni --- net/mptcp/protocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks for catching this Eric. Reviewed-by: Mat Martineau -- Mat Martineau Intel

[PATCH net-next 00/11] mptcp: Add port parameter to ADD_ADDR option

The ADD_ADDR MPTCP option is used to announce available IP addresses that a peer may connect to when adding more TCP subflows to an existing MPTCP connection. There is an optional port number field in that ADD_ADDR header, and this patch set adds capability for that port number to be sent and recei

[PATCH net-next 01/11] mptcp: unify ADD_ADDR and echo suboptions writing

, to unify ADD_ADDR and ADD_ADDR echo suboptions writing. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/options.c | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/net/mptcp/options.c b/net/mptcp/options.c index b6

[PATCH net-next 02/11] mptcp: unify ADD_ADDR and ADD_ADDR6 suboptions writing

From: Geliang Tang The length of ADD_ADDR6 is 12 octets longer than ADD_ADDR. That's the only difference between them. This patch dropped the duplicate code between ADD_ADDR and ADD_ADDR6 suboptions writing, and unify them into one. Signed-off-by: Geliang Tang Signed-off-by: Mat Mart

Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required.

: d9ca1de8c0cd ("mptcp: move page frag allocation in mptcp_sendmsg()") Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Mat Martineau -- Mat Martineau Intel

[PATCH net-next 04/10] selftests: mptcp: add link failure test case

Signed-off-by: Mat Martineau --- .../testing/selftests/net/mptcp/mptcp_join.sh | 104 ++ 1 file changed, 82 insertions(+), 22 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh index 0d93b243695f

[PATCH net-next 08/10] selftests: mptcp: add ADD_ADDR IPv6 test cases

From: Geliang Tang This patch added IPv6 support for do_transfer, and the test cases for ADD_ADDR IPv6. Acked-by: Paolo Abeni Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- .../testing/selftests/net/mptcp/mptcp_join.sh | 70 ++- 1 file changed, 69 insertions

[PATCH net-next 00/10] mptcp: More miscellaneous MPTCP fixes

Here's another batch of fixup and enhancement patches that we have collected in the MPTCP tree. Patch 1 removes an unnecessary flag and related code. Patch 2 fixes a bug encountered when closing fallback sockets. Patches 3 and 4 choose a better transmit subflow, with a self test. Patch 5 adjust

[PATCH net-next 07/10] mptcp: send out dedicated ADD_ADDR packet

, we drop all other MPTCP suboptions in this packet, only put ADD_ADDR suboption in it. Suggested-by: Paolo Abeni Acked-by: Paolo Abeni Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/options.c| 25 ++--- net/mptcp/pm.c | 16

[PATCH net-next 09/10] mptcp: track window announced to peer

this when mptcp options get written to the packet (wire format). For this to work we need to move the write_options call until after stack selected a new tcp window. Acked-by: Paolo Abeni Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- include/net/mptcp.h | 3 ++-

[PATCH net-next 03/10] mptcp: skip to next candidate if subflow has unacked data

mptcp: implement and use MPTCP-level retransmission") Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index a46a542b1766..806c0658e42f 100644 --- a

[PATCH net-next 10/10] mptcp: refine MPTCP-level ack scheduling

() is invoked, a known amount of bytes is going to be consumed soon: we update rcv wnd computation taking them in account. Additionally we need to explicitly trigger tcp_cleanup_rbuf() when recvmsg() consumes a significant amount of the receive buffer. Signed-off-by: Paolo Abeni Signed-off-by: Mat

[PATCH net-next 06/10] mptcp: change add_addr_signal type

From: Geliang Tang This patch changed the 'add_addr_signal' type from bool to char, so that we could encode the addr type there. Suggested-by: Paolo Abeni Acked-by: Paolo Abeni Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/pm.c | 15 +--

[PATCH net-next 02/10] mptcp: fix state tracking for fallback socket

From: Paolo Abeni We need to cope with some more state transition for fallback sockets, or could still end-up moving to TCP_CLOSE too early and avoid spooling some pending data Fixes: e16163b6e2b7 ("mptcp: refactor shutdown and close") Signed-off-by: Paolo Abeni Signed-off-by: Mat

[PATCH net-next 05/10] mptcp: keep unaccepted MPC subflow into join list

the old code: conn_list was manipulated without helding the msk lock in mptcp_stream_accept(). Tested-by: Geliang Tang Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 24 net/mptcp/protocol.h | 9 + net/mptcp/subflow.c | 10

[PATCH net-next 01/10] mptcp: drop WORKER_RUNNING status bit

From: Paolo Abeni Only mptcp_close() can actually cancel the workqueue, no need to add and use this flag. Reviewed-by: Matthieu Baerts Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 8 +--- net/mptcp/protocol.h | 1 - 2 files changed, 1 insertion

Re: [PATCH][next] mptcp: fix a dereference of pointer before msk is null checked.

.org/project/netdev/patch/078a2ef5bdc4e3b2c25ef852461692001f426495.1604976945.git.geliangt...@gmail.com/ Thanks! -- Mat Martineau Intel

[PATCH net-next 6/8] selftests: mptcp: add set_flags command in pm_nl_ctl

-by: Mat Martineau --- tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 87 ++- 1 file changed, 86 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c index b24a2f17d415..abc269e96a07 100644 --- a

[PATCH net-next 7/8] mptcp: add the mibs for MP_PRIO

From: Geliang Tang This patch added the mibs for MP_PRIO, MPTCP_MIB_MPPRIOTX for transmitting of the MP_PRIO suboption, and MPTCP_MIB_MPPRIORX for receiving of it. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/mib.c| 2 ++ net/mptcp/mib.h| 2 ++ net

[PATCH net-next 4/8] mptcp: add the incoming MP_PRIO support

iving subsocket and the backup value. In mptcp_pm_mp_prio_received, get the subflow context according the input subsocket, and change the subflow's backup as the incoming priority value. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/options.c | 15 +++

[PATCH net-next 0/8] MPTCP: Add MP_PRIO support and rework local address IDs

Here are some patches we've merged in the MPTCP tree that are ready for net-next. Patches 1 and 2 rework the assignment of local address IDs to allow them to be assigned by a userspace path manager, and add corresponding self tests. Patches 2-8 add the ability to change subflow priority after a s

[PATCH net-next 1/8] mptcp: add the address ID assignment bitmap

-by: Mat Martineau --- net/mptcp/pm_netlink.c | 72 +++--- 1 file changed, 54 insertions(+), 18 deletions(-) diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c index a6d983d80576..7fe7be4eef7e 100644 --- a/net/mptcp/pm_netlink.c +++ b/net/mptcp

[PATCH net-next 3/8] mptcp: add the outgoing MP_PRIO support

t_options's backup, and change the option type to OPTION_MPTCP_PRIO. In mptcp_write_options, clear the send_mp_prio flag and send out the MP_PRIO suboption with mptcp_out_options's backup value. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau

[PATCH net-next 8/8] selftests: mptcp: add the MP_PRIO testcases

ptx[ ok ] - prx [ ok ] Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- .../testing/selftests/net/mptcp/mptcp_join.sh | 72 ++- 1 file changed, 71 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests

[PATCH net-next 5/8] mptcp: add set_flags command in PM netlink

, set or clear the address's FLAG_BACKUP flag. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- include/uapi/linux/mptcp.h | 1 + net/mptcp/pm_netlink.c | 65 ++ 2 files changed, 66 insertions(+) diff --git a/include/uapi/linux/mptcp.h

[PATCH net-next 2/8] selftests: mptcp: add testcases for setting the address ID

From: Geliang Tang Since the address ID can be set from user-space, some of the tests in pm_netlink.sh will fail. This patch fixed the failures, and add the testcases for setting the address ID. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- .../testing/selftests/net/mptcp

Re: [PATCH net] selftests: mptcp: depends on built-in IPv6

df5 ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it") Signed-off-by: Matthieu Baerts --- tools/testing/selftests/net/mptcp/config | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Mat Martineau -- Mat Martineau Intel

Re: [PATCH net] mptcp: add missing memory scheduling in the rx path

("mptcp: update mptcp ack sequence from work queue") Signed-off-by: Paolo Abeni --- net/mptcp/protocol.c | 10 ++ 1 file changed, 10 insertions(+) Reviewed-by: Mat Martineau -- Mat Martineau Intel

[PATCH net-next 5/6] mptcp: add a new sysctl add_addr_timeout

From: Geliang Tang This patch added a new sysctl, named add_addr_timeout, to control the timeout value (in seconds) of the ADD_ADDR retransmission. Suggested-by: Matthieu Baerts Suggested-by: Paolo Abeni Acked-by: Paolo Abeni Reviewed-by: Matthieu Baerts Signed-off-by: Geliang Tang --- net

[PATCH net-next 4/6] mptcp: split mptcp_clean_una function

From: Florian Westphal mptcp_clean_una() will wake writers in case memory could be reclaimed. When called from mptcp_sendmsg the wakeup code isn't needed. Move the wakeup to a new helper and then use that from the mptcp worker. Reviewed-by: Mat Martineau Signed-off-by: Florian Wes

[PATCH net-next 3/6] tcp: propagate MPTCP skb extensions on xmit splits

reader. Reviewed-by: Mat Martineau Signed-off-by: Paolo Abeni --- include/net/mptcp.h | 21 - net/ipv4/tcp_output.c | 3 +++ net/mptcp/protocol.c | 7 +-- 3 files changed, 28 insertions(+), 3 deletions(-) diff --git a/include/net/mptcp.h b/include/net/mptcp.h index

[PATCH net-next 1/6] mptcp: adjust mptcp receive buffer limit if subflow has larger one

ase. Reviewed-by: Mat Martineau Signed-off-by: Florian Westphal --- net/mptcp/protocol.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index e7419fd15d84..e010ef7585bf 100644 --- a/net/mptcp/protocol.c ++

[PATCH net-next 6/6] selftests: mptcp: add ADD_ADDR timeout test case

From: Geliang Tang This patch added the test case for retransmitting ADD_ADDR when timeout occurs. It set NS1's add_addr_timeout to 1 second, and drop NS2's ADD_ADDR echo packets. Here we need to slow down the transfer process of all data to let the ADD_ADDR suboptions can be retransmitted three

[PATCH net-next 2/6] mptcp: use _fast lock version in __mptcp_move_skbs

From: Florian Westphal The function is short and won't sleep, so this can use the _fast version. Acked-by: Paolo Abeni Reviewed-by: Mat Martineau Signed-off-by: Florian Westphal --- net/mptcp/protocol.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/

[PATCH net-next 0/6] mptcp: Miscellaneous MPTCP fixes

This is a collection of small fixup and minor enhancement patches that have accumulated in the MPTCP tree while net-next was closed. These are prerequisites for larger changes we have queued up. Patch 1 refines receive buffer autotuning. Patches 2 and 4 are some minor locking and refactoring chan

Re: [PATCH net-next 5/6] mptcp: add a new sysctl add_addr_timeout

On Mon, 2 Nov 2020, Jakub Kicinski wrote: On Fri, 30 Oct 2020 15:45:05 -0700 Mat Martineau wrote: From: Geliang Tang This patch added a new sysctl, named add_addr_timeout, to control the timeout value (in seconds) of the ADD_ADDR retransmission. Please document the new sysctl. Thanks

[PATCH net-next v2 6/7] docs: networking: mptcp: Add MPTCP sysctl entries

Describe the two MPTCP sysctls, what the values mean, and the default settings. Acked-by: Geliang Tang Signed-off-by: Mat Martineau --- Documentation/networking/index.rst| 1 + Documentation/networking/mptcp-sysctl.rst | 26 +++ MAINTAINERS

[PATCH net-next v2 3/7] tcp: propagate MPTCP skb extensions on xmit splits

reader. Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- include/net/mptcp.h | 21 - net/ipv4/tcp_output.c | 3 +++ net/mptcp/protocol.c | 7 +-- 3 files changed, 28 insertions(+), 3 deletions(-) diff --git a/include/net/mptcp.h b/include/net/mptcp.h

[PATCH net-next v2 5/7] mptcp: add a new sysctl add_addr_timeout

-off-by: Mat Martineau --- net/mptcp/ctrl.c | 14 ++ net/mptcp/pm_netlink.c | 8 ++-- net/mptcp/protocol.h | 1 + 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/net/mptcp/ctrl.c b/net/mptcp/ctrl.c index 54b888f94009..96ba616f59bf 100644 --- a/net/mptcp

[PATCH net-next v2 4/7] mptcp: split mptcp_clean_una function

From: Florian Westphal mptcp_clean_una() will wake writers in case memory could be reclaimed. When called from mptcp_sendmsg the wakeup code isn't needed. Move the wakeup to a new helper and then use that from the mptcp worker. Signed-off-by: Florian Westphal Signed-off-by: Mat Mart

[PATCH net-next v2 7/7] selftests: mptcp: add ADD_ADDR timeout test case

nfig" file. Suggested-by: Matthieu Baerts Suggested-by: Paolo Abeni Acked-by: Paolo Abeni Reviewed-by: Matthieu Baerts Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- tools/testing/selftests/net/mptcp/config | 10 ++ .../testing/selftests/net/mptcp/mptcp_join.sh | 9

[PATCH net-next v2 1/7] mptcp: adjust mptcp receive buffer limit if subflow has larger one

ase. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index e7419fd15d84..e010ef7585bf 100644 --- a/net/mptcp/protocol.c ++

[PATCH net-next v2 2/7] mptcp: use _fast lock version in __mptcp_move_skbs

From: Florian Westphal The function is short and won't sleep, so this can use the _fast version. Acked-by: Paolo Abeni Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/

[PATCH net-next v2 0/7] mptcp: Miscellaneous MPTCP fixes

subflow has larger one mptcp: use _fast lock version in __mptcp_move_skbs mptcp: split mptcp_clean_una function Geliang Tang (2): mptcp: add a new sysctl add_addr_timeout selftests: mptcp: add ADD_ADDR timeout test case Mat Martineau (1): docs: networking: mptcp: Add MPTCP sysctl entries

Re: [PATCH net-next v3] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

0 [ 61.258717] R10: R11: 0293 R12: [ 61.258722] R13: 7ffc85e90fd0 R14: 00007ffc85e90fcc R15: -- Mat Martineau Intel

[PATCH net 1/6] mptcp: deliver ssk errors to msk

()/release_callback() schema. Fixes: 6e628cd3a8f7 ("mptcp: use mptcp release_cb for delayed tasks") Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 7 +++ net/mptcp/protocol.h | 4 net/mptcp/subflow.c | 43

[PATCH net 0/6] mptcp: Miscellaneous fixes

Here are some MPTCP fixes for the -net tree, addressing various issues we have seen thanks to syzkaller and other testing: Patch 1 correctly propagates errors at connection time and for TCP fallback connections. Patch 2 sets the expected poll() events on SEND_SHUTDOWN. Patch 3 fixes a retranmit

[PATCH net 2/6] mptcp: fix poll after shutdown

From: Paolo Abeni The current mptcp_poll() implementation gives unexpected results after shutdown(SEND_SHUTDOWN) and when the msk status is TCP_CLOSE. Set the correct mask. Fixes: 8edf08649eed ("mptcp: rework poll+nospace handling") Signed-off-by: Paolo Abeni Signed-off-by: Mat

[PATCH net 3/6] mptcp: fix spurious retransmissions

ease_cb for delayed tasks") Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 3 +-- net/mptcp/protocol.h | 11 ++- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 42ca49954bdd..c11

[PATCH net 5/6] mptcp: better msk receive window updates

) we can use instead 'rmem_released'. Fixes: ea4ca586b16f ("mptcp: refine MPTCP-level ack scheduling") Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/options.c | 7 --- net/mptcp/protocol.c | 38 ++ net/mptcp/protocol.h

[PATCH net 6/6] mptcp: add a missing retransmission timer scheduling

Fixes: 6e628cd3a8f7 ("mptcp: use mptcp release_cb for delayed tasks") Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/options.c | 3 +-- net/mptcp/protocol.c | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/mptcp/options.c b/net/mptcp/

[PATCH net 4/6] mptcp: init mptcp request socket earlier

t_req' and 'route_req' functions") Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- net/mptcp/subflow.c | 40 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index 0ec3ccac6

[PATCH net-next 0/4] mptcp: Selftest enhancement and fixes

This is a collection of selftest updates from the MPTCP tree. Patch 1 uses additional 'ss' command line parameters and 'nstat' to improve output when certain MPTCP tests fail. Patches 2 & 3 fix a copy/paste error and some output formatting. Patch 4 makes sure tests still pass if certain connecti

[PATCH net-next 1/4] selftests: mptcp: dump more info on errors

dump them. Signed-off-by: Paolo Abeni Signed-off-by: Mat Martineau --- .../testing/selftests/net/mptcp/mptcp_connect.sh | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/

[PATCH net-next 2/4] selftests: mptcp: fix ACKRX debug message

From: Matthieu Baerts Info from received MPCapable SYN were printed instead of the ones from received MPCapable 3rd ACK. Fixes: fed61c4b584c ("selftests: mptcp: make 2nd net namespace use tcp syn cookies unconditionally") Signed-off-by: Matthieu Baerts Signed-off-by: Mat Martineau

[PATCH net-next 3/4] selftests: mptcp: display warnings on one line

short the warning. Signed-off-by: Matthieu Baerts Signed-off-by: Mat Martineau --- .../selftests/net/mptcp/mptcp_connect.sh | 63 --- 1 file changed, 40 insertions(+), 23 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing

[PATCH net-next 4/4] selftests: mptcp: fail if not enough SYN/3rd ACK

d. Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/148 Signed-off-by: Matthieu Baerts Signed-off-by: Mat Martineau --- .../selftests/net/mptcp/mptcp_connect.sh | 28 +-- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests

[PATCH net-next 4/8] mptcp: move subflow close loop after sk close check

From: Florian Westphal In case mptcp socket is already dead the entire mptcp socket will be freed. We can avoid the close check in this case. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH net-next 0/8] mptcp: Add genl events for connection info

This series from the MPTCP tree adds genl multicast events that are important for implementing a userspace path manager. In MPTCP, a path manager is responsible for adding or removing additional subflows on each MPTCP connection. The in-kernel path manager (already part of the kernel) is a better f

[PATCH net-next 5/8] mptcp: pass subflow socket to a few helpers

From: Florian Westphal Pass the first/initial subflow to the existing functions so they can pass this on to the notification handler that is added later in the series. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/options.c | 2 +- net/mptcp/pm.c | 4

[PATCH net-next 1/8] mptcp: move pm netlink work into pm_netlink

From: Florian Westphal Allows to make some functions static and avoids acquire of the pm spinlock in protocol.c. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/pm_netlink.c | 45 +- net/mptcp/protocol.c | 33

[PATCH net-next 2/8] mptcp: split __mptcp_close_ssk helper

the close notification, __mptcp_close_ssk will not. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/pm_netlink.c | 4 ++-- net/mptcp/protocol.c | 12 +--- net/mptcp/protocol.h | 4 ++-- 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/net

[PATCH net-next 6/8] mptcp: avoid lock_fast usage in accept path

From: Florian Westphal Once event support is added this may need to allocate memory while msk lock is held with softirqs disabled. Not using lock_fast also allows to do the allocation with GFP_KERNEL. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 5

[PATCH net-next 3/8] mptcp: schedule worker when subflow is closed

tphal Signed-off-by: Mat Martineau --- net/mptcp/protocol.c | 4 net/mptcp/subflow.c | 25 +++-- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 3fd8aef979a3..267c5521692d 100644 --- a/net/mptcp/proto

[PATCH net-next 8/8] mptcp: add netlink event support

and close of subflows (joins) 3. announce and withdrawals of addresses 4. subflow priority (backup/non-backup) change. Reviewed-by: Matthieu Baerts Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- include/uapi/linux/mptcp.h | 74 +++ net/mptcp/pm.c | 20

[PATCH net-next] mptcp: add local addr info in mptcp_info

From: Geliang Tang Add mptcpi_local_addr_used and mptcpi_local_addr_max in struct mptcp_info. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- include/uapi/linux/mptcp.h | 2 ++ net/mptcp/mptcp_diag.c | 2 ++ net/mptcp/pm_netlink.c | 3 ++- net/mptcp/protocol.h | 1

Re: [PATCH net-next 0/8] mptcp: Add genl events for connection info

On Fri, 12 Feb 2021, Mat Martineau wrote: This series from the MPTCP tree adds genl multicast events that are important for implementing a userspace path manager. In MPTCP, a path manager is responsible for adding or removing additional subflows on each MPTCP connection. The in-kernel path

Re: [PATCH net-next 0/8] mptcp: Add genl events for connection info

On Fri, 12 Feb 2021, Mat Martineau wrote: On Fri, 12 Feb 2021, Mat Martineau wrote: This series from the MPTCP tree adds genl multicast events that are important for implementing a userspace path manager. In MPTCP, a path manager is responsible for adding or removing additional subflows on

[PATCH net-next 00/13] MPTCP: Cleanup and address advertisement fixes

This patch series contains cleanup and fixes we have been testing in the MPTCP tree. MPTCP uses TCP option headers to advertise additional address information after an initial connection is established. The main fixes here deal with making those advertisements more reliable and improving the way su

  1   2   3   4   5   >