Re: [PATCH net-next v5 0/9] net: add support for IPv6 Segment Routing

2016-11-10 Thread David Lebrun
On 11/10/2016 02:40 AM, David Miller wrote: > Series applied, but I wonder if using a Kconfig knob for the INLINE thing > is overkill. Thanks :) The Kconfig knob was a response to the concern that direct header insertion breaks things. Moreover, if the IETF decides that direct header insertion mu

Re: [PATCH net-next v5 0/9] net: add support for IPv6 Segment Routing

2016-11-10 Thread Lorenzo Colitti
On Thu, Nov 10, 2016 at 10:40 AM, David Miller wrote: > > Series applied, but I wonder if using a Kconfig knob for the INLINE thing > is overkill. This breaks IPv6 completely if CONFIG_LWTUNNEL is disabled. When that happens, seg6_iptunnel_init fails with EOPNOTSUPP and the stack fails to initial

Re: [PATCH net-next v5 0/9] net: add support for IPv6 Segment Routing

2016-11-10 Thread David Lebrun
On 11/10/2016 09:35 AM, Lorenzo Colitti wrote: > Not sure how to fix this. The following makes IPv6 work again, but I > suspect it mostly defeats the purpose of having SRH on by default: > > +#ifdef CONFIG_LWTUNNEL > err = seg6_iptunnel_init(); > if (err) > goto

Re: [Xen PATCH] xen-netback: fix error handling output

2016-11-10 Thread Juergen Gross
On 08/11/16 14:34, Arnd Bergmann wrote: > The connect function prints an unintialized error code after an > earlier initialization was removed: > > drivers/net/xen-netback/xenbus.c: In function 'connect': > drivers/net/xen-netback/xenbus.c:938:3: error: 'err' may be used > uninitialized in this f

Re: [PATCH net-next v5 0/9] net: add support for IPv6 Segment Routing

2016-11-10 Thread Lorenzo Colitti
On Thu, Nov 10, 2016 at 6:09 PM, David Lebrun wrote: > Oops. The easiest fix I can think of is adding an option to > enable/disable seg6's LWT which would select CONFIG_LWTUNNEL. That would > still let the core SR processing be enabled by default. So you'd split SRH functionality in three parts?

Re: [PATCH net-next v5 0/9] net: add support for IPv6 Segment Routing

2016-11-10 Thread David Lebrun
On 11/10/2016 10:14 AM, Lorenzo Colitti wrote: > So you'd split SRH functionality in three parts? Core (default on), > lwtunnel (default off) and inline? > > It seems to me that once you've done the work to enable the core code > to work when CONFIG_LWTUNNEL is off, you can just enable/disable the

Re: [PATCH net-next v5 0/9] net: add support for IPv6 Segment Routing

2016-11-10 Thread Lorenzo Colitti
On Thu, Nov 10, 2016 at 6:26 PM, David Lebrun wrote: > That would be easier indeed, but then this behavior should be documented > somewhere: how the user would know that it has to enable CONFIG_LWTUNNEL ? True. I guess whether that question is important or not depends on how many kernels enable

Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr

2016-11-10 Thread Corinna Vinschen
On Nov 8 11:33, Alexander Duyck wrote: > On Tue, Nov 8, 2016 at 10:37 AM, Corinna Vinschen wrote: > > On Nov 8 09:16, Hisashi T Fujinaka wrote: > >> On Tue, 8 Nov 2016, Corinna Vinschen wrote: > >> > On Nov 8 15:06, Cao jin wrote: > >> > > When running as guest, under certain condition, it will

Re: [v16, 0/7] Fix eSDHC host version register bug

2016-11-10 Thread Geert Uytterhoeven
Hi Ulf, On Wed, Nov 9, 2016 at 7:27 PM, Ulf Hansson wrote: > On 9 November 2016 at 04:14, Yangbo Lu wrote: >> This patchset is used to fix a host version register bug in the >> T4240-R1.0-R2.0 >> eSDHC controller. To match the SoC version and revision, 15 previous version >> patchsets had tried

Re: [PATCH net-next v2 2/7] vxlan: simplify exception handling

2016-11-10 Thread Jiri Benc
On Wed, 9 Nov 2016 19:33:24 -0800, Pravin Shelar wrote: > I have moved the dst error handling to vxlan_build_skb(), which is > releasing the dst entry. Hmm, right, I missed that. But it's weird. The previous logic was confusing (skb is freed in case of error but not otherwise), I'm with you on thi

[PATCH net-next] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-10 Thread David Lebrun
This patch compiles SR lwtunnels support only if CONFIG_LWTUNNEL=y. If IPv6 is enabled and CONFIG_LWTUNNEL=n, then seg6_iptunnel_init() fails with EOPNOTSUPP which in turn makes seg6_init() fail, blocking the IPv6 initialization, with the following messages: NET: Registered protocol family 10 IPv

Re: [PATCH net-next v2 4/7] vxlan: improve vxlan route lookup checks.

2016-11-10 Thread Jiri Benc
On Wed, 9 Nov 2016 19:34:06 -0800, Pravin Shelar wrote: > Why it would not help in non-ovs vxlan egress path? It avoids checking > (if condition) for device loop. I may be missing something but I count the same number of conditions for each packet, they're just at a different place after the patch

Re: [PATCH net-next v2 6/7] vxlan: simplify vxlan xmit

2016-11-10 Thread Jiri Benc
On Wed, 9 Nov 2016 19:35:00 -0800, Pravin Shelar wrote: > On Wed, Nov 9, 2016 at 8:59 AM, Jiri Benc wrote: > > Uninitialized old_iph. > > > It is initialized in begining of this function. Right you are, sorry. > TOS and TTL is initialized for LWT just else block. so I do not see > any changes co

RE: [v16, 0/7] Fix eSDHC host version register bug

2016-11-10 Thread Y.B. Lu
> -Original Message- > From: [email protected] [mailto:linux-mmc- > [email protected]] On Behalf Of Scott Wood > Sent: Thursday, November 10, 2016 11:55 AM > To: Ulf Hansson; Y.B. Lu > Cc: linux-mmc; Arnd Bergmann; [email protected]; > [email protected]

Re: [net-next PATCH] amd-xgbe: use __maybe_unused to hide pm functions

2016-11-10 Thread Arnd Bergmann
On Wednesday, November 9, 2016 8:32:51 PM CET David Miller wrote: > From: Arnd Bergmann > Date: Tue, 8 Nov 2016 14:37:32 +0100 > > > The amd-xgbe ethernet driver hides its suspend/resume functions > > in #ifdef CONFIG_PM, but uses SIMPLE_DEV_PM_OPS() to make the > > reference conditional on CONF

Re: [Regression w/ patch] Restore network resistance to weird ICMP messages

2016-11-10 Thread Vicente Jiménez
Corrected patch attached. Thanks for the advices. I was unaware of those style policies. On Thu, Nov 10, 2016 at 2:22 AM, David Miller wrote: > From: Vicente Jiménez > Date: Mon, 7 Nov 2016 12:11:59 +0100 > >> From bfc9a00e6b78d8eb60e46dacd7d761669d29a573 Mon Sep 17 00:00:00 2001 >> From: Vicent

[patch net 0/2] mlxsw: Couple of router fixes

2016-11-10 Thread Jiri Pirko
From: Jiri Pirko Jiri Pirko (2): mlxsw: spectrum_router: Fix handling of neighbour structure mlxsw: spectrum_router: Ignore FIB notification events for non-init namespaces .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 98 -- 1 file changed, 37 insertions(+), 6

[patch net 1/2] mlxsw: spectrum_router: Fix handling of neighbour structure

2016-11-10 Thread Jiri Pirko
From: Jiri Pirko __neigh_create function works in a different way than assumed. It passes "n" as a parameter to ndo_neigh_construct. But this "n" might be destroyed right away before __neigh_create() returns in case there is already another neighbour struct in the hashtable with the same dev and

[patch net 2/2] mlxsw: spectrum_router: Ignore FIB notification events for non-init namespaces

2016-11-10 Thread Jiri Pirko
From: Jiri Pirko Since now, the table with same id in multiple netnamespaces were squashed to a single virtual router. That is not only incorrect, it also causes error messages when trying to use RALUE register to do double remove of FIB entries, like this one: mlxsw_spectrum :03:00.0: EMAD

[patch net-next] mlxsw: spectrum_router: Add FIB abort warning

2016-11-10 Thread Jiri Pirko
From: Jiri Pirko Add a warning that the abort mechanism was triggered for device. Also avoid going through the procedure if abort was already done. Signed-off-by: Jiri Pirko Acked-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 3 +++ 1 file changed, 3 insertions(

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-10 Thread Bjørn Mork
Kai-Heng Feng writes: > On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: >> Oliver Neukum writes: >> >>> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: >>> These problems could very well be caused by running at SuperSpeed (USB-3) instead of high speed (USB-2). > > Yes, it's runn

Re: [PATCH net-next] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-10 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/David-Lebrun/ipv6-sr-fix-IPv6-initialization-failure-without-lwtunnels/20161110-175753 config: i386-randconfig-s1-201645 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

[PATCH] net: bpqether.h: remove if_ether.h guard

2016-11-10 Thread Baruch Siach
__LINUX_IF_ETHER_H is not defined anywhere, and if_ether.h can keep itself from double inclusion, though it uses a single underscore prefix. Signed-off-by: Baruch Siach --- include/uapi/linux/bpqether.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/uapi/linux/bpqether.h b/include/

[patch net-next 1/8] Introduce ife encapsulation module

2016-11-10 Thread Jiri Pirko
From: Yotam Gigi This module is responsible for the ife encapsulation protocol encode/decode logics. That module can: - ife_encode: encode skb and reserve space for the ife meta header - ife_decode: decode skb and extract the meta header size - ife_tlv_meta_encode - encodes one tlv entry into

[patch net-next 4/8] net: ife: Introduce packet info packing method

2016-11-10 Thread Jiri Pirko
From: Yotam Gigi Add the ife_packet_info_pack function which encodes some informative metadata into a packet using the ife encapsulation. The informative metadata consists of: - The packet input/output ifindices - The packet original size, in case it was truncated This method is useful for any

[patch net-next 0/8] Add support for offloading packet-sampling

2016-11-10 Thread Jiri Pirko
From: Jiri Pirko Add the sample tc action, which allows to sample packet matching a classifier. The sample action peeks randomly packets, duplicates them, truncates them and adds informative metadata on the packet, for example, the input interface and the original packet length. The sampled packe

[patch net-next 6/8] tc: sample: Add sequence number and sampler_id fields

2016-11-10 Thread Jiri Pirko
From: Yotam Gigi Add support for sequence numbering to the sampled packets. The sequence number counts the sampled packets and enables to check whether sampled packets have been dropped. The sequence state is kept per sample action instance. Add unique id (sampler_id) for each sample action inst

[patch net-next 8/8] mlxsw: packet sample: Add packet sample offloading support

2016-11-10 Thread Jiri Pirko
From: Yotam Gigi Using the MPSC regiter, add the functions that configure port packets sampling in hardware and the necessary datatypes in the mlxsw_sp_port struct. In addition, add the necessary trap for sampled packets and integrate with matchall offloading to allow offloading of the sample tc

[patch net-next 5/8] Introduce sample tc action

2016-11-10 Thread Jiri Pirko
From: Yotam Gigi This action allow the user to sample traffic matched by tc classifier. The sampling consists of choosing packets randomly, truncating them, adding some informative metadata regarding the interface and the original packet size and mark them with specific mark, to allow further tc

[patch net-next 3/8] net: ife: Introduce new metadata tlv types

2016-11-10 Thread Jiri Pirko
From: Yotam Gigi IFE_META_IN_IFINDEX: Allow to pass input ifindex value as part of the ife metadata IFE_META_OUT_IFINDEX: Allow to pass output ifindex value as part of the ife metadata IFE_META_ORIG_SIZE: Allow to pass the original packet size as part of the ife metadata. Can be used in case that

[patch net-next 7/8] mlxsw: reg: add the Monitoring Packet Sampling Configuration Register

2016-11-10 Thread Jiri Pirko
From: Yotam Gigi The MPSC register allows to configure ingress packet sampling on specific port of the mlxsw device. The sampled packets are then trapped via PKT_SAMPLE trap. Signed-off-by: Yotam Gigi Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 38 +++

[patch net-next 2/8] act_ife: Change to use ife module

2016-11-10 Thread Jiri Pirko
From: Yotam Gigi Use the encode/decode functionality from the ife module instead of using implementation inside the act_ife. Signed-off-by: Yotam Gigi Signed-off-by: Jiri Pirko --- include/net/tc_act/tc_ife.h| 3 - include/uapi/linux/tc_act/tc_ife.h | 10 +--- net/sched/Kconfig

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-10 Thread Oliver Neukum
On Thu, 2016-11-10 at 12:09 +0100, Bjørn Mork wrote: > Kai-Heng Feng writes: > > On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: > >> Oliver Neukum writes: > >> > >>> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: > >>> > These problems could very well be caused by running at SuperS

[patch net v2 1/2] mlxsw: spectrum_router: Fix handling of neighbour structure

2016-11-10 Thread Jiri Pirko
From: Jiri Pirko __neigh_create function works in a different way than assumed. It passes "n" as a parameter to ndo_neigh_construct. But this "n" might be destroyed right away before __neigh_create() returns in case there is already another neighbour struct in the hashtable with the same dev and

[patch net v2 2/2] mlxsw: spectrum_router: Ignore FIB notification events for non-init namespaces

2016-11-10 Thread Jiri Pirko
From: Jiri Pirko Since now, the table with same id in multiple netnamespaces were squashed to a single virtual router. That is not only incorrect, it also causes error messages when trying to use RALUE register to do double remove of FIB entries, like this one: mlxsw_spectrum :03:00.0: EMAD

[patch net v2 0/2] mlxsw: Couple of router fixes

2016-11-10 Thread Jiri Pirko
From: Jiri Pirko --- v1->v2: - patch2: - use net_eq Jiri Pirko (2): mlxsw: spectrum_router: Fix handling of neighbour structure mlxsw: spectrum_router: Ignore FIB notification events for non-init namespaces .../net/ethernet/mellanox/mlxsw/spectrum_router.c | 98 --

Re: [PATCH v9 7/8] thunderbolt: Networking doc

2016-11-10 Thread Greg KH
On Wed, Nov 09, 2016 at 04:20:07PM +0200, Amir Levy wrote: > Adding Thunderbolt(TM) networking documentation. > > Signed-off-by: Amir Levy > --- > Documentation/00-INDEX | 2 + > Documentation/thunderbolt/networking.txt | 132 > +++ Note, new file

Re: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-10 Thread Greg KH
On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote: > This driver enables Thunderbolt Networking on non-Apple platforms > running Linux. > > Thunderbolt Networking provides peer-to-peer connections to transfer > files between computers, perform PC migrations, and/or set up small > workgroup

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-10 Thread Levy, Amir (Jer)
On Wed, Nov 9 2016, 06:02 PM, Greg KH wrote: > On Wed, Nov 09, 2016 at 04:20:00PM +0200, Amir Levy wrote: > > This driver enables Thunderbolt Networking on non-Apple platforms > > running Linux. > > > > Thunderbolt Networking provides peer-to-peer connections to transfer > > files between computers

Re: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-10 Thread Greg KH
On Thu, Nov 10, 2016 at 11:39:19AM +, Levy, Amir (Jer) wrote: > > And how about getting some internal-Intel kernel developers to review and > > sign-off on this code? Don't make the community do the review when you > > have access to resources like this. You have an internal mailing list for

RE: [PATCH v9 7/8] thunderbolt: Networking doc

2016-11-10 Thread Levy, Amir (Jer)
On Wed, Nov 9 2016, 06:00 PM, Greg KH wrote: > On Wed, Nov 09, 2016 at 04:20:07PM +0200, Amir Levy wrote: > > Adding Thunderbolt(TM) networking documentation. > > > > Signed-off-by: Amir Levy > > --- > > Documentation/00-INDEX | 2 + > > Documentation/thunderbolt/networking.tx

RE: [PATCH v9 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

2016-11-10 Thread Levy, Amir (Jer)
On Thu, Nov 10 2016, 01:44 PM, Greg KH wrote: > On Thu, Nov 10, 2016 at 11:39:19AM +, Levy, Amir (Jer) wrote: > > > And how about getting some internal-Intel kernel developers to > > > review and sign-off on this code? Don't make the community do the > > > review when you have access to resour

Re: [PATCH v9 7/8] thunderbolt: Networking doc

2016-11-10 Thread Greg KH
On Thu, Nov 10, 2016 at 11:47:57AM +, Levy, Amir (Jer) wrote: > On Wed, Nov 9 2016, 06:00 PM, Greg KH wrote: > > On Wed, Nov 09, 2016 at 04:20:07PM +0200, Amir Levy wrote: > > > Adding Thunderbolt(TM) networking documentation. > > > > > > Signed-off-by: Amir Levy > > > --- > > > Documentation

Re: [PATCH v3 3/5] net: asix: Fix AX88772x resume failures

2016-11-10 Thread Jon Hunter
Hi Robert, On 29/08/16 14:32, [email protected] wrote: > From: Robert Foss > > From: Allan Chou > > The change fixes AX88772x resume failure by > - Restore incorrect AX88772A PHY registers when resetting > - Need to stop MAC operation when suspending > - Need to restart MII when restor

[PATCH net-next v2] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-10 Thread David Lebrun
v2: fix conditional compilation for seg6_iptunnel.o in Makefile This patch compiles SR lwtunnels support only if CONFIG_LWTUNNEL=y. If IPv6 is enabled and CONFIG_LWTUNNEL=n, then seg6_iptunnel_init() fails with EOPNOTSUPP which in turn makes seg6_init() fail, blocking the IPv6 initialization, wit

Re: [PATCH net-next] ipv6: sr: fix IPv6 initialization failure without lwtunnels

2016-11-10 Thread kbuild test robot
Hi David, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/David-Lebrun/ipv6-sr-fix-IPv6-initialization-failure-without-lwtunnels/20161110-175753 config: i386-randconfig-s0-201645 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

ATENCIÓN;

2016-11-10 Thread Administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de corre

Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr

2016-11-10 Thread Hisashi T Fujinaka
On Thu, 10 Nov 2016, Corinna Vinschen wrote: On Nov 8 11:33, Alexander Duyck wrote: ... The question I would have is what is reading the device when it is in this state. The watchdog and any other functions that would read the device should be disabled. One possibility could be a race betwe

[PATCH] net: phy: marvell: optimize logic for page changing during init

2016-11-10 Thread Uwe Kleine-König
Instead of remembering if the page was changed, just compare the current page to the saved one. This is easier and has the advantage to save a register write if the page was already restored. Signed-off-by: Uwe Kleine-König --- drivers/net/phy/marvell.c | 6 ++ 1 file changed, 2 insertions(+

Re: [PATCH net-next resend 10/13] debugfs: constify argument to debugfs_real_fops()

2016-11-10 Thread Greg Kroah-Hartman
On Thu, Nov 03, 2016 at 05:12:06PM +, Jakub Kicinski wrote: > seq_file users can only access const version of file pointer, > because the ->file member of struct seq_operations is marked > as such. Make parameter to debugfs_real_fops() const. > > CC: Greg Kroah-Hartman > CC: Nicolai Stange

Re: [PATCH v9 7/8] thunderbolt: Networking doc

2016-11-10 Thread Jonathan Corbet
On Wed, 9 Nov 2016 17:00:02 +0100 Greg KH wrote: > > Documentation/00-INDEX | 2 + > > Documentation/thunderbolt/networking.txt | 132 > > +++ > > Note, new files should be in .rst format, and live in the new > subdirectory for them (somewhere i

AF_VSOCK loopback

2016-11-10 Thread Stefan Hajnoczi
Hi Jorgen, Cathy Avery found that the AF_VSOCK VMCI transport does loopback inside the guest (but not on the host?). The virtio transport currently does no loopback. The loopback scenario I'm thinking of is where process A listens on port 1234 and process B on the same machine connects to port 12

Re: [PATCH net-next v5 0/9] net: add support for IPv6 Segment Routing

2016-11-10 Thread David Miller
From: David Lebrun Date: Thu, 10 Nov 2016 09:19:28 +0100 > The Kconfig knob was a response to the concern that direct header > insertion breaks things. Moreover, if the IETF decides that direct > header insertion must be explicitely banned in rfc2460bis, then at > least we do not have a non-RFC c

[PATCH net-next 1/2] net: dsa: mv88e6xxx: Don't modify RGMII delays when not RGMII mode

2016-11-10 Thread Andrew Lunn
The RGMII modes delays can be set via strapping pings or EEPROM. Don't change them unless explicitly asked to change them. The recent refactoring of setting the MAC configuration changed this behaviours, in that CPU and DSA ports have any pre-configured RGMII delays removed. This breaks the Armada

[PATCH net-next 0/2] Fixes for port refactoring

2016-11-10 Thread Andrew Lunn
The patches which refactored setting up the switch MACs introduced a couple of regressions. The RGMII delays for a port can be set using other mechanism than just phy-mode. Don't overwrite the delays unless explicitly asked to. This broke my Armada 370 RD. Also, the mv88e6351 family supports settin

[PATCH net-next 2/2] net: dsa: mv88e6xxx: 6351 family also has RGMII delays

2016-11-10 Thread Andrew Lunn
The recent refactoring of setting the MAC configuration broke setting of RGMII delays, via the phy-mode, on the 6351 family. Add the missing ops to the structure. Fixes: 7340e5ecdbb1 ("net: dsa: mv88e6xxx: setup port's MAC") Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 4 +++

BUG() can be hit in tcp_collapse()

2016-11-10 Thread Vladis Dronov
Hello, It was discovered by Marco Grassi (many thanks) that the latest stable Linux kernel v4.8.6 is crashing in tcp_collapse() after making certain syscalls: [9.622886] kernel BUG at net/ipv4/tcp_input.c:4813! [9.623299] invalid opcode: [#1] SMP [9.623642] Modules linked in: ip

Re: [Regression w/ patch] Restore network resistance to weird ICMP messages

2016-11-10 Thread David Miller
From: Vicente Jiménez Date: Thu, 10 Nov 2016 11:52:01 +0100 > Corrected patch attached. > Thanks for the advices. > I was unaware of those style policies. This is not how to submit a fixed patch. You must make a new, fresh, list posting fully formed and with a clean Subject line and commit mess

Re: nfs NULL-dereferencing in net-next

2016-11-10 Thread Olaf Hering
On Thu, Nov 03, Anna Schumaker wrote: > Aww, I was hoping that patch would work. It still seemed to fix some > issues for me when mounting multiple servers, so I'm planning to keep > it. Unfortunately I'm out of town this week, so I haven't had much of > a chance to keep poking at this issue. I

[PATCH iproute2 1/1] tc: print raw qdisc handle.

2016-11-10 Thread Roman Mashak
Resending patch after fixing indentation and spaces. Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim --- tc/tc_qdisc.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c index 93c9a4c..a8c8386 100644 --- a/tc/tc_qdisc.c +++ b/

Re: nfs NULL-dereferencing in net-next

2016-11-10 Thread Anna Schumaker
On 11/10/2016 09:47 AM, Olaf Hering wrote: > On Thu, Nov 03, Anna Schumaker wrote: > >> Aww, I was hoping that patch would work. It still seemed to fix some >> issues for me when mounting multiple servers, so I'm planning to keep >> it. Unfortunately I'm out of town this week, so I haven't had m

[PATCH net-next v13 8/8] openvswitch: allow L3 netdev ports

2016-11-10 Thread Jiri Benc
Allow ARPHRD_NONE interfaces to be added to ovs bridge. Based on previous versions by Lorand Jakab and Simon Horman. Signed-off-by: Lorand Jakab Signed-off-by: Simon Horman Signed-off-by: Jiri Benc Acked-by: Pravin B Shelar --- net/openvswitch/vport-netdev.c | 9 ++--- 1 file changed, 6

[PATCH net-next v13 4/8] openvswitch: support MPLS push and pop for L3 packets

2016-11-10 Thread Jiri Benc
Update Ethernet header only if there is one. Signed-off-by: Jiri Benc Acked-by: Pravin B Shelar --- net/openvswitch/actions.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index dc8bb97e2258..064cbcb

[PATCH net-next v13 0/8] openvswitch: support for layer 3 encapsulated packets

2016-11-10 Thread Jiri Benc
At the core of this patch set is removing the assumption in Open vSwitch datapath that all packets have Ethernet header. The implementation relies on the presence of pop_eth and push_eth actions in datapath flows to facilitate adding and removing Ethernet headers as appropriate. The construction o

[PATCH net-next v13 6/8] openvswitch: netlink: support L3 packets

2016-11-10 Thread Jiri Benc
Extend the ovs flow netlink protocol to support L3 packets. Packets without OVS_KEY_ATTR_ETHERNET attribute specify L3 packets; for those, the OVS_KEY_ATTR_ETHERTYPE attribute is mandatory. Push/pop vlan actions are only supported for Ethernet packets. Based on previous versions by Lorand Jakab a

[PATCH net-next v13 7/8] openvswitch: add Ethernet push and pop actions

2016-11-10 Thread Jiri Benc
It's not allowed to push Ethernet header in front of another Ethernet header. It's not allowed to pop Ethernet header if there's a vlan tag. This preserves the invariant that L3 packet never has a vlan tag. Based on previous versions by Lorand Jakab and Simon Horman. Signed-off-by: Lorand Jakab

[PATCH net-next v13 2/8] openvswitch: add mac_proto field to the flow key

2016-11-10 Thread Jiri Benc
Use a hole in the structure. We support only Ethernet so far and will add a support for L2-less packets shortly. We could use a bool to indicate whether the Ethernet header is present or not but the approach with the mac_proto field is more generic and occupies the same number of bytes in the struc

[PATCH net-next v13 1/8] openvswitch: use hard_header_len instead of hardcoded ETH_HLEN

2016-11-10 Thread Jiri Benc
On tx, use hard_header_len while deciding whether to refragment or drop the packet. That way, all combinations are calculated correctly: * L2 packet going to L2 interface (the L2 header len is subtracted), * L2 packet going to L3 interface (the L2 header is included in the packet lenght), * L3 p

[PATCH net-next v13 3/8] openvswitch: pass mac_proto to ovs_vport_send

2016-11-10 Thread Jiri Benc
We'll need it to alter packets sent to ARPHRD_NONE interfaces. Change do_output() to use the actual L2 header size of the packet when deciding on the minimum cutlen. The assumption here is that what matters is not the output interface hard_header_len but rather the L2 header of the particular pack

[PATCH net-next v13 5/8] openvswitch: add processing of L3 packets

2016-11-10 Thread Jiri Benc
Support receiving, extracting flow key and sending of L3 packets (packets without an Ethernet header). Note that even after this patch, non-Ethernet interfaces are still not allowed to be added to bridges. Similarly, netlink interface for sending and receiving L3 packets to/from user space is not

Re: BUG() can be hit in tcp_collapse()

2016-11-10 Thread Greg KH
On Thu, Nov 10, 2016 at 09:47:26AM -0500, Vladis Dronov wrote: > Hello, > > It was discovered by Marco Grassi (many thanks) that the > latest stable Linux kernel v4.8.6 is crashing in tcp_collapse() after making > certain syscalls: > > [9.622886] kernel BUG at net/ipv4/tcp_input.c:4813! > [

Re: [PATCH] usbnet: prevent device rpm suspend in usbnet_probe function

2016-11-10 Thread Alan Stern
On Thu, 10 Nov 2016, Kai-Heng Feng wrote: > Hi, > > On Wed, Nov 9, 2016 at 8:32 PM, Bjørn Mork wrote: > > Oliver Neukum writes: > > > >> On Tue, 2016-11-08 at 13:44 -0500, Alan Stern wrote: > >> > >>> These problems could very well be caused by running at SuperSpeed > >>> (USB-3) instead of hig

Re: [PATCH net-next resend 10/13] debugfs: constify argument to debugfs_real_fops()

2016-11-10 Thread Jakub Kicinski
On Thu, 10 Nov 2016 15:25:59 +0100, Greg Kroah-Hartman wrote: > On Thu, Nov 03, 2016 at 05:12:06PM +, Jakub Kicinski wrote: > > seq_file users can only access const version of file pointer, > > because the ->file member of struct seq_operations is marked > > as such. Make parameter to debugfs_

Re: BUG() can be hit in tcp_collapse()

2016-11-10 Thread Eric Dumazet
On Thu, 2016-11-10 at 09:47 -0500, Vladis Dronov wrote: > Hello, > > It was discovered by Marco Grassi (many thanks) that the > latest stable Linux kernel v4.8.6 is crashing in tcp_collapse() after making > certain syscalls: > > [9.622886] kernel BUG at net/ipv4/tcp_input.c:4813! > [9.62

Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower

2016-11-10 Thread Jes Sorensen
Dave Jones writes: > On Fri, Nov 04, 2016 at 09:56:00AM -0400, Jes Sorensen wrote: >> >> Joe Perches writes: >> > On Sun, 2016-10-30 at 19:02 -0400, Jes Sorensen wrote: >> >> Code is 80 characters wide, and comments are /* */ never the ugly C++ >> >> crap. >> > >> > You might look at the recent L

[PATCH iproute2 1/1] tc: improved usage help for fw classifier.

2016-11-10 Thread Roman Mashak
Signed-off-by: Roman Mashak Signed-off-by: Jamal Hadi Salim --- tc/f_fw.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/tc/f_fw.c b/tc/f_fw.c index 29c9854..790bef9 100644 --- a/tc/f_fw.c +++ b/tc/f_fw.c @@ -25,10 +25,19 @@ static void explain(void) {

[PATCH] genetlink: fix unsigned int comparison with less than zero

2016-11-10 Thread Colin King
From: Colin Ian King family->id is unsigned, so the less than zero check for failure return from idr_alloc is never true and so the error exit is never handled. Instead, assign err and check if this is less than zero since this is a signed integer. Issue found with static analysis with Coverity

[PATCH net,v2] ipv4: use new_gw for redirect neigh lookup

2016-11-10 Thread Stephen Suryaputra Lin
In v2.6, ip_rt_redirect() calls arp_bind_neighbour() which returns 0 and then the state of the neigh for the new_gw is checked. If the state isn't valid then the redirected route is deleted. This behavior is maintained up to v3.5.7 by check_peer_redirect() because rt->rt_gateway is assigned to peer

Re: AF_VSOCK loopback

2016-11-10 Thread Cathy Avery
I had trouble with loopback on the esx host. Using the nc-vsock ( AF_VSOCK 56 ) the server and the client connected but they both terminated without error when I attempted to send characters over. It might be due to something other than vsock. I haven't pursued it yet. On 11/10/2016 09:43 AM,

Re: [PATCH] net: ethernet: ti: davinci_cpdma: fix fixed prio cpdma ctlr configuration

2016-11-10 Thread Grygorii Strashko
On 11/09/2016 05:56 PM, Ivan Khoronzhuk wrote: > > > On 09.11.16 23:09, Grygorii Strashko wrote: >> >> >> On 11/08/2016 07:10 AM, Ivan Khoronzhuk wrote: >>> The dma ctlr is reseted to 0 while cpdma start, thus cpdma ctlr >> >> I assume this is because cpdma_ctlr_start() does soft reset. Is it >

Re: [Intel-wired-lan] [PATCH net] igb: re-assign hw address pointer on reset after PCI error

2016-11-10 Thread Guilherme G. Piccoli
On 11/09/2016 03:12 PM, Alexander Duyck wrote: > On Mon, Oct 31, 2016 at 1:12 PM, Guilherme G. Piccoli > wrote: >> Whenever the igb driver detects the result of a read operation returns >> a value composed only by F's (like 0x), it will detach the >> net_device, clear the hw_addr pointer a

Re: [PATCH net-next 00/17] Bug fixes & Code improvements in HNS driver

2016-11-10 Thread David Miller
From: Salil Mehta Date: Wed, 9 Nov 2016 18:13:44 + > This patch-set introduces some bug fixes and code improvements. > These have been identified during internal review or testing of > the driver by internal Hisilicon teams. Series applied, thanks.

Re: [PATCH 1/2] net: mvpp2: don't bring up on MAC address set

2016-11-10 Thread David Miller
From: Baruch Siach Date: Wed, 9 Nov 2016 14:56:33 +0200 > Current .ndo_set_mac_address implementation brings up the interface when > revert > to original address after failure succeeds. Fix this. > > Signed-off-by: Baruch Siach > --- > Untested; I don't have the hardware. The code which upda

Re: [PATCH net-next v5]] cadence: Add LSO support.

2016-11-10 Thread David Miller
From: Rafal Ozieblo Date: Wed, 9 Nov 2016 13:41:02 + First, please remove the spurious closing bracket in your Subject line in future submittions. > + if (is_udp) /* is_udp is only set when (is_lso) is checked */ > + /* zero UDP checksum, not calculated by h/w for UFO */ > +

Re: [PATCH net v2] ipv4: update comment to document GSO fragmentation cases.

2016-11-10 Thread David Miller
From: Lance Richardson Date: Wed, 9 Nov 2016 15:04:39 -0500 > This is a follow-up to commit 9ee6c5dc816a ("ipv4: allow local > fragmentation in ip_finish_output_gso()"), updating the comment > documenting cases in which fragmentation is needed for egress > GSO packets. > > Suggested-by: Shmulik

Re: [PATCH] genetlink: fix unsigned int comparison with less than zero

2016-11-10 Thread Cong Wang
On Thu, Nov 10, 2016 at 7:57 AM, Colin King wrote: > From: Colin Ian King > > family->id is unsigned, so the less than zero check for > failure return from idr_alloc is never true and so the error exit > is never handled. Instead, assign err and check if this is less > than zero since this is a

Re: [PATCH net-next V5 3/9] liquidio CN23XX: Mailbox support

2016-11-10 Thread David Miller
From: Raghu Vatsavayi Date: Wed, 9 Nov 2016 15:13:46 -0800 > + dev_info(&oct->pci_dev->dev, > + "PF changed VF's MAC address to > %02hhx:%02hhx:%02hhx:%02hhx:%02hhx:%02hhx\n", > + mac[0], mac[1], mac[2], mac[3], mac[4], mac[5]); We have a st

[PATCH] debugfs: improve formatting of debugfs_real_fops()

2016-11-10 Thread Jakub Kicinski
Type of debugfs_real_fops() is longer than parameters and the name, so there is no way to break the declaration nicely. We have to go over 80 characters. Signed-off-by: Jakub Kicinski --- include/linux/debugfs.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/

Re: [Intel-wired-lan] [PATCH] igb: use igb_adapter->io_addr instead of e1000_hw->hw_addr

2016-11-10 Thread Corinna Vinschen
On Nov 10 05:48, Hisashi T Fujinaka wrote: > On Thu, 10 Nov 2016, Corinna Vinschen wrote: > > On Nov 8 11:33, Alexander Duyck wrote: > ... > > > The question I would have is what is reading the device when it is in > > > this state. The watchdog and any other functions that would read the > > > d

[mm PATCH v3 23/23] igb: Update code to better handle incrementing page count

2016-11-10 Thread Alexander Duyck
This patch updates the driver code so that we do bulk updates of the page reference count instead of just incrementing it by one reference at a time. The advantage to doing this is that we cut down on atomic operations and this in turn should give us a slight improvement in cycles per packet. In a

[mm PATCH v3 22/23] igb: Update driver to make use of DMA_ATTR_SKIP_CPU_SYNC

2016-11-10 Thread Alexander Duyck
The ARM architecture provides a mechanism for deferring cache line invalidation in the case of map/unmap. This patch makes use of this mechanism to avoid unnecessary synchronization. A secondary effect of this change is that the portion of the page that has been synchronized for use by the CPU sh

[mm PATCH v3 17/23] arch/sparc: Add option to skip DMA sync as a part of map and unmap

2016-11-10 Thread Alexander Duyck
This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to avoid invoking cache line invalidation if the driver will just handle it via a sync_for_cpu or sync_for_device call. Cc: "David S. Miller" Cc: [email protected] Signed-off-by: Alexander Duyck --- arch/sparc/kernel/

[mm PATCH v3 19/23] arch/xtensa: Add option to skip DMA sync as a part of mapping

2016-11-10 Thread Alexander Duyck
This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to avoid invoking cache line invalidation if the driver will just handle it via a sync_for_cpu or sync_for_device call. Cc: Max Filippov Signed-off-by: Alexander Duyck --- arch/xtensa/kernel/pci-dma.c |7 +-- 1 file ch

[mm PATCH v3 21/23] mm: Add support for releasing multiple instances of a page

2016-11-10 Thread Alexander Duyck
This patch adds a function that allows us to batch free a page that has multiple references outstanding. Specifically this function can be used to drop a page being used in the page frag alloc cache. With this drivers can make use of functionality similar to the page frag alloc cache without havi

[mm PATCH v3 18/23] arch/tile: Add option to skip DMA sync as a part of map and unmap

2016-11-10 Thread Alexander Duyck
This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to avoid invoking cache line invalidation if the driver will just handle it via a sync_for_cpu or sync_for_device call. Cc: Chris Metcalf Signed-off-by: Alexander Duyck --- arch/tile/kernel/pci-dma.c | 12 ++-- 1 fil

[mm PATCH v3 20/23] dma: Add calls for dma_map_page_attrs and dma_unmap_page_attrs

2016-11-10 Thread Alexander Duyck
Add support for mapping and unmapping a page with attributes. The primary use for this is currently to allow for us to pass the DMA_ATTR_SKIP_CPU_SYNC attribute when mapping and unmapping a page. On some architectures such as ARM the synchronization has significant overhead and if we are already

[mm PATCH v3 10/23] arch/microblaze: Add option to skip DMA sync as a part of map and unmap

2016-11-10 Thread Alexander Duyck
This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to avoid invoking cache line invalidation if the driver will just handle it via a sync_for_cpu or sync_for_device call. Cc: Michal Simek Signed-off-by: Alexander Duyck --- arch/microblaze/kernel/dma.c | 10 -- 1 file

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-10 Thread Cong Wang
(Cc'ing Paul) On Wed, Nov 9, 2016 at 7:42 AM, Rolf Neugebauer wrote: > Hi > > We noticed some long delays starting docker containers on some newer > kernels (starting with 4.5.x and still present in 4.9-rc4, 4.4.x is > fine). We narrowed this down to the creation of a network namespace > being de

[mm PATCH v3 15/23] arch/powerpc: Add option to skip DMA sync as a part of mapping

2016-11-10 Thread Alexander Duyck
This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to avoid invoking cache line invalidation if the driver will just handle it via a sync_for_cpu or sync_for_device call. Acked-by: Michael Ellerman (powerpc) Signed-off-by: Alexander Duyck --- arch/powerpc/kernel/dma.c |9 +

[mm PATCH v3 07/23] arch/hexagon: Add option to skip DMA sync as a part of mapping

2016-11-10 Thread Alexander Duyck
This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to avoid invoking cache line invalidation if the driver will just handle it later via a sync_for_cpu or sync_for_device call. Cc: Richard Kuo Cc: [email protected] Signed-off-by: Alexander Duyck --- arch/hexagon/ke

  1   2   3   >