From: Baruch Siach <bar...@tkos.co.il> Date: Wed, 9 Nov 2016 14:56:33 +0200
> Current .ndo_set_mac_address implementation brings up the interface when > revert > to original address after failure succeeds. Fix this. > > Signed-off-by: Baruch Siach <bar...@tkos.co.il> > --- > Untested; I don't have the hardware. The code which updates the parser should keep the existing state if any part of the update fails. This means it must attempt all memory allocations and whatever other resource acquisition is necessary, and only after all of those operations succeed and no more error cases are possible should it update the tables and release the old entry. In other worse, this whole mechanism must move to a proper "prepare --> commit" model of making changes.
