On 2/2/21 5:24 AM, Paul Blakey wrote:
> Matches on conntrack rpl ct_state.
>
> Example:
> $ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \
> ct_state +trk+est+rpl \
> action mirred egress redirect dev ens1f0_1
> $ tc filter add dev ens1f0_1 ingress prio 1 chain 1 proto ip
On Tue, 2 Feb 2021, Marcelo Ricardo Leitner wrote:
> On Tue, Feb 02, 2021 at 02:24:42PM +0200, Paul Blakey wrote:
> > Matches on conntrack rpl ct_state.
> >
> > Example:
> > $ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \
> > ct_state +trk+est+rpl \
> > action mirred
On Tue, Feb 02, 2021 at 02:24:42PM +0200, Paul Blakey wrote:
> Matches on conntrack rpl ct_state.
>
> Example:
> $ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \
> ct_state +trk+est+rpl \
> action mirred egress redirect dev ens1f0_1
> $ tc filter add dev ens1f0_1 ingress p
Matches on conntrack rpl ct_state.
Example:
$ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \
ct_state +trk+est+rpl \
action mirred egress redirect dev ens1f0_1
$ tc filter add dev ens1f0_1 ingress prio 1 chain 1 proto ip flower \
ct_state +trk+est-rpl \
action mirred e
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
devlink/devlink.c | 206 +-
1 file changed, 202 insertions(+), 4 deletions(-)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index a2e066441e8a..63502a419d80 100644
--- a/devlink/devlink.c
+++ b/devl
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
devlink/devlink.c | 218 +-
1 file changed, 214 insertions(+), 4 deletions(-)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index a2e066441e8a..960f1078591e 100644
--- a/devlink/devlink.c
+++ b/devl
Please ignore this, I messed up the threading. Reposted.
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
devlink/devlink.c | 218 +-
1 file changed, 214 insertions(+), 4 deletions(-)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index a2e066441e8a..960f1078591e 100644
--- a/devlink/devlink.c
+++ b/devl
On 9/1/20 6:54 PM, David Ahern wrote:
On 8/28/20 9:42 PM, Roopa Prabhu wrote:
From: Roopa Prabhu
This patch adds support for recently
added link IFLA_PROTO_DOWN_REASON attribute.
IFLA_PROTO_DOWN_REASON enumerates reasons
for the already existing IFLA_PROTO_DOWN link
attribute.
$ cat /etc/ip
On 8/28/20 9:42 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> This patch adds support for recently
> added link IFLA_PROTO_DOWN_REASON attribute.
> IFLA_PROTO_DOWN_REASON enumerates reasons
> for the already existing IFLA_PROTO_DOWN link
> attribute.
>
> $ cat /etc/iproute2/protodown_reasons.
From: Roopa Prabhu
This patch adds support for recently
added link IFLA_PROTO_DOWN_REASON attribute.
IFLA_PROTO_DOWN_REASON enumerates reasons
for the already existing IFLA_PROTO_DOWN link
attribute.
$ cat /etc/iproute2/protodown_reasons.d/r.conf
0 mlag
1 evpn
2 vrrp
3 psecurity
$ ip link set d
On 8/23/20 7:20 PM, David Ahern wrote:
External email: Use caution opening links or attachments
On 8/20/20 9:52 PM, Roopa Prabhu wrote:
+void protodown_reason_n2a(int id, char *buf, int len)
+{
+ if (id < 0 || id >= PROTODOWN_REASON_NUM_BITS || numeric) {
since the reason is limited to
On 8/21/20 6:30 PM, Stephen Hemminger wrote:
External email: Use caution opening links or attachments
On Fri, 21 Aug 2020 14:09:14 -0700
Roopa Prabhu wrote:
On 8/20/20 10:18 PM, Roopa Prabhu wrote:
On 8/20/20 9:36 PM, Stephen Hemminger wrote:
On Thu, 20 Aug 2020 20:52:02 -0700
Roopa Pra
On 8/20/20 9:52 PM, Roopa Prabhu wrote:
> +void protodown_reason_n2a(int id, char *buf, int len)
> +{
> + if (id < 0 || id >= PROTODOWN_REASON_NUM_BITS || numeric) {
since the reason is limited to 0-31, id > PROTODOWN_REASON_NUM_BITS
should be an error.
> + snprintf(buf, len, "%d"
On Fri, 21 Aug 2020 14:09:14 -0700
Roopa Prabhu wrote:
> On 8/20/20 10:18 PM, Roopa Prabhu wrote:
> >
> > On 8/20/20 9:36 PM, Stephen Hemminger wrote:
> >>
> >>
> >> On Thu, 20 Aug 2020 20:52:02 -0700
> >> Roopa Prabhu wrote:
> >>
> >>> + if (tb[IFLA_PROTO_DOWN]) {
> >>> + if
On 8/20/20 10:18 PM, Roopa Prabhu wrote:
On 8/20/20 9:36 PM, Stephen Hemminger wrote:
On Thu, 20 Aug 2020 20:52:02 -0700
Roopa Prabhu wrote:
+ if (tb[IFLA_PROTO_DOWN]) {
+ if (rta_getattr_u8(tb[IFLA_PROTO_DOWN]))
+ print_bool(PRINT_ANY,
+
On 8/20/20 9:36 PM, Stephen Hemminger wrote:
On Thu, 20 Aug 2020 20:52:02 -0700
Roopa Prabhu wrote:
+ if (tb[IFLA_PROTO_DOWN]) {
+ if (rta_getattr_u8(tb[IFLA_PROTO_DOWN]))
+ print_bool(PRINT_ANY,
+"proto_down", " protodown
On Thu, 20 Aug 2020 20:52:02 -0700
Roopa Prabhu wrote:
> + if (tb[IFLA_PROTO_DOWN]) {
> + if (rta_getattr_u8(tb[IFLA_PROTO_DOWN]))
> + print_bool(PRINT_ANY,
> +"proto_down", " protodown on ", true);
In general my preference is t
From: Roopa Prabhu
This patch adds support for recently
added link IFLA_PROTO_DOWN_REASON attribute.
IFLA_PROTO_DOWN_REASON enumerates reasons
for the already existing IFLA_PROTO_DOWN link
attribute.
$ cat /etc/iproute2/protodown_reasons.d/r.conf
0 mlag
1 evpn
2 vrrp
3 psecurity
$ ip link set d
On 6/10/20 6:35 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> This series adds iproute2 support for recently added
> kernel fdb nexthop groups
>
> example:
> /* create fdb nexthop group */
> $ip nexthop add id 12 via 172.16.1.2 fdb
> $ip nexthop add id 13 via 172.16.1.3 fdb
> $ip nexthop add
From: Roopa Prabhu
This series adds iproute2 support for recently added
kernel fdb nexthop groups
example:
/* create fdb nexthop group */
$ip nexthop add id 12 via 172.16.1.2 fdb
$ip nexthop add id 13 via 172.16.1.3 fdb
$ip nexthop add id 102 group 12/13 fdb
/* assign nexthop group to fdb en
From: Roopa Prabhu
This patch adds support to add and delete
ecmp nexthops of type fdb. Such nexthops can
be linked to vxlan fdb entries.
$ip nexthop add id 12 via 172.16.1.2 fdb
$ip nexthop add id 13 via 172.16.1.3 fdb
$ip nexthop add id 102 group 12/13 fdb
$bridge fdb add 02:02:00:00:00:13 de
From: Roopa Prabhu
This patch adds support to assign a nexthop group
id to an fdb entry.
$bridge fdb add 02:02:00:00:00:13 dev vx10 nhid 102 self
Signed-off-by: Roopa Prabhu
---
bridge/fdb.c | 22 +++---
man/man8/bridge.8 | 13 ++---
2 files changed, 29 insertions
On 6/8/20 9:46 PM, Roopa Prabhu wrote:
> @@ -70,6 +71,12 @@ static int nh_dump_filter(struct nlmsghdr *nlh, int reqlen)
> return err;
> }
>
> + if (filter.fdb) {
> + addattr_l(nlh, reqlen, NHA_FDB, NULL, 0);
missing 'err = '
> + if (err)
>
From: Roopa Prabhu
This patch adds support to assign a nexthop group
id to an fdb entry.
$bridge fdb add 02:02:00:00:00:13 dev vx10 nhid 102 self
Signed-off-by: Roopa Prabhu
---
bridge/fdb.c | 22 +++---
man/man8/bridge.8 | 13 ++---
2 files changed, 29 insertions
From: Roopa Prabhu
This series adds iproute2 support for recently added
kernel fdb nexthop groups
example:
/* create fdb nexthop group */
$ip nexthop add id 12 via 172.16.1.2 fdb
$ip nexthop add id 13 via 172.16.1.3 fdb
$ip nexthop add id 102 group 12/13 fdb
/* assign nexthop group to fdb en
From: Roopa Prabhu
This patch adds support to add and delete
ecmp nexthops of type fdb. Such nexthops can
be linked to vxlan fdb entries.
$ip nexthop add id 12 via 172.16.1.2 fdb
$ip nexthop add id 13 via 172.16.1.3 fdb
$ip nexthop add id 102 group 12/13 fdb
$bridge fdb add 02:02:00:00:00:13 de
On 18/05/2020 17:56, David Ahern wrote:
> On 5/14/20 8:10 AM, Paul Blakey wrote:
>> Signed-off-by: Paul Blakey
>> ---
>> man/man8/tc-ct.8 | 107
>> +++
>> man/man8/tc-flower.8 | 6 +++
>> 2 files changed, 113 insertions(+)
>> create mode 1
On 5/14/20 8:10 AM, Paul Blakey wrote:
> Signed-off-by: Paul Blakey
> ---
> man/man8/tc-ct.8 | 107
> +++
> man/man8/tc-flower.8 | 6 +++
> 2 files changed, 113 insertions(+)
> create mode 100644 man/man8/tc-ct.8
>
> diff --git a/man/man8/t
On 14/05/2020 15:10, Paul Blakey wrote:
> Signed-off-by: Paul Blakey
> ---
> man/man8/tc-ct.8 | 107
> +++
> man/man8/tc-flower.8 | 6 +++
> 2 files changed, 113 insertions(+)
> create mode 100644 man/man8/tc-ct.8
Glad to see this, better tc
Signed-off-by: Paul Blakey
---
man/man8/tc-ct.8 | 107 +++
man/man8/tc-flower.8 | 6 +++
2 files changed, 113 insertions(+)
create mode 100644 man/man8/tc-ct.8
diff --git a/man/man8/tc-ct.8 b/man/man8/tc-ct.8
new file mode 100644
index 0
On Tue, Oct 1, 2019 at 7:59 AM Stephen Hemminger
wrote:
>
> On Mon, 30 Sep 2019 21:52:22 -0700
> Roopa Prabhu wrote:
>
> > +
> > + if (sscanf(addr, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> > +abuf, abuf+1, abuf+2,
> > +abuf+3, abuf+4, abuf+5) != 6) {
> > +
On 9/30/19 10:52 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> This series adds iproute2 support to lookup a bridge fdb and
> neigh entry.
> example:
> $bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002
> 02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge
>
> $ip neigh get 10.
On Mon, 30 Sep 2019 21:52:22 -0700
Roopa Prabhu wrote:
> +
> + if (sscanf(addr, "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx",
> +abuf, abuf+1, abuf+2,
> +abuf+3, abuf+4, abuf+5) != 6) {
> + fprintf(stderr, "Invalid mac address %s\n", addr);
> + retur
From: Roopa Prabhu
This series adds iproute2 support to lookup a bridge fdb and
neigh entry.
example:
$bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002
02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge
$ip neigh get 10.0.2.4 dev test-dummy0
10.0.2.4 dev test-dummy0 lladdr de:ad
From: Roopa Prabhu
This patch adds support to lookup a bridge fdb entry
using recently added support in the kernel using RTM_GETNEIGH
(and AF_BRIDGE family).
example:
$bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002
02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge
Signed-off
From: Roopa Prabhu
This patch adds support to lookup a neigh entry
using recently added support in the kernel using RTM_GETNEIGH
example:
$ip neigh get 10.0.2.4 dev test-dummy0
10.0.2.4 dev test-dummy0 lladdr de:ad:be:ef:13:37 PERMANENT
Signed-off-by: Roopa Prabhu
Tested-by: Ivan Vecera
---
On Mon, Sep 30, 2019 at 9:42 AM David Ahern wrote:
>
> On 9/28/19 2:22 PM, Roopa Prabhu wrote:
> > +
> > + req.ndm.ndm_family = dst.family;
> > + if (addattr_l(&req.n, sizeof(req), NDA_DST, &dst.data, dst.bytelen) <
> > 0)
> > + return -1;
> > +
> > + if (d) {
> > +
On 9/28/19 2:22 PM, Roopa Prabhu wrote:
> +
> + req.ndm.ndm_family = dst.family;
> + if (addattr_l(&req.n, sizeof(req), NDA_DST, &dst.data, dst.bytelen) < 0)
> + return -1;
> +
> + if (d) {
> + ll_init_map(&rth);
ll_init_map is not needed and really not somethin
On 9/28/19 2:22 PM, Roopa Prabhu wrote:
> @@ -518,6 +520,113 @@ static int fdb_modify(int cmd, int flags, int argc,
> char **argv)
> return 0;
> }
>
> +static int fdb_get(int argc, char **argv)
> +{
> + struct {
> + struct nlmsghdr n;
> + struct ndmsg
On Mon, Sep 30, 2019 at 7:57 AM Ivan Vecera wrote:
>
> On Sat, 28 Sep 2019 13:22:08 -0700
> Roopa Prabhu wrote:
>
> > From: Roopa Prabhu
> >
> > This series adds iproute2 support to lookup a bridge fdb and
> > neigh entry.
> > example:
> > $bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1
On Sat, 28 Sep 2019 13:22:08 -0700
Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> This series adds iproute2 support to lookup a bridge fdb and
> neigh entry.
> example:
> $bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002
> 02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge
>
> $
From: Roopa Prabhu
This patch adds support to lookup a bridge fdb entry
using recently added support in the kernel using RTM_GETNEIGH
(and AF_BRIDGE family).
example:
$bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002
02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge
Signed-off
From: Roopa Prabhu
This series adds iproute2 support to lookup a bridge fdb and
neigh entry.
example:
$bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002
02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge
$ip neigh get 10.0.2.4 dev test-dummy0
10.0.2.4 dev test-dummy0 lladdr de:ad
From: Roopa Prabhu
This patch adds support to lookup a neigh entry
using recently added support in the kernel using RTM_GETNEIGH
example:
$ip neigh get 10.0.2.4 dev test-dummy0
10.0.2.4 dev test-dummy0 lladdr de:ad:be:ef:13:37 PERMANENT
Signed-off-by: Roopa Prabhu
---
ip/ipneigh.c
On Sat, Sep 28, 2019 at 8:46 AM Stephen Hemminger
wrote:
>
> On Fri, 27 Sep 2019 21:48:23 -0700
> Roopa Prabhu wrote:
>
> Overall, looks good.
>
> > + if (print_fdb(answer, (void *)stdout) < 0) {
>
> Cast to void is not necessary in C (it is in C++)
thats a copy/paste from iproute get code.
On Fri, 27 Sep 2019 21:48:23 -0700
Roopa Prabhu wrote:
Overall, looks good.
> + if (print_fdb(answer, (void *)stdout) < 0) {
Cast to void is not necessary in C (it is in C++)
From: Roopa Prabhu
This patch adds support to lookup a neigh entry
using recently added support in the kernel using RTM_GETNEIGH
example:
$ip neigh get 10.0.2.4 dev test-dummy0
10.0.2.4 dev test-dummy0 lladdr de:ad:be:ef:13:37 PERMANENT
Signed-off-by: Roopa Prabhu
---
ip/ipneigh.c
From: Roopa Prabhu
This patch adds support to lookup a bridge fdb entry
using recently added support in the kernel using RTM_GETNEIGH
(and AF_BRIDGE family).
example:
$bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002
02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge
Signed-off
From: Roopa Prabhu
This series adds iproute2 support to lookup a bridge fdb and
neigh entry.
example:
$bridge fdb get 02:02:00:00:00:03 dev test-dummy0 vlan 1002
02:02:00:00:00:03 dev test-dummy0 vlan 1002 master bridge
$ip neigh get 10.0.2.4 dev test-dummy0
10.0.2.4 dev test-dummy0 lladdr de:ad
From: Jiri Pirko
Signed-off-by: Jiri Pirko
---
devlink/devlink.c| 22 +++---
include/uapi/linux/devlink.h | 2 ++
2 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index 8c5612a9f9a8..8020d76dd7f7 100644
--- a/devl
> On Jul 18, 2019, at 10:12 PM, Stephen Hemminger
> wrote:
>
> On Thu, 18 Jul 2019 12:55:39 -0700
> Vedang Patel wrote:
>
>> -print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s",
>> +print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s ",
>>
On Thu, 18 Jul 2019 12:55:39 -0700
Vedang Patel wrote:
> - print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s",
> + print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s ",
> (qopt->flags & TC_ETF_DEADLINE_MODE_ON) ? "on"
> : "off");
> + pri
On 7/18/19 1:55 PM, Vedang Patel wrote:
> ETF Qdisc currently checks for a socket with SO_TXTIME socket option. If
> either is not present, the packet is dropped. In the future commits, we
> want other Qdiscs to add packet with launchtime to the ETF Qdisc. Also,
> there are some packets (e.g. ICMP
This adds support for setting the txtime_delay parameter which is useful
for the txtime offload mode of taprio.
Signed-off-by: Vedang Patel
---
tc/q_taprio.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/tc/q_taprio.c b/tc/q_taprio.c
index 1db2aba6e
Add documentation for the latest options, flags and txtime-delay, to the
taprio manpage.
This also adds an example to run tc in txtime offload mode.
Signed-off-by: Vedang Patel
---
man/man8/tc-taprio.8 | 40
1 file changed, 40 insertions(+)
diff --git a
From: Vinicius Costa Gomes
This allows a new parameter, flags, to be passed to taprio. Currently, it
only supports enabling the txtime-assist mode. But, we plan to add
different modes for taprio (e.g. hardware offloading) and this parameter
will be useful in enabling those modes.
Signed-off-by:
Document the newly added option (skip_sock_check) on the etf man-page.
Signed-off-by: Vedang Patel
---
man/man8/tc-etf.8 | 10 ++
1 file changed, 10 insertions(+)
diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
index 30a12de7d2c7..4cb3b9e02d6e 100644
--- a/man/man8/tc-etf.8
+++ b/man
ETF Qdisc currently checks for a socket with SO_TXTIME socket option. If
either is not present, the packet is dropped. In the future commits, we
want other Qdiscs to add packet with launchtime to the ETF Qdisc. Also,
there are some packets (e.g. ICMP packets) which may not have a socket
associated
> On Jul 18, 2019, at 10:36 AM, David Ahern wrote:
>
> On 7/16/19 1:53 PM, Vedang Patel wrote:
>> Document the newly added option (skip-skb-check) on the etf man-page.
>>
>> Signed-off-by: Vedang Patel
>> ---
>> man/man8/tc-etf.8 | 10 ++
>> 1 file changed, 10 insertions(+)
>>
>> dif
> On Jul 18, 2019, at 10:32 AM, David Ahern wrote:
>
> On 7/16/19 1:53 PM, Vedang Patel wrote:
>> The type for txtime-delay parameter will change from s32 to u32. So,
>> make the corresponding change in the ABI file as well.
>>
>> Signed-off-by: Vedang Patel
>> ---
>> include/uapi/linux/pkt_
On 7/16/19 1:53 PM, Vedang Patel wrote:
> Document the newly added option (skip-skb-check) on the etf man-page.
>
> Signed-off-by: Vedang Patel
> ---
> man/man8/tc-etf.8 | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
> index 30a12de7d2
On 7/16/19 1:53 PM, Vedang Patel wrote:
> The type for txtime-delay parameter will change from s32 to u32. So,
> make the corresponding change in the ABI file as well.
>
> Signed-off-by: Vedang Patel
> ---
> include/uapi/linux/pkt_sched.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
From: Vinicius Costa Gomes
This allows a new parameter, flags, to be passed to taprio. Currently, it
only supports enabling the txtime-assist mode. But, we plan to add
different modes for taprio (e.g. hardware offloading) and this parameter
will be useful in enabling those modes.
Signed-off-by:
Add documentation for the latest options, flags and txtime-delay, to the
taprio manpage.
This also adds an example to run tc in txtime offload mode.
Signed-off-by: Vedang Patel
---
man/man8/tc-taprio.8 | 40
1 file changed, 40 insertions(+)
diff --git a
ETF Qdisc currently checks for a socket with SO_TXTIME socket option. If
either is not present, the packet is dropped. In the future commits, we
want other Qdiscs to add packet with launchtime to the ETF Qdisc. Also,
there are some packets (e.g. ICMP packets) which may not have a socket
associated
The type for txtime-delay parameter will change from s32 to u32. So,
make the corresponding change in the ABI file as well.
Signed-off-by: Vedang Patel
---
include/uapi/linux/pkt_sched.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/pkt_sched.h b/include/
Document the newly added option (skip-skb-check) on the etf man-page.
Signed-off-by: Vedang Patel
---
man/man8/tc-etf.8 | 10 ++
1 file changed, 10 insertions(+)
diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
index 30a12de7d2c7..2e01a591dbaa 100644
--- a/man/man8/tc-etf.8
+++ b/man/
This adds support for setting the txtime_delay parameter which is useful
for the txtime offload mode of taprio.
Signed-off-by: Vedang Patel
---
tc/q_taprio.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/tc/q_taprio.c b/tc/q_taprio.c
index 1db2aba6e
> On Jul 15, 2019, at 4:38 PM, Stephen Hemminger
> wrote:
>
> On Mon, 15 Jul 2019 15:51:42 -0700
> Vedang Patel wrote:
>
>> +if (get_s32(&txtime_delay, *argv, 0)) {
>
> Is txtime_delay of a negative value meaningful?
No, txtime-delay should always be a positive value.
Hi Stephen,
> On Jul 15, 2019, at 4:37 PM, Stephen Hemminger
> wrote:
>
> On Mon, 15 Jul 2019 15:51:41 -0700
> Vedang Patel wrote:
>
>> @@ -405,6 +420,7 @@ static int taprio_print_opt(struct qdisc_util *qu, FILE
>> *f, struct rtattr *opt)
>> struct rtattr *tb[TCA_TAPRIO_ATTR_MAX + 1];
>
On Mon, 15 Jul 2019 17:24:22 -0700, Stephen Hemminger wrote:
> On Mon, 15 Jul 2019 17:15:15 -0700
> Jakub Kicinski wrote:
> > On Mon, 15 Jul 2019 16:37:43 -0700, Stephen Hemminger wrote:
> > > On Mon, 15 Jul 2019 15:51:41 -0700
> > > Vedang Patel wrote:
> > > > @@ -442,6 +458,11 @@ static i
On Mon, 15 Jul 2019 17:15:15 -0700
Jakub Kicinski wrote:
> On Mon, 15 Jul 2019 16:37:43 -0700, Stephen Hemminger wrote:
> > On Mon, 15 Jul 2019 15:51:41 -0700
> > Vedang Patel wrote:
> > > @@ -442,6 +458,11 @@ static int taprio_print_opt(struct qdisc_util *qu,
> > > FILE *f, struct rtattr *op
On Mon, 15 Jul 2019 16:37:43 -0700, Stephen Hemminger wrote:
> On Mon, 15 Jul 2019 15:51:41 -0700
> Vedang Patel wrote:
> > @@ -442,6 +458,11 @@ static int taprio_print_opt(struct qdisc_util *qu,
> > FILE *f, struct rtattr *opt)
> >
> > print_string(PRINT_ANY, "clockid", "clockid %s",
> >
On Mon, 15 Jul 2019 15:51:42 -0700
Vedang Patel wrote:
> + if (get_s32(&txtime_delay, *argv, 0)) {
Is txtime_delay of a negative value meaningful?
On Mon, 15 Jul 2019 15:51:41 -0700
Vedang Patel wrote:
> @@ -405,6 +420,7 @@ static int taprio_print_opt(struct qdisc_util *qu, FILE
> *f, struct rtattr *opt)
> struct rtattr *tb[TCA_TAPRIO_ATTR_MAX + 1];
> struct tc_mqprio_qopt *qopt = 0;
> __s32 clockid = CLOCKID_INVALID;
> +
Add documentation for the latest options, flags and txtime-delay, to the
taprio manpage.
This also adds an example to run tc in txtime offload mode.
Signed-off-by: Vedang Patel
---
man/man8/tc-taprio.8 | 40
1 file changed, 40 insertions(+)
diff --git a
This adds support for setting the txtime_delay parameter which is useful
for the txtime offload mode of taprio.
Signed-off-by: Vedang Patel
---
tc/q_taprio.c | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/tc/q_taprio.c b/tc/q_taprio.c
index 930ecb9d1e
Document the newly added option (skip-skb-check) on the etf man-page.
Signed-off-by: Vedang Patel
---
man/man8/tc-etf.8 | 10 ++
1 file changed, 10 insertions(+)
diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
index 30a12de7d2c7..2e01a591dbaa 100644
--- a/man/man8/tc-etf.8
+++ b/man/
From: Vinicius Costa Gomes
This allows a new parameter, flags, to be passed to taprio. Currently, it
only supports enabling the txtime-assist mode. But, we plan to add
different modes for taprio (e.g. hardware offloading) and this parameter
will be useful in enabling those modes.
Signed-off-by:
ETF Qdisc currently checks for a socket with SO_TXTIME socket option. If
either is not present, the packet is dropped. In the future commits, we
want other Qdiscs to add packet with launchtime to the ETF Qdisc. Also,
there are some packets (e.g. ICMP packets) which may not have a socket
associated
Ok I will send out the patches again.
Thanks,
Vedang
> On Jul 15, 2019, at 1:16 PM, David Ahern wrote:
>
> On 7/15/19 1:50 PM, Stephen Hemminger wrote:
>> On Mon, 15 Jul 2019 19:40:19 +
>> "Patel, Vedang" wrote:
>>
>>> Hi Stephen,
>>>
>>> The kernel patches corresponding to this series
On 7/15/19 1:50 PM, Stephen Hemminger wrote:
> On Mon, 15 Jul 2019 19:40:19 +
> "Patel, Vedang" wrote:
>
>> Hi Stephen,
>>
>> The kernel patches corresponding to this series have been merged. I just
>> wanted to check whether these iproute2 related patches are on your TODO list.
>>
>> Let m
On Mon, 15 Jul 2019 19:40:19 +
"Patel, Vedang" wrote:
> Hi Stephen,
>
> The kernel patches corresponding to this series have been merged. I just
> wanted to check whether these iproute2 related patches are on your TODO list.
>
> Let me know if you need any information from me on these pat
Hi Stephen,
The kernel patches corresponding to this series have been merged. I just wanted
to check whether these iproute2 related patches are on your TODO list.
Let me know if you need any information from me on these patches.
Thanks,
Vedang Patel
> On Jun 6, 2019, at 3:22 PM, Patel, Vedang
> -Original Message-
> From: netdev-ow...@vger.kernel.org On
> Behalf Of Parav Pandit
> Sent: Tuesday, July 2, 2019 12:00 AM
> To: netdev@vger.kernel.org
> Cc: Saeed Mahameed ;
> jakub.kicin...@netronome.com; Jiri Pirko ; Parav Pandit
>
> Subject: [RES
Introduce PCI PF and VF port flavour and port attributes such as PF
number and VF number.
$ devlink port show
pci/:05:00.0/0: type eth netdev eth0 flavour pcipf pfnum 0
pci/:05:00.0/1: type eth netdev eth1 flavour pcivf pfnum 0 vfnum 0
pci/:05:00.0/2: type eth netdev eth2 flavour pcivf
On 6/12/19 3:21 AM, Hangbin Liu wrote:
> Add a new parameter '-Numeric' to show the number of protocol, scope,
> dsfield, etc directly instead of converting it to human readable name.
> Do the same on tc and ss.
>
> This patch is based on David Ahern's previous patch.
>
> Suggested-by: Phil Sutte
On 6/14/19 1:00 PM, Roman Mashak wrote:
> On the 2nd thought: there already exists argument "-raw" for tc which
> currently instructs printing handles in hex representation. Why not to
> adopt this for ip and ss as well rather then adding new key?
show_raw seems to mean dump extra data as opposed
David Ahern writes:
> On 6/12/19 10:01 AM, Roman Mashak wrote:
>> Hangbin Liu writes:
>>
>>> Add a new parameter '-Numeric' to show the number of protocol, scope,
>>> dsfield, etc directly instead of converting it to human readable name.
>>> Do the same on tc and ss.
>>>
>>> This patch is based
On 6/12/19 10:01 AM, Roman Mashak wrote:
> Hangbin Liu writes:
>
>> Add a new parameter '-Numeric' to show the number of protocol, scope,
>> dsfield, etc directly instead of converting it to human readable name.
>> Do the same on tc and ss.
>>
>> This patch is based on David Ahern's previous patc
Hi Roman,
On Wed, Jun 12, 2019 at 12:01:20PM -0400, Roman Mashak wrote:
> Hangbin Liu writes:
>
> > Add a new parameter '-Numeric' to show the number of protocol, scope,
> > dsfield, etc directly instead of converting it to human readable name.
> > Do the same on tc and ss.
> >
> > This patch is
Hangbin Liu writes:
> Add a new parameter '-Numeric' to show the number of protocol, scope,
> dsfield, etc directly instead of converting it to human readable name.
> Do the same on tc and ss.
>
> This patch is based on David Ahern's previous patch.
>
[...]
It would be good idea to specify the
On Wed, 12 Jun 2019 at 17:21, Hangbin Liu wrote:
>
> Add a new parameter '-Numeric' to show the number of protocol, scope,
> dsfield, etc directly instead of converting it to human readable name.
> Do the same on tc and ss.
>
> This patch is based on David Ahern's previous patch.
>
> Suggested-by:
Add a new parameter '-Numeric' to show the number of protocol, scope,
dsfield, etc directly instead of converting it to human readable name.
Do the same on tc and ss.
This patch is based on David Ahern's previous patch.
Suggested-by: Phil Sutter
Signed-off-by: Hangbin Liu
---
include/utils.h
Document the newly added option (skip-skb-check) on the etf man-page.
Signed-off-by: Vedang Patel
---
man/man8/tc-etf.8 | 10 ++
1 file changed, 10 insertions(+)
diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
index 30a12de7d2c7..2e01a591dbaa 100644
--- a/man/man8/tc-etf.8
+++ b/man/
> On Jun 6, 2019, at 2:46 PM, Stephen Hemminger
> wrote:
>
> On Thu, 6 Jun 2019 21:13:50 +
> "Patel, Vedang" wrote:
>
>>> On Jun 6, 2019, at 12:43 PM, Stephen Hemminger
>>> wrote:
>>>
>>> On Thu, 6 Jun 2019 10:52:18 -0700
>>> Vedang Patel wrote:
>>>
@@ -405,6 +420,7 @@ static
From: Vinicius Costa Gomes
This allows a new parameter, flags, to be passed to taprio. Currently, it
only supports enabling the txtime-assist mode. But, we plan to add
different modes for taprio (e.g. hardware offloading) and this parameter
will be useful in enabling those modes.
Signed-off-by:
This should only be updated after the kernel patches related to
txtime-offload have been merged into the kernel.
Signed-off-by: Vedang Patel
---
include/uapi/linux/pkt_sched.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h
ETF Qdisc currently checks for a socket with SO_TXTIME socket option. If
either is not present, the packet is dropped. In the future commits, we
want other Qdiscs to add packet with launchtime to the ETF Qdisc. Also,
there are some packets (e.g. ICMP packets) which may not have a socket
associated
1 - 100 of 891 matches
Mail list logo
