Re: [PATCH iproute2 net-next v5 1/5] etf: Add skip_sock_check

[Patel, Vedang]

> On Jul 18, 2019, at 10:12 PM, Stephen Hemminger <step...@networkplumber.org> 
> wrote:
> 
> On Thu, 18 Jul 2019 12:55:39 -0700
> Vedang Patel <vedang.pa...@intel.com> wrote:
> 
>> -    print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s",
>> +    print_string(PRINT_ANY, "deadline_mode", "deadline_mode %s ",
>>                              (qopt->flags & TC_ETF_DEADLINE_MODE_ON) ? "on" 
>> : "off");
>> +    print_string(PRINT_ANY, "skip_sock_check", "skip_sock_check %s",
>> +                            (qopt->flags & TC_ETF_SKIP_SOCK_CHECK) ? "on" : 
>> "off");
> 
> These should really be boolean options in JSON, not string values.
Ok. Sending out a patch to fix this.

Thanks,
Vedang