Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-14 Thread Heiner Kallweit
On 15.06.2020 01:26, Michal Kubecek wrote: > On Mon, Jun 15, 2020 at 12:35:30AM +0200, Heiner Kallweit wrote: >> Seems that disabling ETHTOOL_NETLINK for PHYLIB=m has (at least) one >> more side effect. I just saw that ifconfig doesn't report LOWER_UP >> any longer. Reason seems to be that the ioct

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-14 Thread Michal Kubecek
On Mon, Jun 15, 2020 at 12:35:30AM +0200, Heiner Kallweit wrote: > Seems that disabling ETHTOOL_NETLINK for PHYLIB=m has (at least) one > more side effect. I just saw that ifconfig doesn't report LOWER_UP > any longer. Reason seems to be that the ioctl fallback supports > 16 bits for the flags only

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-14 Thread Heiner Kallweit
On 10.06.2020 13:53, Michal Kubecek wrote: > On Wed, Jun 10, 2020 at 12:50:30PM +0200, Heiner Kallweit wrote: >> On 10.06.2020 11:13, Michal Kubecek wrote: >>> Just to make sure you are hitting the same problem I'm just looking at, >>> please check if >>> >>> - your kernel is built with ETHTOOL_NET

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-14 Thread Florian Fainelli
On 6/14/2020 9:14 AM, Heiner Kallweit wrote: > On 10.06.2020 22:05, Andrew Lunn wrote: >>> Not sure it makes sense to build ETHTOOL_NETLINK as a module, but at >>> least ensuring that ETHTOOL_NETLINK is built into the kernel if PHYLIB=y >>> or PHYLIB=m would make sense, or, better we find a way

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-14 Thread Heiner Kallweit
On 10.06.2020 22:05, Andrew Lunn wrote: >> Not sure it makes sense to build ETHTOOL_NETLINK as a module, but at >> least ensuring that ETHTOOL_NETLINK is built into the kernel if PHYLIB=y >> or PHYLIB=m would make sense, or, better we find a way to decouple the >> two by using function pointers fro

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Andrew Lunn
> Not sure it makes sense to build ETHTOOL_NETLINK as a module, but at > least ensuring that ETHTOOL_NETLINK is built into the kernel if PHYLIB=y > or PHYLIB=m would make sense, or, better we find a way to decouple the > two by using function pointers from the phy_driver directly that way > there i

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Florian Fainelli
On 6/10/2020 3:50 AM, Heiner Kallweit wrote: > On 10.06.2020 11:13, Michal Kubecek wrote: >> On Wed, Jun 10, 2020 at 10:52:26AM +0200, Heiner Kallweit wrote: >>> On 10.06.2020 10:26, Heiner Kallweit wrote: Since ethtool 5.7 following happens (kernel is latest linux-next): ethtool

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Michal Kubecek
On Wed, Jun 10, 2020 at 12:50:30PM +0200, Heiner Kallweit wrote: > On 10.06.2020 11:13, Michal Kubecek wrote: > > Just to make sure you are hitting the same problem I'm just looking at, > > please check if > > > > - your kernel is built with ETHTOOL_NETLINK=n > > No, because I have PHYLIB=m. > No

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Heiner Kallweit
On 10.06.2020 11:13, Michal Kubecek wrote: > On Wed, Jun 10, 2020 at 10:52:26AM +0200, Heiner Kallweit wrote: >> On 10.06.2020 10:26, Heiner Kallweit wrote: >>> Since ethtool 5.7 following happens (kernel is latest linux-next): >>> >>> ethtool -s enp3s0 wol g >>> netlink error: No such file or dire

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Michal Kubecek
On Wed, Jun 10, 2020 at 10:52:26AM +0200, Heiner Kallweit wrote: > On 10.06.2020 10:26, Heiner Kallweit wrote: > > Since ethtool 5.7 following happens (kernel is latest linux-next): > > > > ethtool -s enp3s0 wol g > > netlink error: No such file or directory > > > > With ethtool 5.6 this doesn't

Re: ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Heiner Kallweit
On 10.06.2020 10:26, Heiner Kallweit wrote: > Since ethtool 5.7 following happens (kernel is latest linux-next): > > ethtool -s enp3s0 wol g > netlink error: No such file or directory > > With ethtool 5.6 this doesn't happen. I also checked the latest ethtool > git version (5.7 + some fixes), err

ethtool 5.7: netlink ENOENT error when setting WOL

2020-06-10 Thread Heiner Kallweit
Since ethtool 5.7 following happens (kernel is latest linux-next): ethtool -s enp3s0 wol g netlink error: No such file or directory With ethtool 5.6 this doesn't happen. I also checked the latest ethtool git version (5.7 + some fixes), error still occurs. Heiner