On 10.06.2020 13:53, Michal Kubecek wrote: > On Wed, Jun 10, 2020 at 12:50:30PM +0200, Heiner Kallweit wrote: >> On 10.06.2020 11:13, Michal Kubecek wrote: >>> Just to make sure you are hitting the same problem I'm just looking at, >>> please check if >>> >>> - your kernel is built with ETHTOOL_NETLINK=n >> >> No, because I have PHYLIB=m. >> Not sure what it would take to allow building ethtool netlink support >> as a module. But that's just on a side note. > > Yes, this is the unfortunate fallout of the new dependency between > ETHTOOL_NETLINK and PHYLIB introduced with the cable diagnostic series. > As "make oldconfig" silently disables ETHTOOL_NETLINK when PHYLIB=m, > many people won't even notice. Even I fell for this when I suddently > noticed my testing merge window snapshot has ETHTOOL_NETLINK disable. > I guess we will have to find some nicer solution. >
Seems that disabling ETHTOOL_NETLINK for PHYLIB=m has (at least) one more side effect. I just saw that ifconfig doesn't report LOWER_UP any longer. Reason seems to be that the ioctl fallback supports 16 bits for the flags only (and IFF_LOWER_UP is bit 16). See dev_ifsioc_locked(). > Michal > Heiner
