On 11/01/2017 03:16 PM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Wed, 1 Nov 2017 14:56:15 +0100
>
> Add a jump target so that a bit of exception handling can be better reused
> at the end of this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-o
On 11/01/2017 08:37 PM, SF Markus Elfring wrote:
These addresses were suggested (or recommended?) by the script
“get_maintainer.pl”.
I know.
(..)
How does this view fit to the information in the section “5) Select
the recipients for your patch” from the document “submitting-patches.rst”?
> Acked-by: Oliver Hartkopp
Thanks for another positive feedback.
> Again: Posting such a patch on linux-...@vger.kernel.org is ENOUGH!
I was informed in an other way for Linux software patches.
> No need to cross post such a patch additionally on
>
> netdev@vger.kernel.org
> linux-ker...@v
On 11/01/2017 03:16 PM, SF Markus Elfring wrote:
From: Markus Elfring
Date: Wed, 1 Nov 2017 14:56:15 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus
From: Markus Elfring
Date: Wed, 1 Nov 2017 14:56:15 +0100
Add a jump target so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
v2:
An approach to make two checks for
Hi Markus,
this discussion went far beyond the original posted patch for vxcan.c
I would suggest you post your idea of the simplified error handling flow
in vxcan.c just on linux-can ML (which is the right mailing list for CAN
related stuff).
Thanks,
Oliver
On 10/28/2017 10:13 PM, SF Markus
>> Are you interested in related adjustments for a bigger code base?
>
> No. Definitely not.
You might have noticed that I am proposing similar changes already
for other software modules. ;-)
> If you aim for the the deletion of “ < 0” for all rtnl_configure_link() users
> you would need to d
On 10/28/2017 09:18 PM, SF Markus Elfring wrote:
If you want to change the semantic of the result check
I am curious if another source code reduction (by the deletion of “ < 0”)
will become acceptable at similar places.
Source code reduction is not the main target.
If you can simplify code w
> If you want to change the semantic of the result check
I am curious if another source code reduction (by the deletion of “ < 0”)
will become acceptable at similar places.
> - this has to done consistently at all rtnl_configure_link() caller sites.
Are there any more functions to consider?
>
On 10/28/2017 08:33 PM, SF Markus Elfring wrote:
So if you would like to change the if-statement:
It will need a small adjustment for the shown transformation.
I was also unsure if the proposal will work in a single update step.
1. Send a patch for vxcan.c to improve the error handling flow
> So if you would like to change the if-statement:
It will need a small adjustment for the shown transformation.
I was also unsure if the proposal will work in a single update step.
> 1. Send a patch for vxcan.c to improve the error handling flow
I am going to send a second approach for this u
On 10/28/2017 10:23 AM, SF Markus Elfring wrote:
@@ -227,10 +227,8 @@ static int vxcan_newlink(struct net *net, struct
net_device *dev,
netif_carrier_off(peer);
err = rtnl_configure_link(peer, ifmp);
- if (err < 0) {
- unregister_netdevice(peer);
- return err;
-
>> @@ -227,10 +227,8 @@ static int vxcan_newlink(struct net *net, struct
>> net_device *dev,
>> netif_carrier_off(peer);
>> err = rtnl_configure_link(peer, ifmp);
>> - if (err < 0) {
>> - unregister_netdevice(peer);
>> - return err;
>> - }
>> + if (err)
>> +
Hi Markus,
On 10/27/2017 10:30 PM, SF Markus Elfring wrote:
From: Markus Elfring
Date: Fri, 27 Oct 2017 22:22:24 +0200
* Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
* Adjust two condition checks.
This issue was detected by using
From: Markus Elfring
Date: Fri, 27 Oct 2017 22:22:24 +0200
* Add a jump target so that a bit of exception handling can be better
reused at the end of this function.
* Adjust two condition checks.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
dr
15 matches
Mail list logo
