Re: bgmac-enet driver broken in 5.7

2020-05-04 Thread Dejin Zheng
On Mon, May 04, 2020 at 05:37:18PM -0700, Jonathan Richardson wrote: > On Mon, May 4, 2020 at 5:30 PM Dejin Zheng wrote: > > > > On Mon, May 04, 2020 at 12:32:55PM -0700, Jonathan Richardson wrote: > > > Hi, > > > > > > Commit d7a5502b0bb8b (net: broadcom: convert to > > > devm_platform_ioremap_re

Re: bgmac-enet driver broken in 5.7

2020-05-04 Thread Jonathan Richardson
On Mon, May 4, 2020 at 5:30 PM Dejin Zheng wrote: > > On Mon, May 04, 2020 at 12:32:55PM -0700, Jonathan Richardson wrote: > > Hi, > > > > Commit d7a5502b0bb8b (net: broadcom: convert to > > devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver. > > probe fails with -22. idm_base an

Re: bgmac-enet driver broken in 5.7

2020-05-04 Thread Dejin Zheng
On Mon, May 04, 2020 at 12:32:55PM -0700, Jonathan Richardson wrote: > Hi, > > Commit d7a5502b0bb8b (net: broadcom: convert to > devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver. > probe fails with -22. idm_base and nicpm_base were optional. Now they > are mandatory. Our upstre

Re: bgmac-enet driver broken in 5.7

2020-05-04 Thread Florian Fainelli
On 5/4/2020 1:24 PM, Jonathan Richardson wrote: > On Mon, May 4, 2020 at 1:20 PM Florian Fainelli wrote: >> >> >> >> On 5/4/2020 12:32 PM, Jonathan Richardson wrote: >>> Hi, >>> >>> Commit d7a5502b0bb8b (net: broadcom: convert to >>> devm_platform_ioremap_resource_byname()) broke the bgmac-enet

Re: bgmac-enet driver broken in 5.7

2020-05-04 Thread Jonathan Richardson
On Mon, May 4, 2020 at 1:20 PM Florian Fainelli wrote: > > > > On 5/4/2020 12:32 PM, Jonathan Richardson wrote: > > Hi, > > > > Commit d7a5502b0bb8b (net: broadcom: convert to > > devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver. > > probe fails with -22. idm_base and nicpm_bas

Re: bgmac-enet driver broken in 5.7

2020-05-04 Thread Florian Fainelli
On 5/4/2020 12:32 PM, Jonathan Richardson wrote: > Hi, > > Commit d7a5502b0bb8b (net: broadcom: convert to > devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver. > probe fails with -22. idm_base and nicpm_base were optional. Now they > are mandatory. Our upstream dtb doesn't ha

bgmac-enet driver broken in 5.7

2020-05-04 Thread Jonathan Richardson
Hi, Commit d7a5502b0bb8b (net: broadcom: convert to devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver. probe fails with -22. idm_base and nicpm_base were optional. Now they are mandatory. Our upstream dtb doesn't have them defined. I'm not clear on why this change was made. Can