On Mon, May 04, 2020 at 05:37:18PM -0700, Jonathan Richardson wrote: > On Mon, May 4, 2020 at 5:30 PM Dejin Zheng <zhengdej...@gmail.com> wrote: > > > > On Mon, May 04, 2020 at 12:32:55PM -0700, Jonathan Richardson wrote: > > > Hi, > > > > > > Commit d7a5502b0bb8b (net: broadcom: convert to > > > devm_platform_ioremap_resource_byname()) broke the bgmac-enet driver. > > > probe fails with -22. idm_base and nicpm_base were optional. Now they > > > are mandatory. Our upstream dtb doesn't have them defined. I'm not > > > clear on why this change was made. Can it be reverted? > > > > > Jon, I am so sorry for that, I will submit a cl to reverted it to make > > idm_base and nicpm_base as optional. sorry! > > No problem. I'll let you submit the fix then. Thanks for taking care of it.
Thank you very much for giving me this opportunity to deal with my mistakes. at the same time, I apologize for the trouble to bring you. now, I have submitted a cl is here: http://patchwork.ozlabs.org/project/netdev/patch/20200505020329.31638-1-zhengdej...@gmail.com/ I hope it solves this problem. sorry! I will be more careful with each new patch. Thanks! BR, Dejin
