Re: (2) FW: [Resource Leak] Suggesting patch for tcp_close

2018-11-28 Thread Eric Dumazet
On 11/27/2018 10:17 PM, 배석진 wrote: >>> we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK. >> >> These sessions should have a timer, and eventually disappear. > > FIN_WAIT2 and TIME_WAIT have a timer. > but FIN_WAIT1 and LAST_ACK are have too? Sure. Otherwise we have a more

RE:(2) (2) FW: [Resource Leak] Suggesting patch for tcp_close

2018-11-28 Thread 배석진
> What harm is caused by these stale sessions? I thought that was the > intended behaviour. > our system stability guys concern about this. when its count grows up too much, whether it can be harm to system or not. > If you look at the original design discussions that led to the > SOCK_DESTROY an

Re: (2) FW: [Resource Leak] Suggesting patch for tcp_close

2018-11-27 Thread Lorenzo Colitti
On Tue, Nov 27, 2018 at 10:17 PM 배석진 wrote: > >> we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK. > > > > These sessions should have a timer, and eventually disappear. > > FIN_WAIT2 and TIME_WAIT have a timer. > but FIN_WAIT1 and LAST_ACK are have too? What harm is caused by

RE:(2) FW: [Resource Leak] Suggesting patch for tcp_close

2018-11-27 Thread 배석진
>> we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK. > > These sessions should have a timer, and eventually disappear. FIN_WAIT2 and TIME_WAIT have a timer. but FIN_WAIT1 and LAST_ACK are have too? > Do you have a test to demonstrate the issue ? > > I know Lorenzo wrote te

Re: FW: [Resource Leak] Suggesting patch for tcp_close

2018-11-27 Thread Eric Dumazet
On 11/27/2018 08:57 PM, Eric Dumazet wrote: > > > On 11/27/2018 05:09 PM, 배석진 wrote: >> Hello all, >> >> nobody concern about this? minor problem? :( >> we saw hundreds of not closed tcp session with FIN_WAIT1 and LAST_ACK. > > These sessions should have a timer, and eventually disappear. >

Re: FW: [Resource Leak] Suggesting patch for tcp_close

2018-11-27 Thread Eric Dumazet
> >   > - Original Message - > Sender : 배석진  Staff Engineer/System개발2그룹(무선)/삼성전자 > Date   : 2018-11-23 16:22 (GMT+9) > Title  : Suggesting patch for tcp_close >   > Dear all, >   >   > This is Soukin Bae working on Samsung Elec. Mobile Division. &g

FW: [Resource Leak] Suggesting patch for tcp_close

2018-11-27 Thread 배석진
e the fin-ack frequently. thanks,   - Original Message - Sender : 배석진  Staff Engineer/System개발2그룹(무선)/삼성전자 Date   : 2018-11-23 16:22 (GMT+9) Title  : Suggesting patch for tcp_close   Dear all,     This is Soukin Bae working on Samsung Elec. Mobile Division. we have a problem wit

Suggesting patch for tcp_close

2018-11-22 Thread 배석진
Dear all, This is Soukin Bae working on Samsung Elec. Mobile Division. we have a problem with tcp closing. in shortly, 1. on 4-way handshking to close session 2. if ack pkt is not arrived from opposite side 3. then session can't be closed forever in mobile device, condition 2 can be happend i