Re: net-2.6.24 failure with netconsole

2007-08-22 Thread Thomas Graf
* Andrew Morton <[EMAIL PROTECTED]> 2007-08-21 22:54 > Which used to be a BUG. It later oopsed via a null-pointer deref in > net_rx_action(), which is a much preferable result. I fixed this already Index: net-2.6.24/include/linux/netpoll.h

Re: net-2.6.24 failure with netconsole

2007-08-22 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 21 Aug 2007 22:54:38 -0700 > Has anyone tested all this new napi stuff with netconsole? It's pretty > disastrous. It immediately goes BUG in napi_enable(). Thomas Graf has found and fixed a bug in the netconsole napi bits a few hours ago, maybe

Re: net-2.6.24 failure with netconsole

2007-08-22 Thread Herbert Xu
Andrew Morton <[EMAIL PROTECTED]> wrote: > > David, there's basically no reason ever why anyone should add BUG() or > BUG_ON() to net code. Please consider rejecting any patches which add new > ones. WARN_ON() is *much* better. It at least gives the user a chance of > getting some disgnostic in