Andrew Morton <[EMAIL PROTECTED]> wrote: > > David, there's basically no reason ever why anyone should add BUG() or > BUG_ON() to net code. Please consider rejecting any patches which add new > ones. WARN_ON() is *much* better. It at least gives the user a chance of > getting some disgnostic info out, of performing additional tests or even of > using their kernel if they want to test something else. The only reason to > choose BUG over WARN is if we're actually concerned about scrogging > people's data, or serious things like that (ie: filesystems and mm).
Well, for networking if we continue after a serious coding error it could result in a remote kernel compromise. So BUG_ON/BUG is not entirely useless. I'm not claiming that it's necessarily the case here though :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
