Re: call panic if nl_table allocation fails

2006-08-29 Thread David Miller
From: Akinobu Mita <[EMAIL PROTECTED]> Date: Wed, 23 Aug 2006 20:37:40 +0900 > This patch makes crash happen if initialization of nl_table fails > in initcalls. It is better than getting use after free crash later. > > Cc: Patrick McHardy <[EMAIL PROTECTED]> > Cc: David Miller <[EMAIL PROTECTED]>

Re: call panic if nl_table allocation fails

2006-08-23 Thread Patrick McHardy
James Morris wrote: > On Wed, 23 Aug 2006, Akinobu Mita wrote: > > >>This patch makes crash happen if initialization of nl_table fails >>in initcalls. It is better than getting use after free crash later. > > >> nl_table = kcalloc(MAX_LINKS, sizeof(*nl_table), GFP_KERNEL); > > > Perhaps

Re: call panic if nl_table allocation fails

2006-08-23 Thread James Morris
On Wed, 23 Aug 2006, Akinobu Mita wrote: > This patch makes crash happen if initialization of nl_table fails > in initcalls. It is better than getting use after free crash later. > nl_table = kcalloc(MAX_LINKS, sizeof(*nl_table), GFP_KERNEL); Perhaps it'd be better to declare this as an ar