James Morris wrote: > On Wed, 23 Aug 2006, Akinobu Mita wrote: > > >>This patch makes crash happen if initialization of nl_table fails >>in initcalls. It is better than getting use after free crash later. > > >> nl_table = kcalloc(MAX_LINKS, sizeof(*nl_table), GFP_KERNEL); > > > Perhaps it'd be better to declare this as an array rather than allocating > it at runtime.
That would still leave the MAX_LINKS allocations for the pid hashes which need to be allocated because they are dynamically sized. We could delay the pid hash allocations until the first bind happens of course, but I doubt it would be worth it since they start with just a single bucket. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
