Re: [patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c

2017-05-16 Thread Jiri Pirko
Tue, May 16, 2017 at 11:03:14PM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 16, 2017 at 2:00 PM, Jiri Pirko wrote: >> Tue, May 16, 2017 at 10:25:35PM CEST, xiyou.wangc...@gmail.com wrote: >>>On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: From: Jiri Pirko Move tc_classi

Re: [patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c

2017-05-16 Thread Cong Wang
On Tue, May 16, 2017 at 2:00 PM, Jiri Pirko wrote: > Tue, May 16, 2017 at 10:25:35PM CEST, xiyou.wangc...@gmail.com wrote: >>On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Move tc_classify function to cls_api.c where it belongs, rename it to >>> fit the namespac

Re: [patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c

2017-05-16 Thread Jiri Pirko
Tue, May 16, 2017 at 10:25:35PM CEST, xiyou.wangc...@gmail.com wrote: >On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Move tc_classify function to cls_api.c where it belongs, rename it to >> fit the namespace. >> > >It is not a pure move, you silently remove the CON

Re: [patch net-next v3 01/10] net: sched: move tc_classify function to cls_api.c

2017-05-16 Thread Cong Wang
On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Move tc_classify function to cls_api.c where it belongs, rename it to > fit the namespace. > It is not a pure move, you silently remove the CONFIG_NET_CLS_ACT macros in tc_classify(). Probably not buggy, just redundancy w