Re: [RFC net] net: dsa: Centralize validation of VLAN configuration

2021-03-15 Thread Vladimir Oltean
On Sun, Mar 14, 2021 at 10:40:55PM +0100, Tobias Waldekranz wrote: > On Wed, Mar 10, 2021 at 00:01, Vladimir Oltean wrote: > > +test_vlan_upper_join_vlan_aware_bridge_which_contains_another_physical_port() > > +{ > > + ip link add br0 type bridge vlan_filtering 1 > > + ip link add link ${eth0}

Re: [RFC net] net: dsa: Centralize validation of VLAN configuration

2021-03-14 Thread Tobias Waldekranz
On Wed, Mar 10, 2021 at 00:01, Vladimir Oltean wrote: > On Tue, Mar 09, 2021 at 10:28:11PM +0100, Tobias Waldekranz wrote: >> On Tue, Mar 09, 2021 at 12:40, Florian Fainelli wrote: >> > On 3/9/21 10:42 AM, Tobias Waldekranz wrote: >> >> There are three kinds of events that have an inpact on VLAN

Re: [RFC net] net: dsa: Centralize validation of VLAN configuration

2021-03-09 Thread Vladimir Oltean
On Wed, Mar 10, 2021 at 01:30:33AM +0100, Andrew Lunn wrote: > On Tue, Mar 09, 2021 at 10:28:11PM +0100, Tobias Waldekranz wrote: > > Hi Tobias > > As with Florian, i've not been following the discussion. I'm afraid there isn't much context for these patches, except Tobias pointing out that some

Re: [RFC net] net: dsa: Centralize validation of VLAN configuration

2021-03-09 Thread Andrew Lunn
> > .100 br0 .100 > >\ / \ / > >lan0 lan1 > > > > $ ip link add dev br0 type bridge vlan_filtering 1 > > $ ip link add dev lan0.100 link lan0 type vlan id 100 > > $ ip link add dev lan1.100 link lan1 type vlan id 100 > > $ ip link set dev lan0 master br0 > > $ ip link set dev lan1 mast

Re: [RFC net] net: dsa: Centralize validation of VLAN configuration

2021-03-09 Thread Andrew Lunn
On Tue, Mar 09, 2021 at 10:28:11PM +0100, Tobias Waldekranz wrote: Hi Tobias As with Florian, i've not been following the discussion. > Yeah sorry, I can imagine that makes no sense whatsoever without the > context of the recent discussions. It is basically guarding against this > situation: >

Re: [RFC net] net: dsa: Centralize validation of VLAN configuration

2021-03-09 Thread Vladimir Oltean
On Tue, Mar 09, 2021 at 10:28:11PM +0100, Tobias Waldekranz wrote: > On Tue, Mar 09, 2021 at 12:40, Florian Fainelli wrote: > > On 3/9/21 10:42 AM, Tobias Waldekranz wrote: > >> There are three kinds of events that have an inpact on VLAN > >> configuration of DSA ports: > >> > >> - Adding of stac

Re: [RFC net] net: dsa: Centralize validation of VLAN configuration

2021-03-09 Thread Tobias Waldekranz
On Tue, Mar 09, 2021 at 12:40, Florian Fainelli wrote: > On 3/9/21 10:42 AM, Tobias Waldekranz wrote: >> There are three kinds of events that have an inpact on VLAN >> configuration of DSA ports: >> >> - Adding of stacked VLANs >> (ip link add dev swp0.1 link swp0 type vlan id 1) >> >> - Addin

Re: [RFC net] net: dsa: Centralize validation of VLAN configuration

2021-03-09 Thread Florian Fainelli
On 3/9/21 10:42 AM, Tobias Waldekranz wrote: > There are three kinds of events that have an inpact on VLAN > configuration of DSA ports: > > - Adding of stacked VLANs > (ip link add dev swp0.1 link swp0 type vlan id 1) > > - Adding of bridged VLANs > (bridge vlan add dev swp0 vid 1) > > - Ch