Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread David Miller
From: Jesse Brandeburg Date: Tue, 1 Dec 2015 15:44:54 -0800 > While I agree that ethtool provides a similar functionality, ethtool > was designed (particularly the ethtool -C/c commands) around one queue > NICs. We can't change the output or functionality of the user > interface without breaking

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread David Miller
From: Florian Fainelli Date: Tue, 01 Dec 2015 14:13:34 -0800 > The new interface you propose makes things inconsistent, since we have > two separate configuration paths (sysfs and ethtool), and it would seem > better to have per-queue awareness in ethtool, since there is a whole > bunch of other

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread Alexander Duyck
On Tue, Dec 1, 2015 at 3:44 PM, Jesse Brandeburg wrote: > On Tue, 1 Dec 2015 14:13:34 -0800 > Florian Fainelli wrote: > >> On 01/12/15 00:01, kan.li...@intel.com wrote: >> > From: Kan Liang >> > >> > Network devices usually have many queues. Each queue has its own >> > tx_usecs options. Currentl

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread Jesse Brandeburg
On Tue, 1 Dec 2015 14:13:34 -0800 Florian Fainelli wrote: > On 01/12/15 00:01, kan.li...@intel.com wrote: > > From: Kan Liang > > > > Network devices usually have many queues. Each queue has its own > > tx_usecs options. Currently, we can only set all the queues with same > > value by ethtool.

Re: [RFC 1/4] net: support per queue tx_usecs in sysfs

2015-12-01 Thread Florian Fainelli
On 01/12/15 00:01, kan.li...@intel.com wrote: > From: Kan Liang > > Network devices usually have many queues. Each queue has its own > tx_usecs options. Currently, we can only set all the queues with same > value by ethtool. This patch expose the tx_usecs in sysfs. So the user > can set/get per q