Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

2017-07-27 Thread Or Gerlitz
On Wed, Jul 26, 2017 at 11:11 PM, Jakub Kicinski wrote: > On Wed, 26 Jul 2017 12:23:17 +0300, Or Gerlitz wrote: >> On Wed, Jul 26, 2017 at 11:13 AM, Jakub Kicinski wrote: >> > On Wed, 26 Jul 2017 07:48:40 +0200, Jiri Pirko wrote: >> >> >> I think it would make sense if the driver would just fill-

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

2017-07-26 Thread Jakub Kicinski
On Wed, 26 Jul 2017 12:23:17 +0300, Or Gerlitz wrote: > On Wed, Jul 26, 2017 at 11:13 AM, Jakub Kicinski wrote: > > On Wed, 26 Jul 2017 07:48:40 +0200, Jiri Pirko wrote: > > >> I think it would make sense if the driver would just fill-up a struct in > >> the ndo call and core would generate the

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

2017-07-26 Thread Andy Gospodarek
On Tue, Jul 25, 2017 at 07:34:47PM -0700, Jakub Kicinski wrote: > On Tue, 25 Jul 2017 21:48:15 -0400, Andy Gospodarek wrote: > > On Tue, Jul 25, 2017 at 03:26:47PM -0700, Jakub Kicinski wrote: > > > On Tue, 25 Jul 2017 11:22:41 -0400, Andy Gospodarek wrote: > > > > On Mon, Jul 24, 2017 at 10:13:4

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

2017-07-26 Thread Or Gerlitz
On Wed, Jul 26, 2017 at 11:13 AM, Jakub Kicinski wrote: > On Wed, 26 Jul 2017 07:48:40 +0200, Jiri Pirko wrote: >> I think it would make sense if the driver would just fill-up a struct in >> the ndo call and core would generate the string. > I do like the idea of core generating the string. I h

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

2017-07-26 Thread Jakub Kicinski
On Wed, 26 Jul 2017 07:48:40 +0200, Jiri Pirko wrote: > Tue, Jul 25, 2017 at 07:13:44AM CEST, jakub.kicin...@netronome.com wrote: > >We are still in position where we can suggest uniform naming > >convention for ndo_get_phys_port_name(). switchdev.txt file > >already contained a suggestion of how

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

2017-07-25 Thread Jiri Pirko
Tue, Jul 25, 2017 at 07:13:44AM CEST, jakub.kicin...@netronome.com wrote: >We are still in position where we can suggest uniform naming >convention for ndo_get_phys_port_name(). switchdev.txt file >already contained a suggestion of how to name external ports. >Since the use of switchdev for SR-IOV

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

2017-07-25 Thread Jakub Kicinski
On Tue, 25 Jul 2017 21:48:15 -0400, Andy Gospodarek wrote: > On Tue, Jul 25, 2017 at 03:26:47PM -0700, Jakub Kicinski wrote: > > On Tue, 25 Jul 2017 11:22:41 -0400, Andy Gospodarek wrote: > > > On Mon, Jul 24, 2017 at 10:13:44PM -0700, Jakub Kicinski wrote: > > > > We are still in position wher

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

2017-07-25 Thread Andy Gospodarek
On Tue, Jul 25, 2017 at 03:26:47PM -0700, Jakub Kicinski wrote: > On Tue, 25 Jul 2017 11:22:41 -0400, Andy Gospodarek wrote: > > On Mon, Jul 24, 2017 at 10:13:44PM -0700, Jakub Kicinski wrote: > > > We are still in position where we can suggest uniform naming > > > convention for ndo_get_phys_port_

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

2017-07-25 Thread Jakub Kicinski
On Tue, 25 Jul 2017 11:22:41 -0400, Andy Gospodarek wrote: > On Mon, Jul 24, 2017 at 10:13:44PM -0700, Jakub Kicinski wrote: > > We are still in position where we can suggest uniform naming > > convention for ndo_get_phys_port_name(). switchdev.txt file > > already contained a suggestion of how to

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

2017-07-25 Thread Andy Gospodarek
On Mon, Jul 24, 2017 at 10:13:44PM -0700, Jakub Kicinski wrote: > We are still in position where we can suggest uniform naming > convention for ndo_get_phys_port_name(). switchdev.txt file > already contained a suggestion of how to name external ports. > Since the use of switchdev for SR-IOV NIC's