On Tue, 25 Jul 2017 11:22:41 -0400, Andy Gospodarek wrote:
> On Mon, Jul 24, 2017 at 10:13:44PM -0700, Jakub Kicinski wrote:
> > We are still in position where we can suggest uniform naming
> > convention for ndo_get_phys_port_name(). switchdev.txt file
> > already contained a suggestion of how to name external ports.
> > Since the use of switchdev for SR-IOV NIC's eswitches is growing,
> > establish a format for ports of those devices as well.
> >
> > Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com>
>
> This is a nice addition and I suspect there could be even more done to
> update this file to cover the VF rep usage.
>
> > ---
> > Documentation/networking/switchdev.txt | 14 +++++++++++---
> > 1 file changed, 11 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/networking/switchdev.txt
> > b/Documentation/networking/switchdev.txt
> > index 3e7b946dea27..7c4b6025fb4b 100644
> > --- a/Documentation/networking/switchdev.txt
> > +++ b/Documentation/networking/switchdev.txt
> > @@ -119,9 +119,17 @@ into 4 10G ports, resulting in 4 port netdevs, the
> > device can give a unique
> > SUBSYSTEM=="net", ACTION=="add", ATTR{phys_switch_id}=="<phys_switch_id>",
> > \
> > ATTR{phys_port_name}!="", NAME="swX$attr{phys_port_name}"
> >
> > -Suggested naming convention is "swXpYsZ", where X is the switch name or
> > ID, Y
> > -is the port name or ID, and Z is the sub-port name or ID. For example,
> > sw1p1s0
> > -would be sub-port 0 on port 1 on switch 1.
> > +Suggested formats of the port name returned by ndo_get_phys_port_name are:
> > + - pA for external ports;
> > + - pAsB for split external ports;
> > + - pfC for PF ports (so called PF representors);
> > + - pfCvfD for VF ports (so called VF representors).
>
> I hate to clutter this up, but might be also need to add:
>
> - pfCsB for split PF ports (so called PF representors);
> - pfCsBvfD for split VF ports (so called VF representors).
>
> or are we comfortable that these additions to the name for split ports
> are implied?
Hm.. What is a split PF port? Splits happen on the physical port - see
my rant on the thread this is a reply to ;) PFs are PCIe functions,
on the opposite side of the eswitch from the wires.
