Re: [PATCHv2 net-next 1/3] ip_gre: Refector the erpsan tunnel code.

2017-11-13 Thread William Tu
On Sat, Nov 11, 2017 at 2:07 AM, David Miller wrote: > From: William Tu > Date: Wed, 8 Nov 2017 16:13:02 -0800 > >> +static void erspan_build_header(struct sk_buff *skb, >> + __be32 id, u32 index, >> + bool truncate, bool is_ipv4) >> +{ > >

Re: [PATCHv2 net-next 1/3] ip_gre: Refector the erpsan tunnel code.

2017-11-11 Thread David Miller
From: William Tu Date: Wed, 8 Nov 2017 16:13:02 -0800 > +static void erspan_build_header(struct sk_buff *skb, > + __be32 id, u32 index, > + bool truncate, bool is_ipv4) > +{ Please do not put large non-inline functions into header files.