On Sat, Nov 11, 2017 at 2:07 AM, David Miller <da...@davemloft.net> wrote:
> From: William Tu <u9012...@gmail.com>
> Date: Wed,  8 Nov 2017 16:13:02 -0800
>
>> +static void erspan_build_header(struct sk_buff *skb,
>> +                             __be32 id, u32 index,
>> +                             bool truncate, bool is_ipv4)
>> +{
>
> Please do not put large non-inline functions into header files.

Thanks. I will make it inline in the next version.

Reply via email to