Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support

2019-07-30 Thread Shannon Nelson
On 7/25/19 6:35 AM, Andrew Lunn wrote: +static int ionic_get_module_eeprom(struct net_device *netdev, + struct ethtool_eeprom *ee, + u8 *data) +{ + struct lif *lif = netdev_priv(netdev); + struct ionic_dev *idev = &lif-

Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support

2019-07-30 Thread Shannon Nelson
On 7/24/19 5:17 PM, Saeed Mahameed wrote: On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: Add in the basic ethtool callbacks for device information and control. Signed-off-by: Shannon Nelson --- + + while (test_and_set_bit(LIF_QUEUE_RESET, lif->state)) + usleep_

Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support

2019-07-25 Thread Andrew Lunn
> +static int ionic_get_module_eeprom(struct net_device *netdev, > +struct ethtool_eeprom *ee, > +u8 *data) > +{ > + struct lif *lif = netdev_priv(netdev); > + struct ionic_dev *idev = &lif->ionic->idev; > + struct xcvr_sta

Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support

2019-07-25 Thread Andrew Lunn
On Mon, Jul 22, 2019 at 02:40:17PM -0700, Shannon Nelson wrote: > +static void ionic_get_pauseparam(struct net_device *netdev, > + struct ethtool_pauseparam *pause) > +{ > + struct lif *lif = netdev_priv(netdev); > + struct ionic_dev *idev = &lif->ionic->idev;

Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support

2019-07-24 Thread Saeed Mahameed
On Mon, 2019-07-22 at 14:40 -0700, Shannon Nelson wrote: > Add in the basic ethtool callbacks for device information > and control. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/Makefile | 2 +- > .../net/ethernet/pensando/ionic/ionic_dev.h | 3 + > .../eth

Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support

2019-07-23 Thread Shannon Nelson
On 7/23/19 2:35 PM, David Miller wrote: From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:17 -0700 +static int ionic_get_link_ksettings(struct net_device *netdev, + struct ethtool_link_ksettings *ks) +{ + struct lif *lif = netdev_priv(netdev); + st

Re: [PATCH v4 net-next 13/19] ionic: Add initial ethtool support

2019-07-23 Thread David Miller
From: Shannon Nelson Date: Mon, 22 Jul 2019 14:40:17 -0700 > +static int ionic_get_link_ksettings(struct net_device *netdev, > + struct ethtool_link_ksettings *ks) > +{ > + struct lif *lif = netdev_priv(netdev); > + struct ionic_dev *idev = &lif->ionic->ide