Re: [PATCH net-next 5/5] net: dsa: Stop accessing ds->dst->cpu_dp in drivers

2017-06-06 Thread Vivien Didelot
Florian Fainelli writes: > On 06/06/2017 11:09 AM, Vivien Didelot wrote: >> Florian Fainelli writes: >> >>> - phy_mode = of_get_phy_mode(ds->dst->cpu_dp->dn); >>> + phy_mode = of_get_phy_mode(ds->ports[QCA8K_CPU_PORT].dn); >> >> Is it necessary to use QCA8K_CPU_PORT? >> >>> +static inline

Re: [PATCH net-next 5/5] net: dsa: Stop accessing ds->dst->cpu_dp in drivers

2017-06-06 Thread Florian Fainelli
On 06/06/2017 11:09 AM, Vivien Didelot wrote: > Florian Fainelli writes: > >> -phy_mode = of_get_phy_mode(ds->dst->cpu_dp->dn); >> +phy_mode = of_get_phy_mode(ds->ports[QCA8K_CPU_PORT].dn); > > Is it necessary to use QCA8K_CPU_PORT? > >> +static inline struct dsa_port *dsa_ds_get_cpu_dp

Re: [PATCH net-next 5/5] net: dsa: Stop accessing ds->dst->cpu_dp in drivers

2017-06-06 Thread Vivien Didelot
Florian Fainelli writes: > - phy_mode = of_get_phy_mode(ds->dst->cpu_dp->dn); > + phy_mode = of_get_phy_mode(ds->ports[QCA8K_CPU_PORT].dn); Is it necessary to use QCA8K_CPU_PORT? > +static inline struct dsa_port *dsa_ds_get_cpu_dp(struct dsa_switch *ds) > +{ > + return &ds->ports[fl